Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Push changes before trying to create CP branch #3493

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

roryabraham
Copy link
Contributor

Details

Need to push commits made on the CP branch to the remote before we can make a pull request.

Fixed Issues

Fixes failed workflow run https://github.com/Expensify/Expensify.cash/runs/2787778611?check_suite_focus=true

Tests

None.

QA Steps

None.

Tested on

n/a (GH only)

@roryabraham roryabraham requested a review from AndrewGable June 9, 2021 21:17
@roryabraham roryabraham self-assigned this Jun 9, 2021
@roryabraham roryabraham requested a review from a team as a code owner June 9, 2021 21:17
@MelvinBot MelvinBot requested review from mountiny and removed request for a team June 9, 2021 21:17
Copy link
Contributor

@AndrewGable AndrewGable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Going to merge and test CPs again to unblock deploy blocker.

@AndrewGable AndrewGable merged commit 5e041b5 into main Jun 9, 2021
@AndrewGable AndrewGable deleted the Rory-PushChangesToCPBranch branch June 9, 2021 21:22
@OSBotify
Copy link
Contributor

OSBotify commented Jun 9, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.66-13🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@mountiny mountiny removed their request for review June 11, 2021 01:29
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.68-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants