Fix list on some page doesn't show scroll bar #34953

bernhardoj · 2024-01-23T08:51:10Z

Details

We hide the scroll bar by default but now we want to enable it by default.

Fixed Issues

$ #34762
PROPOSAL: #34762 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open a money request page on a collect workspace chat
Enter any amount and next
Open the category and tag page
Verify the category and tag page has a scroll bar (or show when you scroll it, depending on the device)

(for Android & iOS, test it with dark mode)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-23.at.16.42.36.mov

Android: mWeb Chrome

Screen.Recording.2024-01-23.at.16.07.19.mov

iOS: Native

Screen.Recording.2024-01-23.at.16.54.01.mov

iOS: mWeb Safari

Screen.Recording.2024-01-23.at.16.08.22.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-23.at.16.01.14.mov

MacOS: Desktop

Screen.Recording.2024-01-23.at.16.02.32.mov

melvin-bot · 2024-01-23T08:51:15Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2024-01-23T08:55:30Z

Another video showing the scroll bar on other pages.

Screen.Recording.2024-01-23.at.16.35.12.mov

bernhardoj · 2024-01-23T09:01:06Z

src/components/SelectionList/BaseSelectionList.js

@@ -474,7 +472,6 @@ function BaseSelectionList({
                                    onScrollBeginDrag={onScrollBeginDrag}
                                    keyExtractor={(item) => item.keyForList}
                                    extraData={focusedIndex}
-                                    indicatorStyle={theme.white}


indicatorStyle only accepts "black" | "white" | "default" | undefined, but the theme color is a hex string (#FFFFFF), so I remove it because it's invalid

The reason I notice this indicatorStyle is because, in BaseOptionsSelector, we set it to "white"

App/src/components/OptionsList/BaseOptionsList.tsx

Line 244 in c060897

indicatorStyle="white"

and this makes the scroll bar unnoticeable for native on light mode, so we need to test it on dark mode.

Btw, indicatorStyle is only available for iOS. The question is, do we want to dynamically change the indicatorStyle based on the selected theme for iOS only?

I think this is probably a separate issue unrelated to whether or not the scrollbar is visible based on the issue description. However, if you want to tackle this here, then the index.ios.tsx should be updated with the conditional check since it's an iOS-only prop.

Any thoughts on this, @MariaHCD?

The recent TS migration PR corrected the value by passing "white".

I agree that we can handle this scrollbar color in a separate issue.

Agreed that the scrollbar color is out of scope for this PR and issue

akinwale · 2024-01-26T14:28:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

34953-android-native.mp4

Android: mWeb Chrome

34953-android-chrome.mp4

iOS: Native

34953-ios-native.mp4

iOS: mWeb Safari

34953-ios-safari.mp4

MacOS: Chrome / Safari

34953-web.mp4

MacOS: Desktop

34953-desktop.mp4

akinwale · 2024-01-26T14:28:52Z

@bernhardoj Please resolve merge conflicts.

bernhardoj · 2024-01-26T14:45:47Z

Done

akinwale

LGTM.

OSBotify · 2024-01-29T07:36:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-29T19:25:24Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.4.33-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

mvtglobally · 2024-01-31T01:07:52Z

one of the testers running this PR on public domain consistently is getting a crash, but team is not able to reproduce across various devices .
Pls double check internally if repro.

https://github.com/Expensify/App/assets/43995119/2b0654b8-4229-4f54-a321-1101a3578821
https://github.com/Expensify/App/assets/43995119/676fda0f-da8d-4a44-b44d-2f1810e0e81e

OSBotify · 2024-01-31T02:32:15Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.33-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

bernhardoj · 2024-01-31T03:05:50Z

I'm unable to reproduce it

bernhardoj added 2 commits January 23, 2024 16:31

show scrollbar by default

1a75ea2

fix wrong indicator style

5869369

bernhardoj requested a review from a team as a code owner January 23, 2024 08:51

melvin-bot bot requested review from akinwale and removed request for a team January 23, 2024 08:51

add back indicator style

cd01c9a

bernhardoj commented Jan 23, 2024

View reviewed changes

Merge branch 'main' into fix/34762-show-scrollbar

d00540f

akinwale approved these changes Jan 26, 2024

View reviewed changes

melvin-bot bot requested a review from MariaHCD January 26, 2024 16:25

MariaHCD approved these changes Jan 29, 2024

View reviewed changes

MariaHCD merged commit 620f3a0 into Expensify:main Jan 29, 2024
18 checks passed

github-actions bot mentioned this pull request Jan 29, 2024

Deploy Checklist: New Expensify 2024-01-29 #35328

Closed

melvin-bot bot mentioned this pull request Jan 31, 2024

[HOLD for payment 2024-02-07] [$500] Category & Tag - No scroll bar in Category and Tag list #34762

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix list on some page doesn't show scroll bar #34953

Fix list on some page doesn't show scroll bar #34953

bernhardoj commented Jan 23, 2024 •

edited

Loading

melvin-bot bot commented Jan 23, 2024

bernhardoj commented Jan 23, 2024

bernhardoj Jan 23, 2024

akinwale Jan 26, 2024

akinwale Jan 26, 2024

bernhardoj Jan 26, 2024

MariaHCD Jan 29, 2024

akinwale commented Jan 26, 2024

akinwale commented Jan 26, 2024

bernhardoj commented Jan 26, 2024

akinwale left a comment

OSBotify commented Jan 29, 2024

OSBotify commented Jan 29, 2024

mvtglobally commented Jan 31, 2024

OSBotify commented Jan 31, 2024

bernhardoj commented Jan 31, 2024

Fix list on some page doesn't show scroll bar #34953

Fix list on some page doesn't show scroll bar #34953

Conversation

bernhardoj commented Jan 23, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 23, 2024

bernhardoj commented Jan 23, 2024

bernhardoj Jan 23, 2024

Choose a reason for hiding this comment

akinwale Jan 26, 2024

Choose a reason for hiding this comment

akinwale Jan 26, 2024

Choose a reason for hiding this comment

bernhardoj Jan 26, 2024

Choose a reason for hiding this comment

MariaHCD Jan 29, 2024

Choose a reason for hiding this comment

akinwale commented Jan 26, 2024

Reviewer Checklist

Screenshots/Videos

akinwale commented Jan 26, 2024

bernhardoj commented Jan 26, 2024

akinwale left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 29, 2024

OSBotify commented Jan 29, 2024

mvtglobally commented Jan 31, 2024

OSBotify commented Jan 31, 2024

bernhardoj commented Jan 31, 2024

bernhardoj commented Jan 23, 2024 •

edited

Loading