Added the ability to paste Google Docs images / charts into the Composer chat for web based platforms #34971

ikevin127 · 2024-01-23T15:28:29Z

Details

Added the ability to copy objects (not screenshots of objects, just the object itself) from Google Workspace into an Expensify chat, specifically:

Google Sheet images / charts
Google Doc images
Google Slide images

Note: The composer objects paste functionality works only on Web, iOS / Android: mWeb and Desktop. On native platforms we never had the object paste functionality, not even for images as we have had on the other platforms already.

Fixed Issues

For #34306
PROPOSAL: #34306 (comment)

Tests

Web / Desktop steps:

Open app.
Open a report chat.
Open the following google docs links in a new tab each:

Google Sheets: https://docs.google.com/spreadsheets/d/1IzOpclhDLrdBxSD3ZdYF6x38tfQIChl-PdPswY38hek (where we have the instructions image and the chart on the right side)
Google Slides: https://docs.google.com/presentation/d/1Q3lIg1t78ksu4GXYqnavKidgqB5syuDb/edit#slide=id.p10 (where we have an image on slide 10)
Google Docs: https://docs.google.com/document/d/1GYxBeVGk78yv58Ar1uyciZk7YfO6_2bN (where we have an image on the top right corner)

Copy the image / chart from the provided files.
Go back to the app and paste it in the composer.
The Send attachment modal should open with the pasted image / chart.

iOS / Android mWeb steps:

Prerequisite: The Google Sheets / Google Slides / Google Docs apps have to be installed on the device in order to be able to copy images / charts.

Open app.
Open a report chat.
Open the following google docs links in their corresponding apps from (prerequisite step):

Google Sheets: https://docs.google.com/spreadsheets/d/1IzOpclhDLrdBxSD3ZdYF6x38tfQIChl-PdPswY38hek (where we have the instructions image and the chart on the right side)
Google Slides: https://docs.google.com/presentation/d/1Q3lIg1t78ksu4GXYqnavKidgqB5syuDb/edit#slide=id.p10 (where we have an image on slide 10)
Google Docs: https://docs.google.com/document/d/1GYxBeVGk78yv58Ar1uyciZk7YfO6_2bN (where we have an image on the top right corner)

Copy the image / chart from the provided files.
Go back to the app and paste the object.
The Send attachment modal should open with the pasted image / chart.

Verify that no errors appear in the JS console

Offline tests

Web / Desktop steps:

Open app.
Open a report chat.
Open the following google docs links in a new tab each:

Google Sheets: https://docs.google.com/spreadsheets/d/1IzOpclhDLrdBxSD3ZdYF6x38tfQIChl-PdPswY38hek (where we have the instructions image and the chart on the right side)
Google Slides: https://docs.google.com/presentation/d/1Q3lIg1t78ksu4GXYqnavKidgqB5syuDb/edit#slide=id.p10 (where we have an image on slide 10)
Google Docs: https://docs.google.com/document/d/1GYxBeVGk78yv58Ar1uyciZk7YfO6_2bN (where we have an image on the top right corner)

Copy the image / chart from the provided files.
Go back to the app and paste it in the composer.
The Send attachment modal should open with the pasted image / chart.

iOS / Android mWeb steps:

Prerequisite: The Google Sheets / Google Slides / Google Docs apps have to be installed on the device in order to be able to copy images / charts.

Open app.
Open a report chat.
Open the following google docs links in their corresponding apps from (prerequisite step):

Google Sheets: https://docs.google.com/spreadsheets/d/1IzOpclhDLrdBxSD3ZdYF6x38tfQIChl-PdPswY38hek (where we have the instructions image and the chart on the right side)
Google Slides: https://docs.google.com/presentation/d/1Q3lIg1t78ksu4GXYqnavKidgqB5syuDb/edit#slide=id.p10 (where we have an image on slide 10)
Google Docs: https://docs.google.com/document/d/1GYxBeVGk78yv58Ar1uyciZk7YfO6_2bN (where we have an image on the top right corner)

Copy the image / chart from the provided files.
Go back to the app and paste the object.
The Send attachment modal should open with the pasted image / chart.

QA Steps

Web / Desktop steps:

Open app.
Open a report chat.
Open the following google docs links in a new tab each:

Google Sheets: https://docs.google.com/spreadsheets/d/1IzOpclhDLrdBxSD3ZdYF6x38tfQIChl-PdPswY38hek (where we have the instructions image and the chart on the right side)
Google Slides: https://docs.google.com/presentation/d/1Q3lIg1t78ksu4GXYqnavKidgqB5syuDb/edit#slide=id.p10 (where we have an image on slide 10)
Google Docs: https://docs.google.com/document/d/1GYxBeVGk78yv58Ar1uyciZk7YfO6_2bN (where we have an image on the top right corner)

Copy the image / chart from the provided files.
Go back to the app and paste it in the composer.
The Send attachment modal should open with the pasted image / chart.

iOS / Android mWeb steps:

Prerequisite: The Google Sheets / Google Slides / Google Docs apps have to be installed on the device in order to be able to copy images / charts.

Open app.
Open a report chat.
Open the following google docs links in their corresponding apps from (prerequisite step):

Google Sheets: https://docs.google.com/spreadsheets/d/1IzOpclhDLrdBxSD3ZdYF6x38tfQIChl-PdPswY38hek (where we have the instructions image and the chart on the right side)
Google Slides: https://docs.google.com/presentation/d/1Q3lIg1t78ksu4GXYqnavKidgqB5syuDb/edit#slide=id.p10 (where we have an image on slide 10)
Google Docs: https://docs.google.com/document/d/1GYxBeVGk78yv58Ar1uyciZk7YfO6_2bN (where we have an image on the top right corner)

Copy the image / chart from the provided files.
Go back to the app and paste the object.
The Send attachment modal should open with the pasted image / chart.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-native.mov

Android: mWeb Chrome

android-mweb.mp4

iOS: Native

ios-native.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-01-23T15:28:35Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Santhosh-Sellavel · 2024-01-23T16:43:56Z

src/components/Composer/index.tsx

+            if (clipboardDataHtml?.includes(CONST.IMAGE_BASE64_MATCH)) {
+                const domparser = new DOMParser();
+                const pastedHTML = clipboardDataHtml;
+                const embeddedImages = domparser.parseFromString(pastedHTML, TEXT_HTML)?.images;
+
+                if (embeddedImages.length > 0 && embeddedImages[0].src) {
+                    const src = embeddedImages[0].src;
+
+                    // convert base64 to file blob
+                    const base64ImageContent = src.split(',')[1];
+                    const mimeType = src.split(';')[0].split(':')[1];
+                    const byteString = atob(base64ImageContent);
+                    const arrayBuffer = new ArrayBuffer(byteString.length);
+                    const uint8Array = new Uint8Array(arrayBuffer);
+                    for (let i = 0; i < byteString.length; i++) {
+                        uint8Array[i] = byteString.charCodeAt(i);
+                    }
+                    const blob = new Blob([arrayBuffer], {type: mimeType});
+                    const file = new File([blob], 'image.jpg', {type: 'image/jpeg'});
+


Can we make use of this available method base64ToFile, DRY up the logic here.

App/src/libs/fileDownload/FileUtils.ts

Line 213 in 82fff8c

function base64ToFile(base64: string, filename: string): File {

Correct, I missed that one. Thanks!

Santhosh-Sellavel · 2024-01-23T16:48:25Z

src/components/Composer/index.tsx

+            // If the clipboardDataHtml contains google sheets html data (pasted chart)
+            if (clipboardDataHtml?.includes(CONST.GOOGLE_SHEETS_HTML_MATCH)) {
+                const domparser = new DOMParser();
+                const pastedHTML = clipboardDataHtml;
+                const dom = domparser.parseFromString(pastedHTML, TEXT_HTML);
+                const sheetHTML = dom.getElementsByTagName('google-sheets-html-origin')?.item(0);
+                const table = sheetHTML?.getElementsByTagName('table')?.item(0);
+
+                if (sheetHTML) {
+                    document.body.appendChild(sheetHTML);
+
+                    // in case there's no table, we'll screenshot the whole pasted sheet
+                    html2canvas(table ?? (sheetHTML as HTMLElement)).then((canvas) => {
+                        const file = FileUtils.dataURItoBlob(canvas.toDataURL('image/png'));
+                        onPasteFile(file);
+                    });
+
+                    // cleanup
+                    document.body.removeChild(sheetHTML);
+                    return;
+                }
+            }


This is not something we want to do here, i.e. we do not want to make any screenshots of objects.

I see, then I will remove that part.
I suppose we're not looking at having functionality that will allow to copy html objects like tables.

Only copy actual objects like charts.

Understood, that's already being covered by the base64 block.
I'll clean it up right now!

I suppose we're not looking at having functionality that will allow to copy html objects like tables.

We would have in the future, I guess. The table should be copied as a table in mark down, that's when it makes sense

Santhosh-Sellavel

Minor Comments, Looks good will continue testing & try and complete the checklist by tomorrow.

src/components/Composer/index.tsx

Santhosh-Sellavel · 2024-01-25T20:01:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: mWeb Chrome

Screen.Recording.2024-01-26.at.1.56.22.AM.mov

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.-.2024-01-26.at.01.39.09.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-01-26.at.1.27.18.mov

MacOS: Desktop

Screen.Recording.2024-01-26.at.1.29.02.AM.mov

Santhosh-Sellavel · 2024-01-25T20:39:56Z

@ikevin127
Can you update outdated screens please in the description?

In this PR we are adding support to copy charts from google sheets, and images from from google workspaces apps like slide, docs, etc.

So please update the test steps accordingly a bit more clearly for QA. Also, give example doc links or sheet links with charts copy is supported.

Update the PR title also meaning fully.

ikevin127 · 2024-01-25T22:10:51Z

Can you update outdated screens please in the description?

In this PR we are adding support to copy charts from google sheets, and images from from google workspaces apps like slide, docs, etc.

So please update the test steps accordingly a bit more clearly for QA. Also, give example doc links or sheet links with charts copy is supported.

Update the PR title also meaning fully.

All done! 🚀

cc @Santhosh-Sellavel

Santhosh-Sellavel

LGTM, tests well!

mountiny · 2024-01-26T13:16:39Z

@ikevin127 can you sync with main please?

ikevin127 · 2024-01-26T14:18:01Z

@mountiny Sure, done!

mountiny · 2024-01-26T14:47:22Z

@ikevin127 i think that did not go well 😅

ikevin127 · 2024-01-29T10:40:59Z

@mountiny My bad, should be good to go now.

Btw for future references, how would you personally perform such a sync in order for it to go well ?
I'm interested in the commands.

mountiny · 2024-01-29T17:29:51Z

@ikevin127 great questions which I personally do not have experience with since I dont have to use a fork of the repo. I assume you need to sync main if your fork and then merge into this branch, that should work fine. Can you ask in Slack, surely other contributors will be able to help you!

mountiny

Thanks!

mountiny · 2024-01-29T17:31:18Z

@ikevin127 well seems like there is still an issue with the reassure tests but that is resolved on main, can you try again?

…ser chat for web based platforms

ikevin127 · 2024-01-29T18:05:21Z

@mountiny Correct, the reassure tests were failing for a while but as of latest main it looks like that was fixed. Thank you!

OSBotify · 2024-01-29T18:11:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-29T19:25:27Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.33-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

francoisl · 2024-01-31T02:12:07Z

The QA team is reporting that this didn't fix the issue - not going to block the deploy on this but I'm removing the $ sign from the PR description so the issue doesn't get closed out now. Please double-check if anything is not working as expected. Thanks!

OSBotify · 2024-01-31T02:32:18Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.33-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

ikevin127 · 2024-01-31T09:18:22Z

@francoisl I think I found the issue: while this was working without any issues on local development and both me and the reviewer's tests passed, there are some things we did not account to on staging / production in order to allow our app to fetch certain external links like the https://lh7-us.googleusercontent.com/... (Google Slides and Google Docs image pasted links).

And this is why only Google Sheets image and chart (both base64) paste works because there are no external links involved on paste.

Currently on staging this is what works and what doesn't:

WORKS: the base64 type of content pasted into the composer works as expected (the image and chart from Google Sheets): https://docs.google.com/spreadsheets/d/1IzOpclhDLrdBxSD3ZdYF6x38tfQIChl-PdPswY38hek (where we have the instructions image and the chart on the right side)
DOES NOT WORK: the googleusercontent.com type links (Google Slides and Google Docs image links) do not work because we get the following error while attempting paste on staging:

Error screenshot

Error text:

index.tsx:253 Refused to connect to 'https://lh7-us.googleusercontent.com/90m8DZGq8BuZrUTVk_IjUFDRW6mNr46eK0sTXdP9ZmwN-5EJZbuqT7Z4S0-WRq9Ctp83mCo9E32hiehRpQUtyHyRmBv9mQh49Ls5L68NLBWW-UALLIH0OaisjZnMOmCZttOIP3F1sVPWlhLtM8wCRQ' 
because it violates the following Content Security Policy directive: "connect-src 'self' https://*.pusher.com wss://*.pusher.com https://*.pusherapp.com https://secure.expensify.com https://staging-secure.expensify.com https://staging.expensify.com https://www.expensify.com https://accounts.google.com/gsi/ wss://sync.onfido.com https://telephony.onfido.com blob: *.onfido.com wss://*.onfido.com https://www.woopra.com https://sentry.io https://*.tiles.mapbox.com https://api.mapbox.com https://events.mapbox.com".

(anonymous) @ index.tsx:253
index.tsx:253 Refused to connect to 'https://lh7-us.googleusercontent.com/90m8DZGq8BuZrUTVk_IjUFDRW6mNr46eK0sTXdP9ZmwN-5EJZbuqT7Z4S0-WRq9Ctp83mCo9E32hiehRpQUtyHyRmBv9mQh49Ls5L68NLBWW-UALLIH0OaisjZnMOmCZttOIP3F1sVPWlhLtM8wCRQ' because it violates the document's Content Security Policy.
(anonymous) @ index.tsx:253
index.tsx:253 Uncaught (in promise) TypeError: Failed to fetch
at HTMLDocument.<anonymous> (index.tsx:253:25)

Which by the error message we can figure that our Content Security Policy directive: "connect-src" needs to be updated by adding the https://*.googleusercontent.com connect-src directive.

I think this can be fixed by a member of the team and it doesn't require pushing any other changes from this PR's point of view. I'm awaiting confirmation from a team member though! 🙌

cc @mountiny @Santhosh-Sellavel

mountiny · 2024-01-31T14:22:07Z

PR raised internally

ikevin127 · 2024-02-02T02:17:14Z

Both scenarios work as expected since the internal PR was merged - covering Google Sheets / Slides / Docs images and charts. ✅

More details in the comment I posted on the issue @ #34306 (comment)

Given the current expectations listed in the issue / PR's description and the fact that this was deployed to production 2 days ago - I guess the hold for payment should be added to the issue @ #34306 as the automation failed here.

If we want to extend the functionality in the near future, I gather a new issue / feature request can be opened.

I'd be happy to take on that as well when the time comes! 😁

cc @conorpendergrast

conorpendergrast · 2024-02-02T09:23:19Z

@ikevin127 I've reopened #34306 (comment) to make sure payment happens!

ikevin127 · 2024-02-02T10:21:21Z

@conorpendergrast I'm a bit confused as to the hold for payment date assigned to the issue being 2024-02-14 👀

As far as I remember the hold is 7 days from the point when the deploy to production was completed.

As per this comment #34971 (comment), the fix was deployed to production 2 days ago (2024-01-31, 4:32 EET) which would make the hold for payment date 2024-02-07 at the latest.

Is there any reason why it's an extra week for this one or did the hold period increase by 1 week for everybody sometime recently ? ✌️

conorpendergrast · 2024-02-02T10:51:29Z

For absolutely no reason beyond my Friday brain. Thank you for pointing that out, I have fixed that to have the 7-day window

ikevin127 requested a review from a team as a code owner January 23, 2024 15:28

melvin-bot bot requested review from Santhosh-Sellavel and removed request for a team January 23, 2024 15:28

ikevin127 mentioned this pull request Jan 23, 2024

[Hold for payment 2024-02-07] [$500] MEDIUM: Fix Google Docs copy/paste of images #34306

Closed

3 tasks

ikevin127 force-pushed the fix/34306 branch from ee3afdf to 9c451cb Compare January 23, 2024 16:22

Santhosh-Sellavel suggested changes Jan 23, 2024

View reviewed changes

Santhosh-Sellavel suggested changes Jan 24, 2024

View reviewed changes

src/components/Composer/index.tsx Outdated Show resolved Hide resolved

src/components/Composer/index.tsx Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

ikevin127 changed the title ~~MEDIUM: Fix Google Docs copy/paste of images~~ Added the ability to paste Google Docs images / charts into the Composer chat for web based platforms Jan 25, 2024

Santhosh-Sellavel approved these changes Jan 26, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny January 26, 2024 11:59

mountiny assigned ikevin127 Jan 26, 2024

ikevin127 force-pushed the fix/34306 branch from 39d7201 to 316b6ad Compare January 26, 2024 14:58

mountiny approved these changes Jan 29, 2024

View reviewed changes

Added the ability to paste Google Docs images / charts into the Compo…

8ace304

…ser chat for web based platforms

ikevin127 force-pushed the fix/34306 branch from 316b6ad to 8ace304 Compare January 29, 2024 17:53

mountiny merged commit a65a92b into Expensify:main Jan 29, 2024
14 checks passed

github-actions bot mentioned this pull request Jan 29, 2024

Deploy Checklist: New Expensify 2024-01-29 #35328

Closed

ikevin127 mentioned this pull request Sep 9, 2024

[$250] Top section of Settings doesn't remain fixed like we do on other pages #48736

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added the ability to paste Google Docs images / charts into the Composer chat for web based platforms #34971

Added the ability to paste Google Docs images / charts into the Composer chat for web based platforms #34971

ikevin127 commented Jan 23, 2024 •

edited by francoisl

Loading

melvin-bot bot commented Jan 23, 2024

Santhosh-Sellavel Jan 23, 2024

ikevin127 Jan 23, 2024

Santhosh-Sellavel Jan 23, 2024

ikevin127 Jan 23, 2024

Santhosh-Sellavel Jan 23, 2024

ikevin127 Jan 23, 2024

Santhosh-Sellavel Jan 23, 2024

Santhosh-Sellavel left a comment •

edited

Loading

Santhosh-Sellavel commented Jan 25, 2024 •

edited

Loading

Santhosh-Sellavel commented Jan 25, 2024

This comment was marked as outdated.

ikevin127 commented Jan 25, 2024

Santhosh-Sellavel left a comment

mountiny commented Jan 26, 2024

ikevin127 commented Jan 26, 2024

mountiny commented Jan 26, 2024

ikevin127 commented Jan 29, 2024

mountiny commented Jan 29, 2024

mountiny left a comment

mountiny commented Jan 29, 2024

ikevin127 commented Jan 29, 2024

OSBotify commented Jan 29, 2024

OSBotify commented Jan 29, 2024

francoisl commented Jan 31, 2024

OSBotify commented Jan 31, 2024

ikevin127 commented Jan 31, 2024

mountiny commented Jan 31, 2024

ikevin127 commented Feb 2, 2024

conorpendergrast commented Feb 2, 2024 •

edited

Loading

ikevin127 commented Feb 2, 2024

conorpendergrast commented Feb 2, 2024

Added the ability to paste Google Docs images / charts into the Composer chat for web based platforms #34971

Added the ability to paste Google Docs images / charts into the Composer chat for web based platforms #34971

Conversation

ikevin127 commented Jan 23, 2024 • edited by francoisl Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 23, 2024

Santhosh-Sellavel Jan 23, 2024

Choose a reason for hiding this comment

ikevin127 Jan 23, 2024

Choose a reason for hiding this comment

Santhosh-Sellavel Jan 23, 2024

Choose a reason for hiding this comment

ikevin127 Jan 23, 2024

Choose a reason for hiding this comment

Santhosh-Sellavel Jan 23, 2024

Choose a reason for hiding this comment

ikevin127 Jan 23, 2024

Choose a reason for hiding this comment

Santhosh-Sellavel Jan 23, 2024

Choose a reason for hiding this comment

Santhosh-Sellavel left a comment • edited Loading

Choose a reason for hiding this comment

Santhosh-Sellavel commented Jan 25, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

Santhosh-Sellavel commented Jan 25, 2024

This comment was marked as outdated.

ikevin127 commented Jan 25, 2024

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

mountiny commented Jan 26, 2024

ikevin127 commented Jan 26, 2024

mountiny commented Jan 26, 2024

ikevin127 commented Jan 29, 2024

mountiny commented Jan 29, 2024

mountiny left a comment

Choose a reason for hiding this comment

mountiny commented Jan 29, 2024

ikevin127 commented Jan 29, 2024

OSBotify commented Jan 29, 2024

OSBotify commented Jan 29, 2024

francoisl commented Jan 31, 2024

OSBotify commented Jan 31, 2024

ikevin127 commented Jan 31, 2024

mountiny commented Jan 31, 2024

ikevin127 commented Feb 2, 2024

conorpendergrast commented Feb 2, 2024 • edited Loading

ikevin127 commented Feb 2, 2024

conorpendergrast commented Feb 2, 2024

ikevin127 commented Jan 23, 2024 •

edited by francoisl

Loading

Santhosh-Sellavel left a comment •

edited

Loading

Santhosh-Sellavel commented Jan 25, 2024 •

edited

Loading

conorpendergrast commented Feb 2, 2024 •

edited

Loading