Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default isLoading to false for reimbursementAccount param in WorkspacePageWithSections.tsx #35098

Merged
merged 7 commits into from
Jan 24, 2024
+3 −2
Merged

Default isLoading to false for reimbursementAccount param in WorkspacePageWithSections.tsx #35098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
25b802e
Default shouldShowLoading to false in WorkspacePageWithSections
cristipaval Jan 24, 2024
1ba471f
revert bad initial change
cristipaval Jan 24, 2024
4144222
Fix deploy blocker
cristipaval Jan 24, 2024
fd6abea
Remove console debug
cristipaval Jan 24, 2024
0799200
make currentStep option in ACHData
cristipaval Jan 24, 2024
ba79d4e
Use ReimbursementAccountProps.reimbursementAccountDefaultProps
cristipaval Jan 24, 2024
20f70c6
Run prettier
cristipaval Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/pages/workspace/WorkspacePageWithSections.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import useThemeStyles from '@hooks/useThemeStyles';
import BankAccount from '@libs/models/BankAccount';
import Navigation from '@libs/Navigation/Navigation';
import * as PolicyUtils from '@libs/PolicyUtils';
import * as ReimbursementAccountProps from '@pages/ReimbursementAccount/reimbursementAccountPropTypes';
import * as BankAccounts from '@userActions/BankAccounts';
import ONYXKEYS from '@src/ONYXKEYS';
import ROUTES from '@src/ROUTES';
Expand Down Expand Up @@ -79,7 +80,7 @@ function WorkspacePageWithSections({
guidesCallTaskID = '',
headerText,
policy,
reimbursementAccount = {},
reimbursementAccount = ReimbursementAccountProps.reimbursementAccountDefaultProps,
route,
shouldUseScrollView = false,
shouldSkipVBBACall = false,
Expand Down
2 changes: 1 addition & 1 deletion src/types/onyx/ReimbursementAccount.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ type BankAccountSubStep = ValueOf<typeof CONST.BANK_ACCOUNT.SUBSTEP>;

type ACHData = {
/** Step of the setup flow that we are on. Determines which view is presented. */
currentStep: BankAccountStep;
currentStep?: BankAccountStep;

/** Optional subStep we would like the user to start back on */
subStep?: BankAccountSubStep;
Expand Down
Loading