-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Geolocation library for initial IOU release #3514
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Dal-Papa
approved these changes
Jun 10, 2021
# Conflicts: # ios/Podfile.lock
iwiznia
approved these changes
Jun 10, 2021
MonilBhavsar
approved these changes
Jun 11, 2021
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
49 tasks
🚀 Cherry-picked to staging in version: 1.0.68-0🚀
|
🚀 Deployed to production in version: 1.0.68-4🚀
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @trjExpensify @AndrewGable @roryabraham
Details
A part of the submit prod app builds issue.
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/166873
Tests
Confirm preferred currency logic works as expected
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android