Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Geolocation library for initial IOU release #3514

Merged
merged 11 commits into from
Jun 11, 2021
Merged

Conversation

Julesssss
Copy link
Contributor

@Julesssss Julesssss commented Jun 10, 2021

CC @trjExpensify @AndrewGable @roryabraham

Details

A part of the submit prod app builds issue.

  • We need to remove the Geolocation library from our builds, due to an issue raised by Apple's review process (currently we include the location library, but do not use it).
  • I also fixed a bug in the preferred currency code, for which there is a test below

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/166873

Tests

Confirm preferred currency logic works as expected

  • Open the IOU Modal, by clicking 'Request Money' or 'Split bill'
  • Regardless of the previously selected currency, the currency should match your IP location (i.e £ for UK, $AUD for Australia)
  • Tap the currency icon, select any other currency then 'Continue'
  • You should return to the amount page, with the newly selected currency
  • Continue through the steps to the final step (Confirm), then navigate back to the amount page
  • The selected currency should remain
  • Submit the IOU
  • Open the IOU Modal again, by clicking 'Request Money' or 'Split bill'
  • Regardless of the previously selected currency, the currency should match your IP location (i.e £ for UK, $AUD for Australia)

QA Steps

  • Run the above test

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2021-06-10 at 15 10 01

Mobile Web

Simulator Screen Shot - iPhone 11 - 2021-06-10 at 15 11 16

Desktop

Screenshot 2021-06-10 at 15 14 37

iOS

Simulator Screen Shot - iPhone 11 - 2021-06-10 at 15 09 33

Android

Screenshot_1623334567

@Julesssss Julesssss requested review from AndrewGable and a team June 10, 2021 14:32
@Julesssss Julesssss self-assigned this Jun 10, 2021
@MelvinBot MelvinBot requested review from Dal-Papa and removed request for a team June 10, 2021 14:32
# Conflicts:
#	ios/Podfile.lock
@Julesssss Julesssss requested a review from a team as a code owner June 10, 2021 17:29
@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team June 10, 2021 17:30
@Julesssss Julesssss removed the request for review from AndrewGable June 10, 2021 17:30
@MonilBhavsar MonilBhavsar merged commit 58e1584 into main Jun 11, 2021
@MonilBhavsar MonilBhavsar deleted the andrew-location branch June 11, 2021 09:30
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging in version: 1.0.68-0🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.68-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants