Remove IOUCurrencySelection.js and copy any changes since Nov 27 into IOURequestStepCurrency.js #35161

ZhenjaHorbach · 2024-01-25T16:31:52Z

Details

Remove IOUCurrencySelection.js and copy any changes since Nov 27 into IOURequestStepCurrency.js

Fixed Issues

$ #34607
PROPOSAL: #34607 (comment)

Tests

Press on the + button
Choose Request money
On the manual tab, click on currency
Check that everything is working correctly

Create any manual request
Press on any manual request and check amount field
On the open amount, click on currency
Check that everything is working correctly

Create any split request
Press on any split request and check amount field
On the open amount, click on currency
Check that everything is working correctly

Verify that no errors appear in the JS console

Offline tests

Press on the + button
Choose Request money
On the manual tab, click on currency
Check that everything is working correctly

Create any manual request
Press on any manual request and check amount field
On the open amount, click on currency
Check that everything is working correctly

Create any split request
Press on any split request and check amount field
On the open amount, click on currency
Check that everything is working correctly

QA Steps

Press on the + button
Choose Request money
On the manual tab, click on currency
Check that everything is working correctly

Create any manual request
Press on any manual request and check amount field
On the open amount, click on currency
Check that everything is working correctly

Create any split request
Press on any split request and check amount field
On the open amount, click on currency
Check that everything is working correctly

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_meqiRgGc.mp4

Android: mWeb Chrome

android-web_WXqsnNKV.mp4

iOS: Native

ios_vzi0tXcd.mp4

iOS: mWeb Safari

ios-web_f4uzVwpq.mp4

MacOS: Chrome / Safari

web_y6RDAimu.mp4

MacOS: Desktop

desktop_s6CNeDdK.mp4

melvin-bot · 2024-01-25T16:31:57Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2024-01-29T09:39:52Z

@akinwale
Hello )
PR is ready

The only thing, I think is that it is better to wait for this ticket
#34614

Here we have removed the navigation from the component that will be removed

https://github.com/Expensify/App/pull/35161/files#diff-41fd3fdeac58ea33c38c6610c1b1097616fdee916a5f9bf0c9a60c7d0554fddaR119-R123

dangrous · 2024-01-31T16:23:50Z

Hi! So it looks like all of the code in that function you linked (navigateToCurrencySelectionPage) is newer in IOURequestStepAmount than it is in NewRequestAmountPage. Can we update NewRequestAmountPage to use the IOURequestStepAmount function instead, and unblock this PR? I haven't looked into the details so please check it, but that seems like it might work. Thanks!

ZhenjaHorbach · 2024-01-31T16:48:12Z

Hi! So it looks like all of the code in that function you linked (navigateToCurrencySelectionPage) is newer in IOURequestStepAmount than it is in NewRequestAmountPage. Can we update NewRequestAmountPage to use the IOURequestStepAmount function instead, and unblock this PR? I haven't looked into the details so please check it, but that seems like it might work. Thanks!

no problem )
I can do it )

…questStepCurrency

ZhenjaHorbach · 2024-02-04T20:41:02Z

@akinwale
Hello )
PR is ready

akinwale · 2024-02-06T13:41:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

akinwale · 2024-02-06T13:56:52Z

@ZhenjaHorbach When I select Send Money from the global create menu, I get a page not found error when I click on the currency. Please check this.

send-money-bug.mp4

ZhenjaHorbach · 2024-02-06T16:07:41Z

@ZhenjaHorbach When I select Send Money from the global create menu, I get a page not found error when I click on the currency. Please check this.

send-money-bug.mp4

Oh
Strange
I will check today or tomorrow
Thank you )

ZhenjaHorbach · 2024-02-08T18:53:23Z

@ZhenjaHorbach When I select Send Money from the global create menu, I get a page not found error when I click on the currency. Please check this.

send-money-bug.mp4

@akinwale

A few thoughts about this issue
I fixed main issue that we have fullscreen not found

But now we have not Found on IOURequestStepCurrency

Because IOURequestStepCurrency requires availability transationID because we use withFullTransactionOrNotFound

App/src/pages/iou/request/step/IOURequestStepCurrency.js

Lines 181 to 186 in 0445cff

    
           export default compose( 
        
               withFullTransactionOrNotFound, 
        
               withOnyx({ 
        
                   currencyList: {key: ONYXKEYS.CURRENCY_LIST}, 
        
               }), 
        
           )(IOURequestStepCurrency);

But for send money it's not so easy to get transactionID
And I don’t see any point in passing transactionID using route or something like this and making changes in a lot of files

Because the screen, where we have a problem, will be removed soon
#35833

So I'm inclined to just wait so as not to cause unnecessary regressionп

What do you think about it?

akinwale · 2024-02-09T02:20:44Z

@ZhenjaHorbach When I select Send Money from the global create menu, I get a page not found error when I click on the currency. Please check this.
send-money-bug.mp4

@akinwale

A few thoughts about this issue I fixed main issue that we have fullscreen not found

Because IOURequestStepCurrency requires availability transationID because we use withFullTransactionOrNotFound

App/src/pages/iou/request/step/IOURequestStepCurrency.js

Lines 181 to 186 in 0445cff

export default compose(

withFullTransactionOrNotFound,

withOnyx({

currencyList: {key: ONYXKEYS.CURRENCY_LIST},

}),

)(IOURequestStepCurrency);

But for send money it's not so easy to get transactionID And I don’t see any point in passing transactionID using route or something like this and making changes in a lot of files

Because the screen, where we have a problem, will be removed soon #35833

So I'm inclined to just wait so as not to cause unnecessary regressionп

What do you think about it?

@tgolen Any thoughts on this? Do we hold until the other PR is merged?

The regression that led to this discussion: #35161 (comment)

tgolen · 2024-02-09T17:37:27Z

Ah yeah, thanks for asking. I think it would be best to just wait on this one for now until that page is removed.

blazejkustra · 2024-03-19T17:46:02Z

Can we move forward with this? @akinwale @ZhenjaHorbach @tgolen

It's blocking this TS migration 👀

akinwale · 2024-03-19T19:02:01Z

@blazejkustra This PR is on hold for #35833.

If we go ahead and merge anyway, we'll end up with this regression: #35161 (comment)

ZhenjaHorbach · 2024-03-19T19:37:31Z

#35833
This PR will be merged soon
Since the PR that this PR is waiting for is already in the main

So I think it's better to wait a little longer

akinwale · 2024-04-01T23:31:48Z

@ZhenjaHorbach #35833 has been merged.

ZhenjaHorbach · 2024-04-01T23:33:18Z

#35833

Sounds great )
I'll update the PR tomorrow )

ZhenjaHorbach · 2024-04-04T14:01:00Z

Actual PR
#39562

Remove IOUCurrencySelection and update IOURequestStepCurrency PART-1

39ba4f8

ZhenjaHorbach requested a review from a team as a code owner January 25, 2024 16:31

melvin-bot bot requested review from akinwale and removed request for a team January 25, 2024 16:31

ZhenjaHorbach added 8 commits January 25, 2024 19:04

Remove IOUCurrencySelection and update IOURequestStepCurrency PART-2

8b06ca6

Remove IOUCurrencySelection and update IOURequestStepCurrency PART-3

ad8283f

Fix prettier issue

56f06e8

Update branch

34156cf

Fix prettier issue x2

65dea93

Remove IOUCurrencySelection and update IOURequestStepCurrency PART-4

42b31bb

Remove IOUCurrencySelection and update IOURequestStepCurrency PART-5

680e555

Remove IOUCurrencySelection and update IOURequestStepCurrency PART-6

a1cdace

ZhenjaHorbach mentioned this pull request Jan 30, 2024

[HOLD for payment 2024-04-25] [$250] Remove IOUCurrencySelection.js and copy any changes since Nov 27 into IOURequestStepCurrency.js #34607

Closed

Update branch

9ba17f8

ZhenjaHorbach added 4 commits January 31, 2024 18:48

Merge branch 'main' into remove-IOUCurrencySelection-and-update-IOURe…

1347548

…questStepCurrency

Update branch

1d1666c

Delete unnecessary routes

93ce4e6

Update old components for using new route

8b59963

bernhardoj mentioned this pull request Feb 5, 2024

[$250] [TS migration] Migrate 'IOUCurrencySelection' page to TypeScript #31992

Closed

Update branch

33bc3b7

ZhenjaHorbach added 2 commits February 8, 2024 18:23

Update branch

29d39e3

Fix broken screen

0445cff

ZhenjaHorbach added 2 commits February 14, 2024 21:29

Update branch

49e6a02

Update branch x2

8bd1cc0

bernhardoj mentioned this pull request Mar 25, 2024

[HOLD for payment 2024-04-15] [TS migration] Migrate IOURequestStepDescription, IOURequestStepDate and IOURequestStepCurrency pages to TypeScript #38917

Closed

ZhenjaHorbach closed this Apr 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove IOUCurrencySelection.js and copy any changes since Nov 27 into IOURequestStepCurrency.js #35161

Remove IOUCurrencySelection.js and copy any changes since Nov 27 into IOURequestStepCurrency.js #35161

ZhenjaHorbach commented Jan 25, 2024 •

edited

Loading

melvin-bot bot commented Jan 25, 2024

ZhenjaHorbach commented Jan 29, 2024

dangrous commented Jan 31, 2024

ZhenjaHorbach commented Jan 31, 2024

ZhenjaHorbach commented Feb 4, 2024

akinwale commented Feb 6, 2024

akinwale commented Feb 6, 2024

ZhenjaHorbach commented Feb 6, 2024 •

edited

Loading

ZhenjaHorbach commented Feb 8, 2024

akinwale commented Feb 9, 2024

tgolen commented Feb 9, 2024

blazejkustra commented Mar 19, 2024

akinwale commented Mar 19, 2024

ZhenjaHorbach commented Mar 19, 2024

akinwale commented Apr 1, 2024

ZhenjaHorbach commented Apr 1, 2024

ZhenjaHorbach commented Apr 4, 2024

Remove IOUCurrencySelection.js and copy any changes since Nov 27 into IOURequestStepCurrency.js #35161

Remove IOUCurrencySelection.js and copy any changes since Nov 27 into IOURequestStepCurrency.js #35161

Conversation

ZhenjaHorbach commented Jan 25, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 25, 2024

ZhenjaHorbach commented Jan 29, 2024

dangrous commented Jan 31, 2024

ZhenjaHorbach commented Jan 31, 2024

ZhenjaHorbach commented Feb 4, 2024

akinwale commented Feb 6, 2024

Reviewer Checklist

Screenshots/Videos

akinwale commented Feb 6, 2024

ZhenjaHorbach commented Feb 6, 2024 • edited Loading

ZhenjaHorbach commented Feb 8, 2024

akinwale commented Feb 9, 2024

tgolen commented Feb 9, 2024

blazejkustra commented Mar 19, 2024

akinwale commented Mar 19, 2024

ZhenjaHorbach commented Mar 19, 2024

akinwale commented Apr 1, 2024

ZhenjaHorbach commented Apr 1, 2024

ZhenjaHorbach commented Apr 4, 2024

ZhenjaHorbach commented Jan 25, 2024 •

edited

Loading

ZhenjaHorbach commented Feb 6, 2024 •

edited

Loading