Implement suggestion for edit composer

[dukenv0307]

Details

Fixed Issues

$ #34442
PROPOSAL: #34442 (comment)

Tests

1. Open a long-history report
2. Send a message
3. Hover or long-press over the message and select Edit message
4. Typing @ and verify that the mention suggestion is opened
5. Typing a part of an emoji name like :sm and verify that the emoji suggestion is opened
6. Keep the suggestion open and scroll the report screen
7. Verify that the suggestion is closed

• Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

1. Open a long-history report
2. Send a message
3. Hover or long-press over the message and select Edit message
4. Typing @ and verify that the mention suggestion is opened
5. Typing a part of an emoji name like :sm and verify that the emoji suggestion is opened
6. Keep the suggestion open and scroll the report screen
7. Verify that the suggestion is closed

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-20.at.14.38.57.mov

Android: mWeb Chrome

Screen.Recording.2024-02-06.at.23.41.33.mov

iOS: Native

Screen.Recording.2024-03-20.at.14.40.28.mov

iOS: mWeb Safari

Screen.Recording.2024-02-06.at.23.38.26.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-06.at.23.36.55.mov

MacOS: Desktop

Screen.Recording.2024-02-06.at.23.44.50.mov

[melvin-bot]

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[dukenv0307]

@eVoloshchak My native devices don't work. please help to test on these platforms.

[eVoloshchak]

Suggested change

	shouldBelowParentContainer = false,
	shouldBeDisplayedBelowParentContainer = false,

[eVoloshchak]

Suggested change

	if (isSuggestionPickerLarge) {
	if (isSuggestionsPickerLarge) {

And all of the occurances below (i.e. suggestionHeight)

[eVoloshchak]

Let's rename this to SuggestionsActions

[eVoloshchak]

I think this was missed

[eVoloshchak]

There are a couple of bugs (not native-specific)

• Suggestions container for edit composer has a smaller width than for the default composer (notice the blue avatar is partially visible)

Screen.Recording.2024-02-07.at.15.07.20.mov

• Suggestions list is closed if you scroll it to the bottom twice

Screen.Recording.2024-02-07.at.15.10.25.mov

• Suggestions list is closed if you scroll the chat

Screen.Recording.2024-02-07.at.15.14.00.mov

[dukenv0307]

Updating now.

[dukenv0307]

@eVoloshchak

Suggestions container for edit composer has a smaller width than for the default composer (notice the blue avatar is partially visible)

It doesn't happend for me

Screen.Recording.2024-02-20.at.15.35.26.mov

Suggestions list is closed if you scroll it to the bottom twice
Suggestions list is closed if you scroll the chat

I'm closing suggestion for edit composer since the suggestion has a fixed position when it's opened, it will not move when we scroll the report screen.

[dukenv0307]

Updated your suggestion.

[eVoloshchak]

Suggestions container for edit composer has a smaller width than for the default composer (notice the blue avatar is partially visible)

The key here is to have two avatars alongside

1. Press FAB -> Request Money
2. Enter an amount, press next
3. Add two participants to Split, press Split.. to confirm
4. Click on split to open the details, select one of the participants, select Message participant
5. Open emoji suggestion modal for normal and edit composer to observe the difference

Screen.Recording.2024-02-23.at.14.29.51.mov

[dukenv0307]

I can reproduce now.

[eVoloshchak]

@dukenv0307, could you include some test steps so the QA team could test this?

[dukenv0307]

@eVoloshchak Updated the test steps.

[eVoloshchak]

LGTM
Awesome work, @dukenv0307!

[dukenv0307]

@stitesExpensify Please help to review the PR when you have a chance.

[stitesExpensify]

Looks great! Super excited for this feature. Just 2 quick questions

[stitesExpensify]

LGTM! Excited for this feature

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.4.65-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[Julesssss]

Hey @stitesExpensify @dukenv0307. I think this Android bug is liked to these changes. I don't think it's serious enough to revert, but it would be great to get it fixed asap. Any thoughts?

[stitesExpensify]

@dukenv0307 looks like we had to revert this pr due to deploy blockers it spawned. Can you create a revert revert and fix those problems so we can try again please?

[dukenv0307]

@stitesExpensify mountiny created the revert PR.

[stitesExpensify]

Right, I meant a revert of the revert so that you get all of your code back and we can work from there :)

However you want to handle it is fine though

[dukenv0307]

Got it, will create PR v2 soon.

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅