fix: Use isValidPersonName for teachers name validation #35229

paultsimura · 2024-01-26T09:34:56Z

Details

Make teachers' name inputs less strict: allow all but special chars – the same as in Bank Account flow.

Fixed Issues

$ #35144
PROPOSAL: #35144 (comment)

Tests

Same as QA

Offline tests

Same as QA

QA Steps

Tap on FAB - Save the world - I am a teacher (or I know a teacher).
Type in "Ádám" in the First Name and Last Name fields

Verify there is no validation error

Add a special char (e.g. !)

Verify a "Please enter a valid first (last) name" message is shown

Clear the field

Verify a "Please enter a valid first (last) name" message is shown

PR Author Checklist

Screenshots/Videos

Android: Native

android-compressed.mp4

Android: mWeb Chrome

chrome-compressed.mp4

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-01-26.at.10.44.55-compressed.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-01-26.at.10.45.51-compressed.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-01-26.at.10.35.19-compressed.mp4

MacOS: Desktop

Screen.Recording.2024-01-26.at.10.43.13-compressed.mp4

melvin-bot · 2024-01-26T09:52:48Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2024-01-26T13:20:03Z

Hey @paultsimura, regex for isValidPersonName seems to allowing some chars. for ex: "@", "?", i think we should be change implementation to use CONST.REGEX.ALPHABETIC_AND_LATIN_CHARS Wdyt?

paultsimura · 2024-01-26T13:38:06Z

CONST.REGEX.ALPHABETIC_AND_LATIN_CHARS allows only Latin chars. I'm not sure this is the way to go because it'll not allow, for example, Cyrillic names:

Can't we add the "@" and "?" symbols to the regexp used in the Bank Account validation?

paultsimura · 2024-01-26T13:58:49Z

Asked in Slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1706277319778609

ishpaul777 · 2024-01-26T13:58:56Z

Thanks! Lets wait for a consensus in Slack.

ishpaul777 · 2024-01-26T15:27:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Record_2024-01-26-20-42-07.mp4

Android: mWeb Chrome

Record_2024-01-26-20-34-42.mp4

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Plus.-.2024-01-26.at.20.00.36.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Plus.-.2024-01-26.at.20.04.08.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-01-26.at.6.34.42.PM.mov

MacOS: Desktop

Screen.Recording.2024-01-26.at.8.53.40.PM-1.mov

ishpaul777

LGTM

EDIT: We still need approval for copy update https://expensify.slack.com/archives/C01GTK53T8Q/p1706260058994859

OSBotify · 2024-01-26T18:33:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-29T19:26:48Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.4.33-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2024-01-31T02:33:39Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.33-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

allgandalf · 2024-08-27T06:08:23Z

src/pages/TeachersUnite/KnowATeacherPage.tsx

-            if (!ValidationUtils.isValidLegalName(values.firstName)) {
-                ErrorUtils.addErrorMessage(errors, 'firstName', 'privatePersonalDetails.error.hasInvalidCharacter');
-            } else if (!values.firstName) {
+            if (!values.firstName || !ValidationUtils.isValidPersonName(values.firstName)) {


Not sure if it was by design at the time of that PR, but we should had used isValidDisplayName here instead, this caused #46385

Use isValidPersonName for teachers name validation

e66f629

paultsimura marked this pull request as ready for review January 26, 2024 09:52

paultsimura requested a review from a team as a code owner January 26, 2024 09:52

melvin-bot bot requested review from ishpaul777 and removed request for a team January 26, 2024 09:52

paultsimura mentioned this pull request Jan 26, 2024

[HOLD for payment 2024-02-07] [$125] Teachers Unite - The character input is limited #35144

Closed

6 tasks

ishpaul777 approved these changes Jan 26, 2024

View reviewed changes

melvin-bot bot requested a review from AndrewGable January 26, 2024 15:35

AndrewGable approved these changes Jan 26, 2024

View reviewed changes

AndrewGable merged commit 62f4383 into Expensify:main Jan 26, 2024
16 of 20 checks passed

github-actions bot mentioned this pull request Jan 29, 2024

Deploy Checklist: New Expensify 2024-01-29 #35328

Closed

allgandalf reviewed Aug 27, 2024

View reviewed changes

allgandalf mentioned this pull request Aug 27, 2024

[$250] mWeb - Profile-Entering number & comma and saving first&last name shows inconsistent behavior #46385

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Use isValidPersonName for teachers name validation #35229

fix: Use isValidPersonName for teachers name validation #35229

paultsimura commented Jan 26, 2024 •

edited

Loading

melvin-bot bot commented Jan 26, 2024

ishpaul777 commented Jan 26, 2024

paultsimura commented Jan 26, 2024

paultsimura commented Jan 26, 2024

ishpaul777 commented Jan 26, 2024 •

edited

Loading

ishpaul777 commented Jan 26, 2024 •

edited

Loading

ishpaul777 left a comment •

edited

Loading

OSBotify commented Jan 26, 2024

OSBotify commented Jan 29, 2024

OSBotify commented Jan 31, 2024

allgandalf Aug 27, 2024 •

edited

Loading

fix: Use isValidPersonName for teachers name validation #35229

fix: Use isValidPersonName for teachers name validation #35229

Conversation

paultsimura commented Jan 26, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 26, 2024

ishpaul777 commented Jan 26, 2024

paultsimura commented Jan 26, 2024

paultsimura commented Jan 26, 2024

ishpaul777 commented Jan 26, 2024 • edited Loading

ishpaul777 commented Jan 26, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

ishpaul777 left a comment • edited Loading

Choose a reason for hiding this comment

OSBotify commented Jan 26, 2024

OSBotify commented Jan 29, 2024

OSBotify commented Jan 31, 2024

allgandalf Aug 27, 2024 • edited Loading

Choose a reason for hiding this comment

paultsimura commented Jan 26, 2024 •

edited

Loading

ishpaul777 commented Jan 26, 2024 •

edited

Loading

ishpaul777 commented Jan 26, 2024 •

edited

Loading

ishpaul777 left a comment •

edited

Loading

allgandalf Aug 27, 2024 •

edited

Loading