show recents in participants page based on action type #35431

rojiphil · 2024-01-30T19:21:15Z

Details

Currently, the recent list on the participants’ page displays the participant details of the most recently changed reports at the top. This PR, now, shows the participant details of the most recently changed reports at the top only when they were involved in the action for which these reports are shown. For example, when user A generates a scan receipt money request in a 1:1 DM for User B, the recent list shows participant B in the recent list since the 1:1 DM chat report has a recent history of a scan money receipt.

How do we do this?

For Money Request action types:
We have three types of money requests i.e. manual, scan, and distance which are the three types of action for money requests. These actions are initiated by the user via the tab selection. Further, for manual and scan money requests, the user can additionally trigger a fourth action i.e. split action by clicking on the split button on the participants’ page.
For identifying the reports based on these four types the action, we rely on the transactions available locally in Onyx as follows:
Split: When the comment source is set to split within a transaction.
Scan: When there is a valid receipt within a transaction
Distance: When the transaction contains a customUnit type and custom unit name as Distance
Manual: None of the above
For transactions of a given action type, we identify their respective chat reports i.e. 1:1 DM Chat Repot or Workspace Chat Report via the money request report. The most recent of these chat reports will be displayed.
For Task action type:
During task creation, we display the participants’ page during the assignment of the task. This is what makes the task action type.
Here, we identify the parent chat report of all tasks available within Onyx. The most recent of these chat reports are displayed in the recent list.

Note

Since we depend on transactions and task reports to find the most recent chat reports, it is possible that we do not find the most recent chat report just because the dependant transactions and task reports are not available locally in Onyx even though the chat report is locally available. This scenario occurs when the remote user generates a transaction/task that is not yet accessed locally by the local user or during a fresh sign-in. Further, it may be possible that the transaction/task report and the parent chat report are locally present but the intermediate reports are not present locally. Such chat reports will be missing from the recent list as they could not be traced back from the transaction/task report.
Conclusion: Currently, we will use when its available as there is some BE planning that is pending as mentioned here
After creation of a new task/money request, if we quickly come back to check if the participants page has been updated, we may not see the change immediately. However, this is only observed for a short period. It looks like the API response/pusher updates will later populate the reports with the newly created report and the assignee participants page will show the updated participants. So, if this behavior is observed, please give few moments and come back again to verify. The comment here also shares a video that demonstrates this behavior.

Fixed Issues

$ #34227
PROPOSAL: #34227 (comment)

Tests

Precondition: For Money Requests, ensure that all previous money requests are paid.

Test 1: Task Creation

User A shares task with User B in 1:1 Chat Report.
Click Global FAB -> Assign Task
Enter task title and click Next
Click on Assignee to open participants page
Verify that recent list shows User B as the first one

Test 2: Manual Money Request

User A generates a Manual money request for User B in 1:1 Chat Report
Click Global FAB -> Request Money -> Manual tab
Enter amount
Click Next to launch Participants’ page
Verify that recent list shows User B as the first one

Test 3: Split Money Request

User A generates a Split money request with User B in 1:1 Chat Report
Click Global FAB -> Request Money -> Manual tab
Enter amount
Click Next to launch Participants’ page
Click Split on one of the participant (Note: Do not select User B).
Verify that recent list shows User B as the first one

Test 4: Scan Receipt Money Request

User A generates a Scan receipt money request for User D in 1:1 Chat Report
Click Global FAB -> Request Money -> Scan tab
Choose a receipt file to launch the Participants’ page
Verify that recent list shows User D as the first one

Test 5: Distance Money Request

User A generates a Distance money request in Workspace X
Click Global FAB -> Request Money -> Distance tab
Select a start and finish waypoints
Click Next to launch the Participants’ page
Verify that recent list shows Workspace X as the first one

Test 6: Add Comment to a Chat Report that has a previous manual money request

User A adds a new comment for User B in 1:1 Chat Report (Note: User B already has a previous manual money request)
Click Global FAB -> Request Money -> Manual tab
Enter amount
Click Next to launch Participants’ page
Verify that recent list shows User B as the first one

Test 7: Test for default recent list
Precondition: Have split requests with few participants in User A’s account

SignIn as User A.
Click Global FAB -> Request Money -> Manual tab
Enter amount and click Next to launch Participants’ page
Click Split on all the participants.
Verify that recent list shows the default list as shown before the implementation of this feature.

Note: All the above 7 tests can be performed by initiating a money request/task creation from remote user. However, the only thing to take care of is that the local user should open the respective transaction/task.

Verify that no errors appear in the JS console

Offline tests

Same as the Steps in Tests Section.

QA Steps

Same as the Steps in Tests Section.

Notes

Please refer the notes section in PR description for exceptions.
While testing money request steps, if there is an existing Report Preview due to open money requests, the Report Preview timestamp does not update. Because of this, adding a new money request when there are previous open money requests will not bring this report in the top of the recent list. So, for testing this PR, please ensure that there are no previous open money requests. This means that all the previous money requests must be paid.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web - Safari

Test 1: Task Creation

34227-web-safari-task.mp4

Test 2: Manual Money Request

34227-web-safari-manual.mp4

Test 3: Split Money Request

34227-web-safari-split.mp4

Test 4: Scan Receipt Money Request

34227-web-safari-scan.mp4

Test 5: Distance Money Request

34227-web-safari-distance.mp4

Test 6: Add Comment to a Chat Report that has a previous manual money request

34227-web-safari-comment.mp4

Test 7: Test for default recent list

34227-web-safari-default.mp4

Mobile Web - Safari

Test 1: Task Creation

34227-mweb-safari-T01.mp4

Test 2: Manual Money Request

34227-mweb-safari-T02.mp4

Test 3: Split Money Request

34227-mweb-safari-T03.mp4

Test 4: Scan Receipt Money Request

34227-mweb-safari-T04.mp4

Test 5: Distance Money Request

34227-mweb-safari-T05.mp4

Test 6: Add Comment to a Chat Report that has a previous manual money request

34227-mweb-safari-T06.mp4

Test 7: Test for default recent list

34227-mweb-safari-T07.mp4

Desktop

Test 1: Task Creation

34227-desktop-T01.mp4

Test 2: Manual Money Request

34227-desktop-T02.mp4

Test 3: Split Money Request

34227-desktop-T03.mp4

Test 4: Scan Receipt Money Request

34227-desktop-T04.mp4

Test 5: Distance Money Request

34227-desktop-T05.mp4

Test 6: Add Comment to a Chat Report that has a previous manual money request

34227-desktop-T06.mp4

Test 7: Test for default recent list

34227-desktop-T07.mp4

iOS

Test 1: Task Creation

34277-ios-native-T01.mp4

Test 2: Manual Money Request

34227-ios-native-T02.mp4

Test 3: Split Money Request

34277-ios-native-T03.mp4

Test 4: Scan Receipt Money Request

34227-ios-native-T04.mp4

Test 5: Distance Money Request

34227-ios-native-T05.mp4

Test 6: Add Comment to a Chat Report that has a previous manual money request

34227-desktop-T06.mp4

Test 7: Test for default recent list

34227-ios-native-T07.mp4

Android

Test 1: Task Creation

34227-android-native-T01.mp4

Test 2: Manual Money Request

34227-android-native-T02.mp4

Test 3: Split Money Request

34227-android-native-T03.mp4

Test 4: Scan Receipt Money Request

34227-android-native-T04.mp4

Test 5: Distance Money Request

34227-android-native-T05.mp4

Test 6: Add Comment to a Chat Report that has a previous manual money request

34227-android-native-T06.mp4

Test 7: Test for default recent list

34227-android-native-T07.mp4

Mobile Web - Chrome

Test 1: Task Creation

34227-mweb-chrome-T01.mp4

Test 2: Manual Money Request

34227-mweb-chrome-T02.mp4

Test 3: Split Money Request

34227-mweb-chrome-T03.mp4

Test 4: Scan Receipt Money Request

34227-mweb-chrome-T04.mp4

Test 5: Distance Money Request

34227-mweb-chrome-T05.mp4

Test 6: Add Comment to a Chat Report that has a previous manual money request

34227-mweb-chrome-T06.mp4

Test 7: Test for default recent list

34227-mweb-chrome-T07.mp4

…ature-show-recents-based-on-action-type

mountiny · 2024-01-31T14:45:17Z

thanks! thats your eta to get this ready for a review?

…n-action-type

…ature-show-recents-based-on-action-type

rojiphil · 2024-02-01T17:38:16Z

@eVoloshchak @mountiny

The PR is ready for review.

I have documented the implementation details in Details section of the checklist.
Also, I have tested with web safari environment and works well too.

Post review, I will complete testing for the remaining environments too.

Thanks for your patience.

melvin-bot · 2024-02-01T17:38:30Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

eVoloshchak · 2024-02-01T17:43:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

eVoloshchak · 2024-02-01T19:28:28Z

src/libs/OptionsListUtils.ts

@@ -99,6 +99,7 @@ type GetOptionsConfig = {
    includePolicyTaxRates?: boolean;
    policyTaxRates?: PolicyTaxRateWithDefault;
    transactionViolations?: OnyxCollection<TransactionViolation[]>;
+    actionTypeForParticipants?: string;


type ActionType = ValueOf<typeof CONST.REPORT.TYPE | typeof CONST.IOU.TYPE | typeof CONST.IOU.REQUEST_TYPE>;

Suggested change

actionTypeForParticipants?: string;

actionTypeForParticipants?: ActionType;

src/libs/OptionsListUtils.ts

eVoloshchak · 2024-02-01T19:38:23Z

src/libs/TransactionUtils.ts

+        Object.values(allTransactions ?? {})
+            .filter(
+                (transaction): transaction is Transaction =>
+                    transaction != null && (actionType === CONST.IOU.TYPE.SPLIT ? isSplitRequest(transaction) : getRequestType(transaction) === actionType),


This is a little bit hard to read, I think a helper method (something like getTransactionActionType, essentially a combination of isSplitRequest and getRequestType) would be useful here

eVoloshchak · 2024-02-01T19:52:22Z

Bug:

Click Global FAB -> Request Money -> Manual tab
Enter an amount
Click Next, select a user (userA) from the Participants list
Click Request
Click Global FAB -> Request Money -> Manual tab
Enter an amount, click Next
Verify that recents list shows userAas the first one
Click Global FAB -> Request Money -> Scan tab
Upload a receipt file
Select a different user (userB) from the Participants list
Click Request
Click Global FAB -> Request Money -> Manual tab
Enter an amount, click Next
The first user in recents list is userB, while it should be userA, since this is a manual tab

Screen.Recording.2024-02-01.at.20.45.46.mov

mountiny · 2024-03-31T20:09:46Z

@rojiphil yeah that is what we are looking for, however I agree that to properly capture the impact we might need more complex scenario here.

Can you please resolve the conflicts and retest?

…ature-show-recents-based-on-action-type

mountiny · 2024-04-03T11:25:27Z

@rojiphil more conflicts

…ature-show-recents-based-on-action-type

rojiphil · 2024-04-08T10:18:50Z

Can you please resolve the conflicts and retest?

Resolved the conflicts and retested too. It needed minor fixes but the core logic remains the same. The reassure performance tests also passed well. LGTM.

eVoloshchak · 2024-04-08T17:28:24Z

@rojiphil, Test 1: Task Creation is failing for me

Screen.Recording.2024-04-08.at.19.22.16.mov

rojiphil · 2024-04-08T19:45:50Z

Test 1: Task Creation is failing for me

@eVoloshchak That’s an interesting observation. I was not able to get this problem as I was not that quick in coming back to the task creation to check if the assignee participants page is updated. For some weird reason, here it looks like the reports do not immediately include the newly created task report which is why the assignee participants page is not updated. However, this is only observed for a short period of time. It may be that the API response/pusher updates will later populate the reports with the newly created report and the assignee participants page will show the updated participants. Although I think we should fix this I also think this falls outside the scope of our current work here. Also, as it is momentary in nature it may also qualify as a super-edge case. Anyway, I am making a note of this in the PR description. Does this make sense?

34227-delayed-update.mp4

eVoloshchak · 2024-04-10T11:28:05Z

It may be that the API response/pusher updates will later populate the reports with the newly created report and the assignee participants page will show the updated participants. Although I think we should fix this I also think this falls outside the scope of our current work here. Also, as it is momentary in nature it may also qualify as a super-edge case

Can confirm it does work after some time (or a page refresh).
My main concern is that also means this feature won't work while offline, since we need to wait for the API response
How hard would it be to use pending actions in addition to recent actions to fix this?
On a side note, could you merge main please?

eVoloshchak · 2024-04-15T14:13:15Z

My main concern is that also means this feature won't work while offline, since we need to wait for the API response
How hard would it be to use pending actions in addition to recent actions to fix this?

@rojiphil, gentle bump on this question

rojiphil · 2024-04-16T16:48:08Z

My main concern is that also means this feature won't work while offline, since we need to wait for the API response
How hard would it be to use pending actions in addition to recent actions to fix this?

I am not quite sure how pending actions would help here. Anyway, I will analyze this in more detail and share an update in a day or two.

rojiphil · 2024-04-19T02:17:12Z

It looks like the option list is not getting updated for the intermediate reports and gets updated only for the last updated report when there are multiple reports updated at the same time. In our use case here, we update two reports at the same time i.e. Assignee Report and Parent Report. The attached screenshot for logs how the assignee report does not get considered for option list updation but the parent report does here. We consider only the lastUpdatedReport here. This is the reason for the problem mentioned here. To be able to consistently reproduce the problem, we can test this in offline scenarios. A recent PR here for caching search options introduced these changes.

@eVoloshchak Can you please confirm if you share a similar understanding here?

…ature-show-recents-based-on-action-type

eVoloshchak · 2024-04-24T16:30:10Z

It looks like the option list is not getting updated for the intermediate reports and gets updated only for the last updated report when there are multiple reports updated at the same time. In our use case here, we update two reports at the same time i.e. Assignee Report and Parent Report. The attached screenshot for logs how the assignee report does not get considered for option list updation but the parent report does here. We consider only the lastUpdatedReport here. This is the reason for the problem mentioned #35431 (comment).

@rojiphil, thank you for the thorough explanation!
It is my understanding that we don't need a lastUpdatedReport variable, is that correct?

It looks like the option list is not getting updated for the intermediate reports and gets updated only for the last updated report when there are multiple reports updated at the same time. In our use case here, we update two reports at the same time i.e. Assignee Report and Parent Report.

This is the actual bug we need to fix. Was it introduced by #38207?

rojiphil · 2024-04-27T20:14:38Z

It is my understanding that we don't need a lastUpdatedReport variable, is that correct?

This is the actual bug we need to fix. Was it introduced by #38207?

@eVoloshchak Yes. That's correct. The performance improvement via caching search options caused this. The lastUpdatedReport variable was also introduced as part of this.

…ature-show-recents-based-on-action-type

rojiphil added 4 commits January 31, 2024 00:20

show recents in participants page based on action type

adec852

Merge branch 'main' of https://github.com/Expensify/App into 34227-fe…

40b7aad

…ature-show-recents-based-on-action-type

get transactions by action type

5faec94

regression fixes

69b5ff6

mountiny assigned rojiphil Jan 31, 2024

Fix for showing recent tasks

64e6273

This comment was marked as outdated.

Sign in to view

rojiphil added 4 commits January 31, 2024 20:54

prettier fix

7299643

sort optimization

998f474

use participant account ids for tasks

8aa9601

fix for max num of recents displayed

c62108a

This comment was marked as outdated.

Sign in to view

rojiphil added 8 commits February 1, 2024 09:27

reverting recent list by task action type

d9cd091

fixes for recent list for money request action type

5570493

fixes for recent list of task action type

9149a6a

Minor fix and added comments

21e4eb6

prettier fix and check perf

745ed17

Merge branch 'Expensify:main' into 34227-feature-show-recents-based-o…

609acb2

…n-action-type

fix for recent list of task action type

d9bcc73

Merge branch 'main' of https://github.com/Expensify/App into 34227-fe…

3a8a5b8

…ature-show-recents-based-on-action-type

rojiphil marked this pull request as ready for review February 1, 2024 17:38

rojiphil requested a review from a team as a code owner February 1, 2024 17:38

melvin-bot bot requested review from eVoloshchak and removed request for a team February 1, 2024 17:38

eVoloshchak suggested changes Feb 1, 2024

View reviewed changes

rojiphil added 2 commits April 3, 2024 11:47

Merge branch 'main' of https://github.com/Expensify/App into 34227-fe…

1b63dd8

…ature-show-recents-based-on-action-type

prettier fix

5180407

This comment was marked as outdated.

Sign in to view

rojiphil added 4 commits April 7, 2024 22:58

Merge branch 'main' of https://github.com/Expensify/App into 34227-fe…

0b3def2

…ature-show-recents-based-on-action-type

task selector fix

78374dc

typecheck fix for recentReportOptions

29d68b4

fix for split request and prettier fix

92bec33

rojiphil added 2 commits April 11, 2024 14:54

Merge branch 'main' into 34227-feature-show-recents-based-on-action-type

4fb7f58

Merge branch 'main' into 34227-feature-show-recents-based-on-action-type

4305481

rojiphil added 4 commits April 19, 2024 07:48

Merge branch 'main' into 34227-feature-show-recents-based-on-action-type

faa9ed4

Merge branch 'main' into 34227-feature-show-recents-based-on-action-type

2ae00e8

Merge branch 'main' of https://github.com/Expensify/App into 34227-fe…

e6c1b83

…ature-show-recents-based-on-action-type

Resolving merge conflict

04bffab

eVoloshchak mentioned this pull request Apr 25, 2024

[$750] [MEDIUM] Update Recents in Participants page to reflect the type of action taken #34227

Closed

rojiphil added 3 commits April 29, 2024 08:22

Merge branch 'main' of https://github.com/Expensify/App into 34227-fe…

9005bc0

…ature-show-recents-based-on-action-type

Merge branch 'main' into 34227-feature-show-recents-based-on-action-type

e154b5b

Merge branch 'main' into 34227-feature-show-recents-based-on-action-type

5bcae4a

rojiphil closed this Aug 24, 2024

rojiphil deleted the 34227-feature-show-recents-based-on-action-type branch August 24, 2024 17:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

show recents in participants page based on action type #35431

show recents in participants page based on action type #35431

rojiphil commented Jan 30, 2024 •

edited

Loading

mountiny commented Jan 31, 2024

This comment was marked as outdated.

This comment was marked as outdated.

rojiphil commented Feb 1, 2024

melvin-bot bot commented Feb 1, 2024

eVoloshchak commented Feb 1, 2024 •

edited

Loading

eVoloshchak Feb 1, 2024

eVoloshchak Feb 1, 2024

eVoloshchak commented Feb 1, 2024

mountiny commented Mar 31, 2024

mountiny commented Apr 3, 2024

This comment was marked as outdated.

rojiphil commented Apr 8, 2024

eVoloshchak commented Apr 8, 2024

rojiphil commented Apr 8, 2024 •

edited

Loading

eVoloshchak commented Apr 10, 2024

eVoloshchak commented Apr 15, 2024

rojiphil commented Apr 16, 2024

rojiphil commented Apr 19, 2024

eVoloshchak commented Apr 24, 2024

rojiphil commented Apr 27, 2024 •

edited

Loading

	actionTypeForParticipants?: string;
	actionTypeForParticipants?: ActionType;

show recents in participants page based on action type #35431

show recents in participants page based on action type #35431

Conversation

rojiphil commented Jan 30, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

mountiny commented Jan 31, 2024

This comment was marked as outdated.

This comment was marked as outdated.

rojiphil commented Feb 1, 2024

melvin-bot bot commented Feb 1, 2024

eVoloshchak commented Feb 1, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

eVoloshchak Feb 1, 2024

Choose a reason for hiding this comment

eVoloshchak Feb 1, 2024

Choose a reason for hiding this comment

eVoloshchak commented Feb 1, 2024

mountiny commented Mar 31, 2024

mountiny commented Apr 3, 2024

This comment was marked as outdated.

rojiphil commented Apr 8, 2024

eVoloshchak commented Apr 8, 2024

rojiphil commented Apr 8, 2024 • edited Loading

eVoloshchak commented Apr 10, 2024

eVoloshchak commented Apr 15, 2024

rojiphil commented Apr 16, 2024

rojiphil commented Apr 19, 2024

eVoloshchak commented Apr 24, 2024

rojiphil commented Apr 27, 2024 • edited Loading

rojiphil commented Jan 30, 2024 •

edited

Loading

eVoloshchak commented Feb 1, 2024 •

edited

Loading

rojiphil commented Apr 8, 2024 •

edited

Loading

rojiphil commented Apr 27, 2024 •

edited

Loading