[TS migration] Migrate 'Task' page to TypeScript #35484

pasyukevich · 2024-01-31T15:25:45Z

Details

Fixed Issues

$#25212
PROPOSAL:

Tests

Open any task
Change the assignee and verify that everything works as expected
Change the title and verify that everything works as expected
Change the description and verify that everything works as expected

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open any task
Change the assignee and verify that everything works as expected
Change the title and verify that everything works as expected
Change the description and verify that everything works as expected

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-native-converted.webm

Android: mWeb Chrome

aandroid-web-converted.webm

iOS: Native

ios-mobile-converted.mp4

iOS: mWeb Safari

ios-web-converted.mp4

MacOS: Chrome / Safari

desktop-web-converted.mov

MacOS: Desktop

desktop-native-converted.mov

rezkiy37

Left comments, after LGTM.

src/pages/tasks/TaskAssigneeSelectorModal.tsx

src/types/onyx/IsSearchingForReports.ts

src/libs/OptionsListUtils.ts

src/pages/tasks/TaskAssigneeSelectorModal.tsx

kubabutkiewicz · 2024-02-20T08:54:01Z

src/pages/tasks/TaskAssigneeSelectorModal.tsx

-        const headerMessage = OptionsListUtils.getHeaderMessage(recentReports?.length + personalDetails?.length !== 0 || currentUserOption, Boolean(userToInvite), debouncedSearchValue);
+        const headerMessage = OptionsListUtils.getHeaderMessage(
+            recentReports?.length + personalDetails?.length !== 0 || Boolean(currentUserOption),
+            Boolean(userToInvite),


Suggested change

Boolean(userToInvite),

!!userToInvite,

I think Boolean is better since it is straight forward conversion

The convention is to use !! across files, I agree with @kubabutkiewicz

We don't have such a convention in the contributional guidelines.

I think using Boolean is better as you always understand what is going on and do not need to focus on the quantity of !

src/pages/tasks/TaskDescriptionPage.tsx

src/types/onyx/IsSearchingForReports.ts

blazejkustra · 2024-02-27T17:42:32Z

src/pages/tasks/TaskAssigneeSelectorModal.tsx

-        const headerMessage = OptionsListUtils.getHeaderMessage(recentReports?.length + personalDetails?.length !== 0 || currentUserOption, Boolean(userToInvite), debouncedSearchValue);
+        const headerMessage = OptionsListUtils.getHeaderMessage(
+            recentReports?.length + personalDetails?.length !== 0 || Boolean(currentUserOption),
+            Boolean(userToInvite),


The convention is to use !! across files, I agree with @kubabutkiewicz

blazejkustra · 2024-02-27T17:43:09Z

src/types/onyx/Task.ts

@@ -2,7 +2,7 @@ import type Report from './Report';

 type Task = {
    /** Title of the Task */
-    title: string;
+    title?: string;


Why was this changed?

We can change the description without the title

melvin-bot · 2024-03-06T10:04:53Z

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

marcochavezf · 2024-03-06T17:49:52Z

Assigning @allroundexperts for C+ review

allroundexperts · 2024-03-06T18:12:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-07.at.1.21.01.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-03-07.at.1.19.52.AM.mov

iOS: Native

Screen.Recording.2024-03-07.at.1.19.02.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-03-07.at.1.17.45.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-07.at.1.12.46.AM.mov

MacOS: Desktop

Screen.Recording.2024-03-07.at.1.15.38.AM.mov

OSBotify · 2024-03-07T18:21:54Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-08T00:03:23Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.4.49-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-12T18:37:30Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.50-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

pasyukevich force-pushed the feature/migrate-task-edit branch 4 times, most recently from 9dcae8a to 2683540 Compare February 2, 2024 10:16

[TS migration] Migrate 'Task' page to TypeScript

9a0d540

pasyukevich force-pushed the feature/migrate-task-edit branch from 2683540 to 9a0d540 Compare February 2, 2024 14:34

pasyukevich changed the title ~~[WIP] [TS migration] Migrate 'Task' page to TypeScript~~ [TS migration] Migrate 'Task' page to TypeScript Feb 2, 2024

rezkiy37 reviewed Feb 6, 2024

View reviewed changes

src/pages/tasks/TaskAssigneeSelectorModal.tsx Outdated Show resolved Hide resolved

src/pages/tasks/TaskAssigneeSelectorModal.tsx Outdated Show resolved Hide resolved

pasyukevich commented Feb 6, 2024

View reviewed changes

src/types/onyx/IsSearchingForReports.ts Outdated Show resolved Hide resolved

Merge branch 'main' into feature/migrate-task-edit

cf150a2

pasyukevich force-pushed the feature/migrate-task-edit branch from 77a10c3 to b0b0964 Compare February 13, 2024 09:34

update types

8344608

pasyukevich force-pushed the feature/migrate-task-edit branch from b0b0964 to 8344608 Compare February 13, 2024 09:46

pasyukevich added 2 commits February 15, 2024 13:18

Merge branch 'main' into feature/migrate-task-edit

d57df4f

fix types

6c38232

pasyukevich force-pushed the feature/migrate-task-edit branch from 9326c1b to 6c38232 Compare February 15, 2024 13:51

Merge branch 'main' into feature/migrate-task-edit

be5a749

kubabutkiewicz reviewed Feb 20, 2024

View reviewed changes

pasyukevich added 2 commits February 22, 2024 14:55

Merge branch 'main' into feature/migrate-task-edit

b6ce9f1

address comments

d21a39f

kubabutkiewicz approved these changes Feb 26, 2024

View reviewed changes

Merge branch 'main' into feature/migrate-task-edit

1faa334

blazejkustra approved these changes Feb 27, 2024

View reviewed changes

Merge branch 'main' into feature/migrate-task-edit

82612a8

pasyukevich force-pushed the feature/migrate-task-edit branch 2 times, most recently from b5268ef to eb5cf4b Compare March 6, 2024 09:56

fix types

dd2e3bf

pasyukevich force-pushed the feature/migrate-task-edit branch from eb5cf4b to dd2e3bf Compare March 6, 2024 10:04

pasyukevich marked this pull request as ready for review March 6, 2024 10:04

pasyukevich requested a review from a team as a code owner March 6, 2024 10:04

melvin-bot bot removed the request for review from a team March 6, 2024 10:04

melvin-bot bot requested a review from marcochavezf March 6, 2024 10:04

marcochavezf requested a review from allroundexperts March 6, 2024 17:49

marcochavezf approved these changes Mar 7, 2024

View reviewed changes

marcochavezf merged commit 27b1aa8 into Expensify:main Mar 7, 2024
15 checks passed

github-actions bot mentioned this pull request Mar 7, 2024

Deploy Checklist: New Expensify 2024-03-07 #37938

Closed

43 tasks

kbecciv mentioned this pull request Mar 8, 2024

[HOLD for payment 2024-03-19]Task - Multi-line task descriptions are not truncated in the LHN #37976

Closed

6 tasks

marcaaron mentioned this pull request Mar 8, 2024

[HOLD - #374470] Thread header and LHN for task assignee system message is missing the assignee #37939

Closed

6 tasks

allroundexperts mentioned this pull request Oct 6, 2024

[TS migration] Migrate 'Task' page to TypeScript #25212

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate 'Task' page to TypeScript #35484

[TS migration] Migrate 'Task' page to TypeScript #35484

pasyukevich commented Jan 31, 2024 •

edited

Loading

rezkiy37 left a comment

kubabutkiewicz Feb 20, 2024

pasyukevich Feb 26, 2024

blazejkustra Feb 27, 2024

pasyukevich Mar 6, 2024

blazejkustra Feb 27, 2024

blazejkustra Feb 27, 2024

pasyukevich Feb 29, 2024

melvin-bot bot commented Mar 6, 2024

marcochavezf commented Mar 6, 2024

allroundexperts commented Mar 6, 2024 •

edited

Loading

OSBotify commented Mar 7, 2024

OSBotify commented Mar 8, 2024

OSBotify commented Mar 12, 2024

[TS migration] Migrate 'Task' page to TypeScript #35484

[TS migration] Migrate 'Task' page to TypeScript #35484

Conversation

pasyukevich commented Jan 31, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

rezkiy37 left a comment

Choose a reason for hiding this comment

kubabutkiewicz Feb 20, 2024

Choose a reason for hiding this comment

pasyukevich Feb 26, 2024

Choose a reason for hiding this comment

blazejkustra Feb 27, 2024

Choose a reason for hiding this comment

pasyukevich Mar 6, 2024

Choose a reason for hiding this comment

blazejkustra Feb 27, 2024

Choose a reason for hiding this comment

blazejkustra Feb 27, 2024

Choose a reason for hiding this comment

pasyukevich Feb 29, 2024

Choose a reason for hiding this comment

melvin-bot bot commented Mar 6, 2024

marcochavezf commented Mar 6, 2024

allroundexperts commented Mar 6, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

OSBotify commented Mar 7, 2024

OSBotify commented Mar 8, 2024

OSBotify commented Mar 12, 2024

pasyukevich commented Jan 31, 2024 •

edited

Loading

allroundexperts commented Mar 6, 2024 •

edited

Loading