[Wave 8] [Ideal Nav] Fix iPad navigation #35845

adamgrzybowski · 2024-02-05T18:07:55Z

Details

We used getIsSmallScreenWidth to determine which type of layout is currently displayed in some navigation logic. It was incorrect assumption on the iPad because even if the screen width is beyond the threshold, the iPad always displays narrow layout.

With the new getIsNarrowLayout function everything should work the exactly the same on iPhones and iPads.

P.S. Since the changes apply to the iPad only, I recorded videos exclusively for this platform.

Fixed Issues

$ #35753
$ #35755
$ #35752
$ #35758
$ #35759
$ #35764

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

Test 1

Open app
Make sure you are on the home page
Tap on Profile icon on top right corner of the screen
Tap on back button
You should be on the home page again

Test 2

Open app
Tap on "Expensify" icon on top left corner
Tap on plus button
You should be on the workspace settings page

Open app
Tap on settings tab in bottom
Verify the user is in the Expensify All Settings page (You can see the Overview/ subscriptions etc)

Open app on iPad device
Tap on Expensify icon on top left corner
Tap on any listed workspace
Verify the user is navigated to the settings of the workspace

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iPad.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-02-05T18:08:00Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2024-02-05T18:24:12Z

@mountiny I can review this for #35758.

roryabraham · 2024-02-05T18:30:19Z

src/libs/getIsNarrowLayout/index.native.ts

@@ -0,0 +1,3 @@
+export default function getIsNarrowLayout() {
+    return true;


This is an unsafe assumption – there are devices (such as an iPad pro), where even in portrait layout the screen width is wider than the breakpoint for narrow screens.

I think this practice of using platform as a proxy for other device properties which can be measured directly is bad and a source for technical debt.

I feel strongly that this PR be closed and we fix this by addressing the root cause of the problem(s) on iPad. My hunch is that most of them are stemming from bad assumptions like this one that native code must be running on a device with narrow screen width.

I feel like this is more of a feature request as the assumption of us forcing portrait mode and narrow layout is running for a while and until we decide to officially support landscape too, its fine to keep it in the app.

bad assumptions like this one that native code must be running on a device with narrow screen width.

This is not bad assumption imho, this is a intentional product/ design choice made in the past

even if the screen width is beyond the threshold, the iPad always displays narrow layout

We already applied this throughout the app so I think it's fine for now.
Agree we should completely refactor this bad logic when we support wide layout in portrait mode of super large iPad (maybe when we officially support landscape mode)

roryabraham · 2024-02-05T18:31:38Z

@situchan @mananjadhav please do not review this PR as-is.

roryabraham · 2024-02-05T19:55:45Z

We're discussing this internally here

roryabraham · 2024-02-05T20:34:45Z

Chatted with @mountiny, and I'm willing to let this go through as a temporary measure, but we want to follow-up soon to remove this and address the root cause(s) to get wide layouts to work on native and remove any code that assumes that native devices must be a narrow layout.

I stand by what I said above – that this PR codifies an unsafe assumption. As long as we acknowledge that and work to unwind this assumption, I'll remove my request for changes.

According to @adamgrzybowski here, the main reasons why wide layouts don't currently work on native is due to our uses of position: fixed and overflow: visible.

overflow: visible is the default for all views in React Native, so that seems like it should be solvable. position: fixed is more tricky – I'd suggest that we first look for pure RN solutions that don't require position: fixed, but failing that we could consider sponsoring someone to build support for position: fixed in Yoga.

see my last comment

roryabraham · 2024-02-05T20:36:23Z

I'm going to group these issues into a tracking issue and add it to the wave8 project.

mountiny · 2024-02-06T10:28:11Z

The tracking issue if here #35854 thanks Rory!

mountiny · 2024-02-06T14:12:36Z

@situchan please feel free to resume the review

mountiny · 2024-02-07T21:22:58Z

@situchan whats your ETA on this PR?

situchan · 2024-02-07T21:29:39Z

2 hrs

situchan · 2024-02-08T03:03:29Z

Tested all 6 issues.

Remaining bugs that were not fixed yet:

[HOLD for payment 2024-02-20] [$500] LHN - Workspace announce chat opened when selected workspace on "Choose workspace" page #35759

Screen.Recording.2024-02-08.at.8.57.26.AM.mov

adamgrzybowski · 2024-02-08T11:54:34Z

Thanks for catching this bug @situchan! It should be fixed now.

situchan · 2024-02-08T13:12:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-02-08.at.7.08.10.PM.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

situchan · 2024-02-08T13:15:16Z

Test 1

Open app
Make sure you are on the home page

This test case is not correct yet until #35927 is done. Please fix.

situchan

I tested as many cases as possible in addition to 6 linked issues.
Looks good!

mountiny

Thanks everyone!

OSBotify · 2024-02-08T19:14:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-12T14:21:43Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.40-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	failure ❌

OSBotify · 2024-02-13T18:27:04Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.40-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	failure ❌

add isNarrowLayout

b230459

adamgrzybowski requested a review from a team as a code owner February 5, 2024 18:07

melvin-bot bot requested review from situchan and removed request for a team February 5, 2024 18:07

mountiny assigned adamgrzybowski Feb 5, 2024

mountiny self-requested a review February 5, 2024 18:14

roryabraham previously requested changes Feb 5, 2024

View reviewed changes

roryabraham mentioned this pull request Feb 5, 2024

[HOLD App#49937] [Ideal Nav] [$1000] [Tracking] Update navigation to support wide layouts on native #35854

Open

hayata-suenaga changed the title ~~[ideal-nav] Fix iPad navigation~~ [Wave 8] [Ideal Nav] Fix iPad navigation Feb 6, 2024

add isNarrowLayout to switchPolicyID

de6bc5e

situchan approved these changes Feb 8, 2024

View reviewed changes

mountiny approved these changes Feb 8, 2024

View reviewed changes

mountiny merged commit 8cbbf3d into Expensify:main Feb 8, 2024
16 checks passed

github-actions bot mentioned this pull request Feb 12, 2024

Deploy Checklist: New Expensify 2024-02-12 #36335

Closed

90 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Wave 8] [Ideal Nav] Fix iPad navigation #35845

[Wave 8] [Ideal Nav] Fix iPad navigation #35845

adamgrzybowski commented Feb 5, 2024 •

edited by mountiny

Loading

melvin-bot bot commented Feb 5, 2024

mananjadhav commented Feb 5, 2024

roryabraham Feb 5, 2024

mountiny Feb 5, 2024

mountiny Feb 5, 2024

situchan Feb 5, 2024

roryabraham commented Feb 5, 2024

roryabraham commented Feb 5, 2024

roryabraham commented Feb 5, 2024

roryabraham commented Feb 5, 2024

mountiny commented Feb 6, 2024

mountiny commented Feb 6, 2024

mountiny commented Feb 7, 2024

situchan commented Feb 7, 2024

situchan commented Feb 8, 2024

adamgrzybowski commented Feb 8, 2024

situchan commented Feb 8, 2024

situchan commented Feb 8, 2024

situchan left a comment

mountiny left a comment

OSBotify commented Feb 8, 2024

OSBotify commented Feb 12, 2024

OSBotify commented Feb 13, 2024

		@@ -0,0 +1,3 @@
		export default function getIsNarrowLayout() {
		return true;

[Wave 8] [Ideal Nav] Fix iPad navigation #35845

[Wave 8] [Ideal Nav] Fix iPad navigation #35845

Conversation

adamgrzybowski commented Feb 5, 2024 • edited by mountiny Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 5, 2024

mananjadhav commented Feb 5, 2024

roryabraham Feb 5, 2024

Choose a reason for hiding this comment

mountiny Feb 5, 2024

Choose a reason for hiding this comment

mountiny Feb 5, 2024

Choose a reason for hiding this comment

situchan Feb 5, 2024

Choose a reason for hiding this comment

roryabraham commented Feb 5, 2024

roryabraham commented Feb 5, 2024

roryabraham commented Feb 5, 2024

roryabraham commented Feb 5, 2024

mountiny commented Feb 6, 2024

mountiny commented Feb 6, 2024

mountiny commented Feb 7, 2024

situchan commented Feb 7, 2024

situchan commented Feb 8, 2024

adamgrzybowski commented Feb 8, 2024

situchan commented Feb 8, 2024

Reviewer Checklist

Screenshots/Videos

situchan commented Feb 8, 2024

situchan left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 8, 2024

OSBotify commented Feb 12, 2024

OSBotify commented Feb 13, 2024

adamgrzybowski commented Feb 5, 2024 •

edited by mountiny

Loading