Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] [TS migration] Migrate fs promises mock #35898

Merged
merged 4 commits into from
Feb 13, 2024
Merged

[No QA] [TS migration] Migrate fs promises mock #35898

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a52641b
[TS migration] Deleted promises mock
ruben-rebelo Feb 6, 2024
50016dd
Revert "[TS migration] Deleted promises mock"
ruben-rebelo Feb 8, 2024
de7e02a
[TS migration] Migrate fs-promises mock
ruben-rebelo Feb 8, 2024
77020a4
[TS migration][promises-mock] Addressed feedback
ruben-rebelo Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions __mocks__/fs/promises.js
View file
Open in desktop

This file was deleted.

8 changes: 8 additions & 0 deletions __mocks__/fs/promises.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import {fs} from 'memfs';
import type {FsPromisesApi} from 'memfs/lib/node/types';

type PromisesMock = FsPromisesApi;

const promisesMock: PromisesMock = fs.promises;

module.exports = promisesMock;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
module.exports = promisesMock;
export default promisesMock;

This works?

Loading