[CP Staging] Fix warning on the server #35918

cristipaval · 2024-02-06T16:36:51Z

Details

This fixes a regression added by this PR. The server expects an integer for the createdReportActionID parameter.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/367085
PROPOSAL:

Tests

Verify that sending money in an existing chat works.
Verify that distance requests work from FAB
Verify that IOU requests work from FAB

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-02-06T16:36:56Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cristipaval · 2024-02-06T16:39:55Z

@akinwale , I added @aimane-chnaif as this fixes a regression added by a PR reviewed by him.

aimane-chnaif · 2024-02-06T16:40:13Z

Thanks for catching this. Can we fix all instances in this file?
I just searched for : ''

aimane-chnaif · 2024-02-06T17:11:04Z

Lint failing on main. fixed in #35920

aimane-chnaif · 2024-02-06T17:25:24Z

@cristipaval please pull main. lint fixed now

…ning

cristipaval · 2024-02-06T17:30:50Z

Thanks for catching this. Can we fix all instances in this file? I just searched for : ''

Found 2 more cases. Just pushed the fix for them as well.

cristipaval · 2024-02-06T17:31:05Z

@ready again for review, @aimane-chnaif @VickyStash

aimane-chnaif · 2024-02-06T17:38:23Z

These are to verify:

IOU request from FAB
distance request from FAB
sending money in an existing chat

aimane-chnaif · 2024-02-06T17:39:45Z

perf-tests failing. Not sure it's known or caused by this PR

aimane-chnaif · 2024-02-06T18:20:52Z

src/libs/actions/IOU.ts

@@ -1276,7 +1276,7 @@ function requestMoney(
    // If the report is iou or expense report, we should get the linked chat report to be passed to the getMoneyRequestInformation function
    const isMoneyRequestReport = ReportUtils.isMoneyRequestReport(report);
    const currentChatReport = isMoneyRequestReport ? ReportUtils.getReport(report.chatReportID) : report;
-    const moneyRequestReportID = isMoneyRequestReport ? report.reportID : '';
+    const moneyRequestReportID = isMoneyRequestReport ? report.reportID : '0';


Seems like this change breaks IOU request in offline. Not reproducible before this change

Screen.Recording.2024-02-06.at.7.16.07.PM.mov

ok so we can't do this change. There's if (moneyRequestReportID) { check in getMoneyRequestInformation()

I think we shouldn't touch anything else if we don't have problems raised in the logs. Let's methodically fix each issue when it occurs. If tests passed for the other '' cases, let's not touch them.

aimane-chnaif

Sorry, let's revert last change I suggested.

aimane-chnaif · 2024-02-06T18:27:34Z

src/libs/actions/IOU.ts

@@ -918,7 +918,7 @@ function createDistanceRequest(
    // If the report is an iou or expense report, we should get the linked chat report to be passed to the getMoneyRequestInformation function
    const isMoneyRequestReport = ReportUtils.isMoneyRequestReport(report);
    const currentChatReport = isMoneyRequestReport ? ReportUtils.getReport(report.chatReportID) : report;
-    const moneyRequestReportID = isMoneyRequestReport ? report.reportID : '';
+    const moneyRequestReportID = isMoneyRequestReport ? report.reportID : '0';


src/libs/actions/IOU.ts

cristipaval · 2024-02-06T18:29:57Z

@aimane-chnaif , just reverted the last change. Ready again for review.

aimane-chnaif · 2024-02-06T18:34:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-02-06.at.7.32.36.PM.mov

MacOS: Desktop

melvin-bot · 2024-02-06T18:34:55Z

@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2024-02-06T18:34:58Z

🎯 @aimane-chnaif, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #35940.

aimane-chnaif · 2024-02-06T18:34:59Z

Should we CP this?

aimane-chnaif · 2024-02-06T19:02:11Z

perf-tests still failing but I don't think it's caused by this PR

…ning

cristipaval · 2024-02-06T19:52:07Z

Just merged main to see if this helps perf tests pass

…ning

melvin-bot · 2024-02-06T22:32:18Z

@cristipaval looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

cristipaval · 2024-02-06T22:32:30Z

Perf tests fail on all PRs atm, though they pass locally. It might be something related to the GH actions cache.

[CP Staging] Fix warning on the server (cherry picked from commit 92db113)

OSBotify · 2024-02-07T09:53:13Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.37-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Fix warning on the server

e4d0d92

cristipaval self-assigned this Feb 6, 2024

cristipaval requested a review from a team as a code owner February 6, 2024 16:36

melvin-bot bot requested review from akinwale and removed request for a team February 6, 2024 16:36

cristipaval mentioned this pull request Feb 6, 2024

[TS migration] Migrate 'IOU.js' lib to TypeScript #34092

Merged

50 tasks

cristipaval requested review from aimane-chnaif and removed request for akinwale February 6, 2024 16:39

VickyStash approved these changes Feb 6, 2024

View reviewed changes

cristipaval added 2 commits February 6, 2024 19:25

Merge remote-tracking branch 'origin/main' into cristi_fix-server-war…

391e1fb

…ning

Fix 2 more fallback ids

541d7ef

aimane-chnaif reviewed Feb 6, 2024

View reviewed changes

aimane-chnaif suggested changes Feb 6, 2024

View reviewed changes

Revert last change

19c11c8

aimane-chnaif approved these changes Feb 6, 2024

View reviewed changes

melvin-bot bot requested a review from MonilBhavsar February 6, 2024 18:34

melvin-bot bot mentioned this pull request Feb 6, 2024

[HOLD for payment 2024-02-14] Payment issue for E/App PR#35918 #35940

Closed

Merge remote-tracking branch 'origin/main' into cristi_fix-server-war…

713da31

…ning

Merge remote-tracking branch 'origin/main' into cristi_fix-server-war…

322f073

…ning

cristipaval changed the title ~~Fix warning on the server~~ [CP Staging] Fix warning on the server Feb 6, 2024

robertjchen approved these changes Feb 6, 2024

View reviewed changes

cristipaval merged commit 92db113 into main Feb 6, 2024
15 of 16 checks passed

cristipaval deleted the cristi_fix-server-warning branch February 6, 2024 22:32

melvin-bot bot added the Emergency label Feb 6, 2024

cristipaval removed the Emergency label Feb 6, 2024

OSBotify pushed a commit that referenced this pull request Feb 6, 2024

Merge pull request #35918 from Expensify/cristi_fix-server-warning

65144b5

[CP Staging] Fix warning on the server (cherry picked from commit 92db113)

github-actions bot mentioned this pull request Feb 6, 2024

Deploy Checklist: New Expensify 2024-02-05 #35857

Closed

66 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Fix warning on the server #35918

[CP Staging] Fix warning on the server #35918

cristipaval commented Feb 6, 2024 •

edited

Loading

melvin-bot bot commented Feb 6, 2024

cristipaval commented Feb 6, 2024

aimane-chnaif commented Feb 6, 2024

aimane-chnaif commented Feb 6, 2024

aimane-chnaif commented Feb 6, 2024

cristipaval commented Feb 6, 2024

cristipaval commented Feb 6, 2024

aimane-chnaif commented Feb 6, 2024

aimane-chnaif commented Feb 6, 2024

aimane-chnaif Feb 6, 2024

aimane-chnaif Feb 6, 2024

cristipaval Feb 6, 2024

aimane-chnaif left a comment

aimane-chnaif Feb 6, 2024

cristipaval commented Feb 6, 2024

aimane-chnaif commented Feb 6, 2024

melvin-bot bot commented Feb 6, 2024

melvin-bot bot commented Feb 6, 2024

aimane-chnaif commented Feb 6, 2024

aimane-chnaif commented Feb 6, 2024

cristipaval commented Feb 6, 2024 •

edited

Loading

melvin-bot bot commented Feb 6, 2024

cristipaval commented Feb 6, 2024

OSBotify commented Feb 7, 2024

[CP Staging] Fix warning on the server #35918

[CP Staging] Fix warning on the server #35918

Conversation

cristipaval commented Feb 6, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 6, 2024

cristipaval commented Feb 6, 2024

aimane-chnaif commented Feb 6, 2024

aimane-chnaif commented Feb 6, 2024

aimane-chnaif commented Feb 6, 2024

cristipaval commented Feb 6, 2024

cristipaval commented Feb 6, 2024

aimane-chnaif commented Feb 6, 2024

aimane-chnaif commented Feb 6, 2024

aimane-chnaif Feb 6, 2024

Choose a reason for hiding this comment

aimane-chnaif Feb 6, 2024

Choose a reason for hiding this comment

cristipaval Feb 6, 2024

Choose a reason for hiding this comment

aimane-chnaif left a comment

Choose a reason for hiding this comment

aimane-chnaif Feb 6, 2024

Choose a reason for hiding this comment

cristipaval commented Feb 6, 2024

aimane-chnaif commented Feb 6, 2024

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Feb 6, 2024

melvin-bot bot commented Feb 6, 2024

aimane-chnaif commented Feb 6, 2024

aimane-chnaif commented Feb 6, 2024

cristipaval commented Feb 6, 2024 • edited Loading

melvin-bot bot commented Feb 6, 2024

cristipaval commented Feb 6, 2024

OSBotify commented Feb 7, 2024

cristipaval commented Feb 6, 2024 •

edited

Loading

cristipaval commented Feb 6, 2024 •

edited

Loading