Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve creating expenses on Collect with Instant Submit #36388

Merged
merged 27 commits into from
Mar 7, 2024
Merged

Improve creating expenses on Collect with Instant Submit #36388

merged 27 commits into from
Mar 7, 2024

Commits on Feb 12, 2024

  1. Allow requesting money from processing reports in Collect with Instan… 

    …t Submit enabled
    @youssef-lr
    youssef-lr committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    9bc5b38 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Add new expenses to processing reports

    @youssef-lr
    youssef-lr committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    34917e5 View commit details
    Browse the repository at this point in the history

  2. Set optimisitc report as submitted if instant submit is turned on

    @youssef-lr
    youssef-lr committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    99d1542 View commit details
    Browse the repository at this point in the history

  3. Do not create a new report preview if we have a processing report alr… 

    …eady
    @youssef-lr
    youssef-lr committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    4fc82e7 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2024

  1. Merge branch 'main' into youssef_instant_submit_collect

    @youssef-lr
    youssef-lr committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    f165755 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Merge branch 'main' into youssef_instant_submit_collect

    @youssef-lr
    youssef-lr committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    771eef6 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Add support for splitBill

    @youssef-lr
    youssef-lr committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    4eb5cbf View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Add help method for deciding if we can add transactions to a report

    @youssef-lr
    youssef-lr committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    9587d19 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Fix conflicts and mini refactor on how we decide to create new reports

    @youssef-lr
    youssef-lr committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    a2675fe View commit details
    Browse the repository at this point in the history

  2. Add comment in function definition

    @youssef-lr
    youssef-lr committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    72ddbc8 View commit details
    Browse the repository at this point in the history

  3. Clean up code in MoneyRequestHeader

    @youssef-lr
    youssef-lr committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    f5a5959 View commit details
    Browse the repository at this point in the history

  4. DRY up code in shouldBuildOptimisticMoneyRequestReport

    @youssef-lr
    youssef-lr committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    5be0b3f View commit details
    Browse the repository at this point in the history

  5. Lint

    @youssef-lr
    youssef-lr committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    206cd78 View commit details
    Browse the repository at this point in the history

  6. Fix test

    @youssef-lr
    youssef-lr committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    f0a99eb View commit details
    Browse the repository at this point in the history

  7. Fix test for real now

    @youssef-lr
    youssef-lr committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    933e0d8 View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-authored-by: Alex Beaman <alexbeaman@expensify.com>
    @youssef-lr @Beamanator
    youssef-lr and Beamanator committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    902f45c View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into youssef_instant_submit_collect

    @youssef-lr
    youssef-lr committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    9cccb7e View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Update tests

    @youssef-lr
    youssef-lr committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    267de9d View commit details
    Browse the repository at this point in the history

  2. Fix test

    @youssef-lr
    youssef-lr committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    4e9ccc9 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2024

  1. Rename variables

    @youssef-lr
    youssef-lr committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    c0371b2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into youssef_instant_submit_collect

    @youssef-lr
    youssef-lr committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    9eb9b97 View commit details
    Browse the repository at this point in the history

  3. Fix calls of functions I missed renaming

    @youssef-lr
    youssef-lr committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    8496f5d View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Apply suggestions from code review

    @youssef-lr
    youssef-lr committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    ee17782 View commit details
    Browse the repository at this point in the history

  2. Fix bug, use isMoneyRequestReport

    @youssef-lr
    youssef-lr committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    6a464b3 View commit details
    Browse the repository at this point in the history

  3. Cleanup

    @youssef-lr
    youssef-lr committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    1777c68 View commit details
    Browse the repository at this point in the history

  4. Rename variable

    @youssef-lr
    youssef-lr committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    9d9caf6 View commit details
    Browse the repository at this point in the history

  5. Fix wrong helper method used

    @youssef-lr
    youssef-lr committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    3fcd191 View commit details
    Browse the repository at this point in the history