Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Web/Desktop: Add support for http headers #36560

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Image Web/Desktop: Add support for http headers #36560

merged 3 commits into from
Mar 18, 2024

Commits on Mar 13, 2024

  1. Add react-native-web patch for image header support 

    (cherry picked from commit 19b605e)
(cherry picked from commit 37df3e3)
    @kidroca
    kidroca committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    53337f5 View commit details
    Browse the repository at this point in the history

  2. Refactor Image for Web/Desktop with Source Headers 

    - Introduced `BaseImage` component that branches between native and web implementations.
    - **Native**: Utilizes `expo-image` directly.
    - **Web**: Minor adjustments made to the `onLoad` event signature for compatibility.
- Eliminated `Image/index.native.js` as both native and web components now leverage a unified high-level implementation for image loading and rendering.
- Added `BaseImage` specific props
- Adapt to `expo-image` deprecation of `event.nativeEvent` usage.
- Ensure compatibility with components using the `onLoad` prop.
    @kidroca
    kidroca committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    ba9e75e View commit details
    Browse the repository at this point in the history

  3. Refactor: Exclude Auth Token for External Avatar Images

    @kidroca
    kidroca committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    22a1de0 View commit details
    Browse the repository at this point in the history