fix: Unable to select members after adding them to the workspace #36713

tienifr · 2024-02-16T16:37:12Z

~~Held on Expensify/react-native-onyx#482~~

Details

Fixed Issues

$ #34828
PROPOSAL: #34828 (comment)

Tests

Navigate to Settings > Profile > Contact Method > New Contact Method > Add Email
change the new email as the default contact
Copy the main email and remove it
Go to Settings > Workspace > Members > click on Invite> then paste the main email or search for the email used to create the account
Add the email, click on the checkbox, and verify that it's selected

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Navigate to Settings > Profile > Contact Method > New Contact Method > Add Email
change the new email as the default contact
Copy the main email and remove it
Go to Settings > Workspace > Members > click on Invite> then paste the main email or search for the email used to create the account
Add the email, click on the checkbox, and verify that it's selected

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-16.at.23.56.47.mov

Android: mWeb Chrome

Screen.Recording.2024-02-16.at.23.52.34.mov

iOS: Native

Screen.Recording.2024-02-16.at.23.50.12.mov

iOS: mWeb Safari

Screen.Recording.2024-02-16.at.23.44.02.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-16.at.22.50.49.mov

MacOS: Desktop

Screen.Recording.2024-02-16.at.23.26.08.mov

melvin-bot · 2024-02-16T17:02:19Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

sobitneupane

@tienifr Can we also update policy owner optimistically as suggested here and as mentioned in your alternative proposal.

tienifr · 2024-02-21T04:47:18Z

@sobitneupane updated

sobitneupane

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-22.at.14.01.34.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-02-22.at.14.05.38.mov

iOS: mWeb Safari

Screen.Recording.2024-02-22.at.14.01.34.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-22.at.13.43.51.mov

MacOS: Desktop

Untitled.mov

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

youssef-lr · 2024-02-22T15:05:13Z

src/libs/actions/User.ts

@@ -70,6 +70,14 @@ Onyx.connect({
    },
 });

+let allPolicies: OnyxCollection<Policy>;
+
+Onyx.connect({


I'm not really a fan of subscribing to all policies in this file, can we subscribe to them in ContactMethodDetailsPage instead and use a selector to only get the policies owned by the user? then pass them to setContactMethodAsDefault

I don't think we should get all policies in ContactMethodDetailsPage because it would be re-rendered even with the small change of policies.

@youssef-lr wdyt ^?

Which is why I mentioned using a selector! You can select only the policy IDs owned by the user which is all we care about here and there won't be any re-renders as the ID will never change.

What about creating the function in libs/actions/Policy.ts to return all policyIDs? I think it's the best way @youssef-lr

I'm checking...

@youssef-lr Here's my PR fix on Onyx repo: Expensify/react-native-onyx#482

Why this change? With collection, the returned type of selector shouldn't be the type we defined in ContactMethodDetailsPageOnyxProps a.k.a TOnyxProps[TOnyxProp] since the returned type of selector is just a single entry and TOnyxProps[TOnyxProp] is the collection.

As its name selector, this returned type should be Partial<KeyValueMapping[TOnyxKey]>.

What do you think? cc @sobitneupane

Replied in the PR.

@tienifr @youssef-lr Please have a look at this comment.

youssef-lr · 2024-02-22T15:08:55Z

Also we have conflicts.

fabioh8010 · 2024-03-01T06:50:52Z

@tienifr @youssef-lr I think it's better to put this PR on HOLD until the fix on Onyx is merged and available in a new release to be used in the App, wdyt?

youssef-lr · 2024-03-01T11:20:17Z

Done @fabioh8010

tienifr · 2024-03-04T03:30:32Z

@youssef-lr The Onyx PR is merged, we're good to go

youssef-lr

Thanks for your work here @tienifr! We just need to merge main to fix a failing check

tienifr · 2024-03-04T11:58:25Z

@youssef-lr I think the PR fix on react-native-onyx here would be out of the original scope. Can I get the bonus for that fix? The same situation is in here

OSBotify · 2024-03-04T11:59:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-04T21:03:14Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.47-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

marcochavezf · 2024-03-05T23:02:22Z

This PR caused this regression. Reverting it

youssef-lr · 2024-03-05T23:03:42Z

@tienifr seems like some changes included in the onyx version we bumped caused the regression.

youssef-lr · 2024-03-05T23:04:42Z

I think it's worth finding out later which PR in Onyx has caused it.

tienifr · 2024-03-06T02:59:47Z

@youssef-lr I think this PR: #37804 fixed the issue. After checking the PR I believe the bug doesn't come from my onyx PR

paultsimura · 2024-03-06T10:44:39Z

After checking the PR I believe the bug doesn't come from my onyx PR

Right, the regression came from Expensify/react-native-onyx#480. Also, the hotfix shouldn't have reverted the changes @tienifr made in Onyx, but it's worth double-checking.

OSBotify · 2024-03-06T21:52:16Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.47-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rayane-djouah · 2024-07-25T12:21:58Z

src/libs/actions/User.ts

+            onyxMethod: Onyx.METHOD.MERGE,
+            key: `${ONYXKEYS.COLLECTION.POLICY}${policy.id}`,
+            value: {
+                owner: newDefaultContactMethod,


FYI, this PR didn't address the need to optimistically update the policy employeeList by removing the previous contact method and adding the new one. More details can be found here: #44705 (comment)

fix: Unable to select members after adding them to the workspace

707faaa

tienifr marked this pull request as ready for review February 16, 2024 17:02

tienifr requested a review from a team as a code owner February 16, 2024 17:02

melvin-bot bot removed the request for review from a team February 16, 2024 17:02

melvin-bot bot requested a review from sobitneupane February 16, 2024 17:02

sobitneupane reviewed Feb 20, 2024

View reviewed changes

tienifr added 2 commits February 21, 2024 11:17

Merge branch 'main' into fix/34828

3877a67

fix: update owner optimistically

6c4a680

sobitneupane reviewed Feb 22, 2024

View reviewed changes

sobitneupane approved these changes Feb 22, 2024

View reviewed changes

melvin-bot bot requested a review from youssef-lr February 22, 2024 08:31

youssef-lr reviewed Feb 22, 2024

View reviewed changes

tienifr added 4 commits February 23, 2024 17:02

fix conflicts

3f74e86

Merge branch 'main' into fix/34828

58f5090

Merge branch 'main' into fix/34828

343c32e

subcribe policy in component

1646e58

youssef-lr changed the title ~~fix: Unable to select members after adding them to the workspace~~ |HOLD react-native-onyx/#482] fix: Unable to select members after adding them to the workspace Mar 1, 2024

tienifr added 2 commits March 4, 2024 10:02

Merge branch 'main' into fix/34828

982c20e

bump rn-onyx version 2.0.10

27e2b64

youssef-lr changed the title ~~|HOLD react-native-onyx/#482] fix: Unable to select members after adding them to the workspace~~ fix: Unable to select members after adding them to the workspace Mar 4, 2024

youssef-lr approved these changes Mar 4, 2024

View reviewed changes

Merge branch 'main' into fix/34828

3c56150

youssef-lr merged commit af0f6a3 into Expensify:main Mar 4, 2024
16 checks passed

This was referenced Mar 4, 2024

[HOLD for payment 2024-03-13] Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #37675

Closed

Deploy Checklist: New Expensify 2024-03-04 #37698

Closed

paultsimura mentioned this pull request Mar 5, 2024

[HOLD for payment 2024-03-14] [HOLD for payment 2024-03-13] [$500] IOU - On scan split with 2 users, individual IOU details page shows hhm not here #37758

Closed

6 tasks

marcochavezf mentioned this pull request Mar 5, 2024

Revert "fix: Unable to select members after adding them to the workspace" #37802

Closed

marcochavezf mentioned this pull request Mar 5, 2024

[HOLD for payment 2024-03-14] [HOLD for payment 2024-03-13] Chat - Starting a chat with a specific number directs to the "Hmm" page #37746

Closed

6 tasks

melvin-bot bot mentioned this pull request Mar 6, 2024

[C+ Checklist Needs Completion] [$500] Workspace - Unable to select members after adding them to the workspace #34828

Closed

6 tasks

rayane-djouah reviewed Jul 25, 2024

View reviewed changes

rayane-djouah mentioned this pull request Jul 25, 2024

[HOLD for payment 2024-07-24] [$250] Workspace member - Hidden admin appears in the members list after changing contact method #44705

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Unable to select members after adding them to the workspace #36713

fix: Unable to select members after adding them to the workspace #36713

tienifr commented Feb 16, 2024 •

edited by youssef-lr

Loading

melvin-bot bot commented Feb 16, 2024

sobitneupane left a comment

tienifr commented Feb 21, 2024

sobitneupane left a comment

sobitneupane left a comment

youssef-lr Feb 22, 2024

tienifr Feb 23, 2024 •

edited

Loading

tienifr Feb 23, 2024

youssef-lr Feb 23, 2024

tienifr Feb 24, 2024

tienifr Feb 27, 2024

youssef-lr Feb 28, 2024

tienifr Feb 28, 2024

youssef-lr Feb 28, 2024

fabioh8010 Feb 29, 2024

youssef-lr commented Feb 22, 2024

fabioh8010 commented Mar 1, 2024

youssef-lr commented Mar 1, 2024

tienifr commented Mar 4, 2024

youssef-lr left a comment

tienifr commented Mar 4, 2024

OSBotify commented Mar 4, 2024

OSBotify commented Mar 4, 2024

marcochavezf commented Mar 5, 2024

youssef-lr commented Mar 5, 2024

youssef-lr commented Mar 5, 2024

tienifr commented Mar 6, 2024

paultsimura commented Mar 6, 2024

OSBotify commented Mar 6, 2024

rayane-djouah Jul 25, 2024

fix: Unable to select members after adding them to the workspace #36713

fix: Unable to select members after adding them to the workspace #36713

Conversation

tienifr commented Feb 16, 2024 • edited by youssef-lr Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 16, 2024

sobitneupane left a comment

Choose a reason for hiding this comment

tienifr commented Feb 21, 2024

sobitneupane left a comment

Choose a reason for hiding this comment

Screenshots/Videos

sobitneupane left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Choose a reason for hiding this comment

tienifr Feb 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

youssef-lr commented Feb 22, 2024

fabioh8010 commented Mar 1, 2024

youssef-lr commented Mar 1, 2024

tienifr commented Mar 4, 2024

youssef-lr left a comment

Choose a reason for hiding this comment

tienifr commented Mar 4, 2024

OSBotify commented Mar 4, 2024

OSBotify commented Mar 4, 2024

marcochavezf commented Mar 5, 2024

youssef-lr commented Mar 5, 2024

youssef-lr commented Mar 5, 2024

tienifr commented Mar 6, 2024

paultsimura commented Mar 6, 2024

OSBotify commented Mar 6, 2024

Choose a reason for hiding this comment

tienifr commented Feb 16, 2024 •

edited by youssef-lr

Loading

tienifr Feb 23, 2024 •

edited

Loading