Clean up multiple subscriptions of preferredLocale #3716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
marcaaron
reviewed
Jun 22, 2021
There was a problem hiding this comment.
LGTM, but curious to get your thoughts on an alternative that I started implementing in another PR.
Instead of having a getPreferredLocale() was planning to export something like translateWithPreferredLocale() or translateLocal() and then use it in place of translate().
https://github.com/Expensify/Expensify.cash/blob/ba7e6586eafb28c12e1a8ec18034ae06579a9192/src/libs/translate.js (from a PR not yet merged)
That sounds like a better alternative, I can close this then 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR removes subscriptions to
ONYXKEYS.PREFERRED_LOCALEthat are outside of withLocalize in favor of onetranslatefunction.Fixed Issues
Follow-up to a discussion from #3463 (comment)
Tests
TBD
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android