-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add New payments page #3727
Merged
Merged
Add New payments page #3727
Changes from all commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
b5a4d74
Move PayPalMe to its own page, and update translations
stitesExpensify bebb9ed
Rename createMenu to popoverMenu
stitesExpensify c913cdc
Fix imports
stitesExpensify 27ee1a0
Merge branch 'main' of github.com:Expensify/Expensify.cash into stite…
stitesExpensify 5666d7a
Update category for page move
stitesExpensify a8c7ce2
Update paymentsPage to display payment methods
stitesExpensify 0d38afa
Create paymentsMethodList component
stitesExpensify b20f1ed
Add onPress for payment methods
stitesExpensify 34639bc
Add method for adding payment methods button
stitesExpensify c5f7418
Move getting the paypal.me nvp to getPaymentMethods
stitesExpensify 06e2d0d
Move all payment method list creation into PaymentMethodList
stitesExpensify fbac189
Update payment methods to use description
stitesExpensify 6dc0dab
Merge branch 'main' of github.com:Expensify/Expensify.cash into stite…
stitesExpensify 3141bb2
style
stitesExpensify bef7c3f
style
stitesExpensify 427dd5d
Add popover to get to paypal page
stitesExpensify 78d3449
Add appropriate icons
stitesExpensify 1bcdca0
Remove unused state vars
stitesExpensify 92ad5b9
Style
stitesExpensify 9dce8a5
Style
stitesExpensify 24d2c4e
Split paymentspage into native files because of popover positioning
stitesExpensify cb7f241
Merge branch 'main' of github.com:Expensify/Expensify.cash into stite…
stitesExpensify fb43ddc
Merge branch 'main' of github.com:Expensify/Expensify.cash into stite…
stitesExpensify e79f03e
Revert podfile changes
stitesExpensify 27e482d
Revert podfile lock changes
stitesExpensify 4bf5e08
Remove accidental update
stitesExpensify da1dc60
Remove accidental update
stitesExpensify 39a3c44
Remove useless button
stitesExpensify 167a28c
Move getting the element location to a module
stitesExpensify 8d7d303
Style
stitesExpensify 5ba671f
Move PaymentsPage back into a single file
stitesExpensify d83dc8f
Remove unnecessary eslint comments and unnecessary prop
stitesExpensify 9ce87fc
Move paymentList logic to its own function
stitesExpensify a491c92
Fix prop comments
stitesExpensify feb78ab
Adding more comments
stitesExpensify ff8383a
Add paypal.me to es
stitesExpensify fecf78e
Kebab case
stitesExpensify ab57107
Remove remenant createMenu references
stitesExpensify 39e7a8d
Pretty up lodash
stitesExpensify 135b797
Style
stitesExpensify a3b07fd
Add better keys
stitesExpensify d9a9886
Update state var name to be more consistent
stitesExpensify bb2a83f
Move __cash__ to a const
stitesExpensify 8371ae2
Merge branch 'main' of github.com:Expensify/Expensify.cash into stite…
stitesExpensify 7546948
Add translations
stitesExpensify 5b6c033
Remove line too long errors
stitesExpensify 66341fd
Add wallet constant and use wallet icon for wallet
stitesExpensify 5b869c3
Fix proptype
stitesExpensify 015e61e
Move paypal constant
stitesExpensify 2711bf1
Remove useless inverted prop
stitesExpensify 2aa3cf0
Remove padding that we don't want
stitesExpensify 1b095ea
Merge branch 'main' of github.com:Expensify/Expensify.cash into stite…
stitesExpensify 13874c2
Move position by 20
stitesExpensify 6d1f555
Merge branch 'main' of github.com:Expensify/Expensify.cash into stite…
stitesExpensify 0e0f7b6
Fix capitalization
stitesExpensify 046338c
Comment style
stitesExpensify ca87f1c
Change name to be more generic and accurate
stitesExpensify b2225da
Cleanup render
stitesExpensify a6693be
Style cleanup
stitesExpensify edf3bb6
Remove unnecessary translation
stitesExpensify File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
/** | ||
* We don't need to get the position of the element on native platforms because the popover will be bottom mounted | ||
* | ||
* @param {Object} nativeEvent | ||
* @returns {Object} | ||
*/ | ||
function getClickedElementLocation(nativeEvent) { | ||
return nativeEvent.currentTarget.getBoundingClientRect(); | ||
} | ||
|
||
export default getClickedElementLocation; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
/** | ||
* We don't need to get the position of the element on native platforms because the popover will be bottom mounted | ||
* | ||
* @returns {Object} | ||
*/ | ||
function getClickedElementLocation() { | ||
return { | ||
bottom: 0, | ||
left: 0, | ||
}; | ||
} | ||
|
||
export default getClickedElementLocation; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI – we've ended up shortening this to just "Ending in" to save some space in #47104