Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOQA] Fix Reassure tests for SearchPage #37280

Merged
merged 1 commit into from
Mar 4, 2024
Merged

[NOQA] Fix Reassure tests for SearchPage #37280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/SelectionList/BaseSelectionList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,7 @@ function BaseSelectionList<TItem extends ListItem>(
onSubmitEditing={selectFocusedOption}
blurOnSubmit={!!flattenedSections.allOptions.length}
isLoading={isLoadingNewOptions}
testID="selection-list-text-input"
/>
</View>
)}
Expand Down
11 changes: 10 additions & 1 deletion src/pages/SearchPage/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,20 @@ const propTypes = {

/** Whether or not we are searching for reports on the server */
isSearchingForReports: PropTypes.bool,

/**
* The navigation prop passed by the navigator.
*
* This is required because transitionEnd event doesn't trigger in the automated testing environment.
*/
navigation: PropTypes.shape({}),
};

const defaultProps = {
betas: [],
reports: {},
isSearchingForReports: false,
navigation: {},
};

const setPerformanceTimersEnd = () => {
Expand All @@ -48,7 +56,7 @@ const setPerformanceTimersEnd = () => {

const SearchPageFooterInstance = <SearchPageFooter />;

function SearchPage({betas, reports, isSearchingForReports}) {
function SearchPage({betas, reports, isSearchingForReports, navigation}) {
const [isScreenTransitionEnd, setIsScreenTransitionEnd] = useState(false);
const {translate} = useLocalize();
const {isOffline} = useNetwork();
Expand Down Expand Up @@ -145,6 +153,7 @@ function SearchPage({betas, reports, isSearchingForReports}) {
testID={SearchPage.displayName}
onEntryTransitionEnd={handleScreenTransitionEnd}
shouldEnableMaxHeight
navigation={navigation}
>
{({didScreenTransitionEnd, safeAreaPaddingBottomStyle}) => (
<>
Expand Down
57 changes: 37 additions & 20 deletions tests/perf-test/SearchPage.perf-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import {act, fireEvent, screen} from '@testing-library/react-native';
import {fireEvent, screen, waitFor} from '@testing-library/react-native';
import React from 'react';
import Onyx from 'react-native-onyx';
import {measurePerformance} from 'reassure';
import _ from 'underscore';
import {LocaleContextProvider} from '@components/LocaleContextProvider';
import SearchPage from '@pages/SearchPage';
import ComposeProviders from '../../src/components/ComposeProviders';
import OnyxProvider from '../../src/components/OnyxProvider';
Expand All @@ -16,6 +17,22 @@ import * as TestHelper from '../utils/TestHelper';
import waitForBatchedUpdates from '../utils/waitForBatchedUpdates';
import wrapOnyxWithWaitForBatchedUpdates from '../utils/wrapOnyxWithWaitForBatchedUpdates';

jest.mock('lodash/debounce', () =>
jest.fn((fn) => {
// eslint-disable-next-line no-param-reassign
fn.cancel = jest.fn();
return fn;
}),
);

jest.mock('../../src/libs/Log');

jest.mock('../../src/libs/API', () => ({
write: jest.fn(),
makeRequestWithSideEffects: jest.fn(),
read: jest.fn(),
}));

jest.mock('../../src/libs/Navigation/Navigation');

const mockedNavigate = jest.fn();
Expand Down Expand Up @@ -93,7 +110,7 @@ afterEach(() => {

function SearchPageWrapper(args) {
return (
<ComposeProviders components={[OnyxProvider]}>
<ComposeProviders components={[OnyxProvider, LocaleContextProvider]}>
<SearchPage
// eslint-disable-next-line react/jsx-props-no-spreading
{...args}
Expand All @@ -103,13 +120,13 @@ function SearchPageWrapper(args) {
);
}

test.skip('[Search Page] should interact when text input changes', async () => {
test('[Search Page] should interact when text input changes', async () => {
const {addListener} = TestHelper.createAddListenerMock();

const scenario = async () => {
await screen.findByTestId('SearchPage');

const input = screen.getByTestId('options-selector-input');
const input = screen.getByTestId('selection-list-text-input');
fireEvent.changeText(input, 'Email Four');
fireEvent.changeText(input, 'Report');
fireEvent.changeText(input, 'Email Five');
Expand All @@ -121,7 +138,6 @@ test.skip('[Search Page] should interact when text input changes', async () => {
.then(() =>
Onyx.multiSet({
...mockedReports,
[ONYXKEYS.IS_SIDEBAR_LOADED]: true,
[ONYXKEYS.PERSONAL_DETAILS_LIST]: mockedPersonalDetails,
[ONYXKEYS.BETAS]: mockedBetas,
[ONYXKEYS.IS_SEARCHING_FOR_REPORTS]: true,
Expand All @@ -130,13 +146,14 @@ test.skip('[Search Page] should interact when text input changes', async () => {
.then(() => measurePerformance(<SearchPageWrapper navigation={navigation} />, {scenario}));
});

test.skip('[Search Page] should render options list', async () => {
test('[Search Page] should render selection list', async () => {
const {triggerTransitionEnd, addListener} = TestHelper.createAddListenerMock();
const smallMockedPersonalDetails = getMockedPersonalDetails(5);

const scenario = async () => {
await screen.findByTestId('SearchPage');
await act(triggerTransitionEnd);
await waitFor(triggerTransitionEnd);
await screen.findByTestId('selection-list');
await screen.findByText(smallMockedPersonalDetails['1'].login);
await screen.findByText(smallMockedPersonalDetails['2'].login);
};
Expand All @@ -147,7 +164,6 @@ test.skip('[Search Page] should render options list', async () => {
.then(() =>
Onyx.multiSet({
...mockedReports,
[ONYXKEYS.IS_SIDEBAR_LOADED]: true,
[ONYXKEYS.PERSONAL_DETAILS_LIST]: smallMockedPersonalDetails,
[ONYXKEYS.BETAS]: mockedBetas,
[ONYXKEYS.IS_SEARCHING_FOR_REPORTS]: true,
Expand All @@ -156,16 +172,18 @@ test.skip('[Search Page] should render options list', async () => {
.then(() => measurePerformance(<SearchPageWrapper navigation={navigation} />, {scenario}));
});

test.skip('[Search Page] should search in options list', async () => {
test('[Search Page] should search in selection list', async () => {
const {triggerTransitionEnd, addListener} = TestHelper.createAddListenerMock();

const scenario = async () => {
await screen.findByTestId('SearchPage');
const input = screen.getByTestId('options-selector-input');
await waitFor(triggerTransitionEnd);

const input = screen.getByTestId('selection-list-text-input');
const searchValue = mockedPersonalDetails['88'].login;

fireEvent.changeText(input, mockedPersonalDetails['88'].login);
await act(triggerTransitionEnd);
await screen.findByText(mockedPersonalDetails['88'].login);
fireEvent.changeText(input, searchValue);
await screen.findByText(searchValue);
};

const navigation = {addListener};
Expand All @@ -174,7 +192,6 @@ test.skip('[Search Page] should search in options list', async () => {
.then(() =>
Onyx.multiSet({
...mockedReports,
[ONYXKEYS.IS_SIDEBAR_LOADED]: true,
[ONYXKEYS.PERSONAL_DETAILS_LIST]: mockedPersonalDetails,
[ONYXKEYS.BETAS]: mockedBetas,
[ONYXKEYS.IS_SEARCHING_FOR_REPORTS]: true,
Expand All @@ -183,17 +200,18 @@ test.skip('[Search Page] should search in options list', async () => {
.then(() => measurePerformance(<SearchPageWrapper navigation={navigation} />, {scenario}));
});

test.skip('[Search Page] should click on list item', async () => {
test('[Search Page] should click on list item', async () => {
const {triggerTransitionEnd, addListener} = TestHelper.createAddListenerMock();

const scenario = async () => {
await screen.findByTestId('SearchPage');
const input = screen.getByTestId('options-selector-input');
const input = screen.getByTestId('selection-list-text-input');
await waitFor(triggerTransitionEnd);

fireEvent.changeText(input, mockedPersonalDetails['4'].login);
await act(triggerTransitionEnd);
const optionButton = await screen.findByText(mockedPersonalDetails['4'].login);
const searchValue = mockedPersonalDetails['4'].login;
fireEvent.changeText(input, searchValue);

const optionButton = await screen.findByText(searchValue);
fireEvent.press(optionButton);
};

Expand All @@ -202,7 +220,6 @@ test.skip('[Search Page] should click on list item', async () => {
.then(() =>
Onyx.multiSet({
...mockedReports,
[ONYXKEYS.IS_SIDEBAR_LOADED]: true,
[ONYXKEYS.PERSONAL_DETAILS_LIST]: mockedPersonalDetails,
[ONYXKEYS.BETAS]: mockedBetas,
[ONYXKEYS.IS_SEARCHING_FOR_REPORTS]: true,
Expand Down
Loading