Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended Drop area to report 🗒️ body for attachment #3732

Merged
merged 3 commits into from
Jun 28, 2021
Merged

Extended Drop area to report 🗒️ body for attachment #3732

merged 3 commits into from
Jun 28, 2021

Conversation

parasharrajat
Copy link
Member

Details

Fixed Issues

Fixes #3605

Tests | QA Steps

  1. Open any conversation on E.cash on the Web or Desktop.
  2. try dropping a file over the composer. Composer should be highlighted and on drop upload attachment modal should open.
  3. Try dropping a file over the Report Body. Composer should not be highlighted and on drop upload attachment modal should open.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

drop.mp4

Mobile Web

Desktop

iOS

Android

@parasharrajat parasharrajat requested a review from a team as a code owner June 23, 2021 16:21
@MelvinBot MelvinBot requested review from ctkochan22 and removed request for a team June 23, 2021 16:21
@parasharrajat parasharrajat changed the title Extended Drop area to report 🗒️ body for attachment Extended Drop area to report 🗒️ body for attachment Jun 23, 2021
@parasharrajat
Copy link
Member Author

parasharrajat commented Jun 24, 2021 •
edited
Loading

Updated. Thanks.

@parasharrajat
Copy link
Member Author

@ctkochan22 Is there anything left to do on this PR? Please let me know. Thanks.

@ctkochan22 ctkochan22 merged commit 461f670 into Expensify:main Jun 28, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

This was referenced Jun 28, 2021
Closed
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.74-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the drag-N-drop branch November 4, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctkochan22 ctkochan22 ctkochan22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the drag and drop target the whole app rather than just the compose box
3 participants
@parasharrajat @OSBotify @ctkochan22