Invite user to workspace via invite link

[narefyev91]

Details

Implement the invite flow from the Simplified Collect: Profile, Members, Categories design doc

Fixed Issues

$ #36946
PROPOSAL: #36946

Tests

Preconditions:

1. Has a workspace (new or existing one)
2. Prepare join url link - use WorkspaceID and admin email for that workspace - ex. https://dev.new.expensify.com:8082/workspace/7DE6960B26D79E36/join?email=tenema5675@bizatop.com

For user:

1. Open link in a new tab (for a new user / or user which already logged in)
2. Verify that loading indicator is shown
3. Verify that user redirects to all workspaces screen
4. Verify that user sees a new line with workspace (in which join link was executed) and user sees chip with text "Requested"
5. Verify that user could not interact with that workspace
6. Wait until admin accept/decline request - verify that user will have/not have access to the workspace

For Admin:

1. When user used join link - verify that a new message is shown in admin room for that workspace
2. Verify that 2 buttons are shown - "Accept"/"Decline"
3. Click on any of them - verify that API request will be send, verify that message will be removed from admin room

• Verify that no errors appear in the JS console

Offline tests

For user:

1. User should be able to put in queue request to join workspace
2. User should be redirected to all workspaces page

For admin:

1. Admin should be able to put in queue request to accept/decline
2. Message should be removed after interact with accept/decline buttons

QA Steps

Preconditions:

1. Has a workspace (new or existing one)
2. Prepare join url link - use WorkspaceID and admin email for that workspace - ex. https://dev.new.expensify.com:8082/workspace/7DE6960B26D79E36/join?email=tenema5675@bizatop.com

For user:

1. Open link in a new tab (for a new user / or user which already logged in)
2. Verify that loading indicator is shown
3. Verify that user redirects to all workspaces screen
4. Verify that user sees a new line with workspace (in which join link was executed) and user sees chip with text "Requested"
5. Verify that user could not interact with that workspace
6. Wait until admin accept/decline request - verify that user will have/not have access to the workspace

For Admin:

1. When user used join link - verify that a new message is shown in admin room for that workspace
2. Verify that 2 buttons are shown - "Accept"/"Decline"
3. Click on any of them - verify that API request will be send, verify that message will be removed from admin room

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

ios-web-user.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

[luacmartins]

I noticed that we're making 3 requests to JoinWorkspaceViaInviteLink for each page load:

[luacmartins]

The requested badge position breaks in narrower screens

[luacmartins]

We need to hide the buttons once a user chooses either accept or decline

[narefyev91]

We need to hide the buttons once a user chooses either accept or decline

I think when API fill be working - this buttons will automatically be hidden - because it will remove 'ACTIONABLEJOINREQUEST' - from action type of the message

[rushatgabhane]

Requested access to design doc. Will begin reviewing today :)

[narefyev91]

Something strange with GH - send 2 commits - and they did not appeared, and also already merged main to branch and resolve conflicts - but GH is not view that

[rushatgabhane]

github is having sync issues.

[luacmartins]

@rushatgabhane I shared the doc with you

[rushatgabhane]

1. Request to join workspace. Notice that your request is shown in workspace list page.
2. As admin decline the request.
3. Request to join the workspace again.
4. The request does not show in workspace list page.

@luacmartins @narefyev91 small bug ^

Again, I think this is because the backend send empty onyxData.

[rushatgabhane]

@luacmartins LGTM! tested after resolving the tiny conflict.

Checklist - #37525 (comment)

[luacmartins]

LGTM! We're still investigating the crash on Decline, but that is a backend issue

[melvin-bot]

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

[rushatgabhane]

shhh melvin. all tests pass

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[luacmartins]

What's up with this tests not passing stuff. I'm seeing that a lot lately, but all tests were passing when I merged.

[OSBotify]

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.49-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[rushatgabhane]

What's up with this tests not passing stuff. I'm seeing that a lot lately, but all tests were passing when I merged.

@luacmartins is it possible that the tests pass on this branch but not after merging it into main?

[rushatgabhane]

Btw I can't find which test has failed. All looks green to me

[luacmartins]

I think we have some issue with GH secrets not being available when we run the action after merging the PR from a contributor's fork. We're working on it

[OSBotify]

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.50-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[rushatgabhane]

Coming from #38058

Small bug. The back button shows in medium screen also

[Ollyws]

Simply using goBack here caused an issue (#38824) with the navigation after pressing the WS invitation, we fixed this in #38984.

[Beamanator]

Hmm "Role of the user" is stored in policyID? Should this be updated?

[luacmartins]

Yes, it should. Thanks for noticing this! #41462