Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO QA] Fix imports messed up during merge #3753

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Conversation

jasperhuangg
Copy link
Contributor

Details

There were some imports that were messed up while resolving a merge that were preventing the RequestCallPage from rendering. This PR fixes them.

Fixed Issues

$ N/A

Tests

  1. Navigate to the request call page <baseURL>/request-call
  2. Verify it renders without any errors in the JS console.

QA Steps

N/A

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

N/A

@jasperhuangg jasperhuangg self-assigned this Jun 25, 2021
@jasperhuangg jasperhuangg marked this pull request as ready for review June 25, 2021 03:30
@jasperhuangg jasperhuangg requested a review from a team as a code owner June 25, 2021 03:30
@MelvinBot MelvinBot requested review from Beamanator and removed request for a team June 25, 2021 03:30
Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well now, nice!

@Beamanator Beamanator merged commit 3a77c3a into main Jun 25, 2021
@Beamanator Beamanator deleted the jasper-fixImports branch June 25, 2021 07:56
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.73-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.74-0🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants