New keyboard shortcut for new Group chat #3754
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Beamanator
Details
OS specific shortcut using
libs/getOperatingSystem
To open new group chat.
Command + shift + K
for MacOSControl + shift + K
for Windows/Linux.To not allow extra key modifiers being pressed
const extraModifiers = _.difference(['shift', 'control', 'alt', 'meta'], callback.modifiers);
And then return early if they're being pressed.
Subscribe K to open new group chat.
On subscribing the key K
Contains of eventCallbacks are shown below. Which is why I loop over it.
I also changed shortcut for search on Windows,
from
Win + K
toControl + K
as per the discussion on Slack.Fixed Issues
$ #3349
Tests / QA
Cltr + Shift + K
to give focus to new group chat.Command + Shift + K
to give focus to new group chat.Tested On
Don't have a Mac to test Desktop app.
Not applicable (Mobile Web, iOS, Android)
Screenshots
Web
Screencast.from.25-06-21.03_00_46.PM.+03.mp4
Desktop
Don't have a mac :)