Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable next button on invalid amount. #3765

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Disable next button on invalid amount. #3765

merged 2 commits into from
Jun 29, 2021

Conversation

rushatgabhane
Copy link
Member

Requesting review from @jasperhuangg 😃

Details

Disable next button if amount requested is < 0.01, as the API doesn't support it.

Request for 0.001, API.CreateIOUTransaction returns 405 Invalid amount
image

Fixed Issues

$ #3568

Tests / QA

  1. Login
  2. Make a new money request to user A.
  3. Set amount < 0.01 (ie 0, 0.001 etc)
  4. The Next button should remain disabled.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot from 2021-06-26 01-38-44
Screenshot from 2021-06-26 01-39-08

Mobile Web

WhatsApp Image 2021-06-26 at 01 53 45

Desktop

Screenshot from 2021-06-26 01-49-32

iOS

image

Android

WhatsApp Image 2021-06-26 at 01 53 45 (1)

@rushatgabhane rushatgabhane requested a review from a team as a code owner June 25, 2021 23:03
@MelvinBot MelvinBot requested review from Dal-Papa and removed request for a team June 25, 2021 23:03
@rushatgabhane rushatgabhane changed the title Disable button on invalid amount. Disable next button on invalid amount money request. Jun 25, 2021
@rushatgabhane rushatgabhane changed the title Disable next button on invalid amount money request. Disable next button on invalid amount. Jun 25, 2021
Copy link
Contributor

@jasperhuangg jasperhuangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick suggestion @rushatgabhane

Co-authored-by: Jasper Huang <jasperhu@usc.edu>
@jasperhuangg jasperhuangg merged commit 25ce008 into Expensify:main Jun 29, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.74-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants