-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with the bold (unread) status on Workspace Item #37672
Fix issues with the bold (unread) status on Workspace Item #37672
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / Safariweb.movMacOS: Desktop |
https://github.com/Expensify/App/actions/runs/8145545820 @trjExpensify the ad hoc build is being built above ⬆️ when the QA codes and links are posted in this PR, please them test the original bug. 🙇 |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
cc: @situchan |
For some reports, "Mark as unread" doesn't work. This also happens on main. Screen.Recording.2024-03-08.at.10.33.31.PM.mov |
@cdOut I have the case where bug not fixed yet. I don't see any unread reports but workspace item is still bolded Screen.Recording.2024-03-08.at.10.38.26.PM.mov |
2 bugs (or expected?) in this video
Screen.Recording.2024-03-08.at.10.44.14.PM.mov |
I am not sure this should be fixed here. There are still mysterious unread reports hidden in LHN. ios.mov |
@hayata-suenaga here's summary of existing bugs:
|
@situchan thank you so much for checking for bugs 🙇
Thank you for the screen recording of this issue. In the recording, it appears that you're attempting to mark a report (i.e., chat) with an error as unread. Does the "Mark as unread" function not work for reports with errors? Or does it fail for most reports, without a clear distinction between the ones it works for and those it doesn't?
I don't think a selected workspace should be hidden under any condition. Would you mind creating a GH ticket for this bug? @situchan 🙇
Thank you for reporting this issue. Are these reports are hidden because you're using the focus mode? Or are they hidden for no good reason? |
@cdOut please merge main. I will re-test above mentioned issues on latest codebase. |
merge main into ideal-nav/fix-bold-issue
@situchan done, ready to re-test! |
I am not sure but I think it's related to whisper message.
This seems not happening on latest main
They are hidden for no good reason. |
@cdOut here's console log as you requested: The root cause is that this condition is perfectly met: |
I think I know why that happens. |
@cdOut bump ^ |
@situchan So the fix for this issue would be changing the requirements for when we display a report in the LHN, which is not what I was mostly focusing on fixing in this PR (this was focused on workspace switcher requirements), so it does seem out of scope for this one. However, if I were provided with the account on which the bug persists, I could work on fixing the issue in this PR. It's incredibly difficult to debug without an account with the bugged data and all my accounts have since been cleared of the phantom issues while I was debugging. In short, it does seem a little out of scope for this PR, but I will be able to fix it in this one if you could provide me with the email address used for the account where you encountered it, you could let me log in through magic link so I don't need to access the email account itself. |
If it's not constantly reproducible, not mandatory to fix it in the scope of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Details
Fix issues with old phantom reports incorrectly being shown as unread in the workspace switcher.
Fixed Issues
$ #35682
Tests
Everything
section and also for user-created workspacesOffline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
ANDROID-NATIVE.mov
Android: mWeb Chrome
ANDROID-CHROME.mov
iOS: Native
IOS-NATIVE.mov
iOS: mWeb Safari
IOS-SAFARI.mov
MacOS: Chrome / Safari
CHROME.mov
MacOS: Desktop
DESKTOP.mov