[NO QA] Pass personal policyID to InboxCallUser #3773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasperhuangg
changed the title
Jag96
suggested changes
Jun 29, 2021
jasperhuangg
changed the title
|
@Jag96 Thanks for the review! Addressed some of your concerns, should be good for another review. This'll be on hold for now since I'm waiting on a copy-check for the new text that'll go into the you mentioned. |
Jag96
reviewed
Jul 1, 2021
…r-requestCallPersonalPolicy
Jag96
reviewed
Jul 6, 2021
…r-requestCallPersonalPolicy
jasperhuangg
changed the title
|
@Jag96 I've updated the translation and taken it off hold, feel free to merge if you think everything checks out, thanks! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
57 tasks
jasperhuangg
changed the title
jasperhuangg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
We're adding guides calls to Expensify.cash. Since we currently don't have the concept of an active policy/workspace, we'll default to passing the user's personal policyID to
Inbox_CallUser. Otherwise, the job will throw an exception once it starts running in Expensiworks.Fixed Issues
Related to https://github.com/Expensify/Expensify/issues/167905
Tests
N/A (will be tested with https://github.com/Expensify/Web-Expensify/pull/31319)
QA Steps
N/A