Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2973 set input height to 42 #3805

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

dklymenk
Copy link
Contributor

@dklymenk dklymenk commented Jun 29, 2021

Details

Creates a new variable for input height and applies it to TextInput and Picker components.

Fixed Issues

$ #2973

Tests / QA Steps

iOS

Preferred iOS version is <13, ideally to validate that the issue is fixed you need a device or an emulator where the issue described in the original issue #2973 is reproduced. iOS 12.4 + iPhone 8 is what I used.

  1. Find any single-line non-password text input in the app (email field on login page or name fields in profile settings)
  2. Type a value that doesn't fit the width of the input
  3. Verify that, as you are typing, the text input's horizontal scroll is adjusted to show the last character, if needed

All platforms

  1. Logout
  2. Make sure there are no visual defects caused by increased text input size on login form text inputs
  3. Login
  4. Select any chat
  5. Check for visual defects on message compose box
  6. Click the search icon (on mobile you need to tap the back icon)
  7. Check for visual defects on search text input
  8. Tap your profile icon
  9. Check for visual defects on text input and picker elements under Profile and Preferences sub menus

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-06-29 at 22 29 00

Mobile Web

Screen Shot 2021-06-29 at 22 34 46

Desktop

Screen Shot 2021-06-29 at 22 34 46

iOS

Simulator.Screen.Recording.-.iPhone.8.-.2021-06-29.at.22.19.13.mp4

Android

Screen Shot 2021-06-29 at 22 34 46

@dklymenk dklymenk requested a review from a team as a code owner June 29, 2021 20:13
@MelvinBot MelvinBot requested review from iwiznia and removed request for a team June 29, 2021 20:13
@iwiznia iwiznia merged commit b076be2 into Expensify:main Jun 29, 2021
@dklymenk dklymenk deleted the 2973-fix-email-non-scrollable branch June 29, 2021 21:20
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.74-2🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants