Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert suppression of touchstart to fix regressions #3816

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Jun 29, 2021

Details

Partially reverts https://github.com/Expensify/Expensify.cash/pull/3659/files, particularly this commit to fix two major regressions (my fault for not noticing during my testing).

Fixed Issues

$ #3806

Tests / QA Steps

  1. Verify that you can scroll through a chat on mobile web.
  2. Verify that you can open the "edit chat" input, then close it too.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

image

Desktop

iOS

Android

@roryabraham roryabraham requested a review from a team as a code owner June 29, 2021 23:52
@roryabraham roryabraham self-assigned this Jun 29, 2021
@OSBotify
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from tylerkaraszewski and removed request for a team June 29, 2021 23:52
@roryabraham roryabraham mentioned this pull request Jun 29, 2021
5 tasks
@parasharrajat
Copy link
Member

parasharrajat commented Jun 30, 2021

This PR needs to be merged ASAP. There are more than 4 regressions.

@roryabraham roryabraham merged commit af376d2 into main Jun 30, 2021
@roryabraham roryabraham deleted the Rory-RevertSuppressTouch branch June 30, 2021 17:58
github-actions bot pushed a commit that referenced this pull request Jun 30, 2021
Revert suppression of touchstart to fix regressions

(cherry picked from commit af376d2)
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging in version: 1.0.75-2🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants