-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/38198: "Delayed Submissions" toggle does not toggle off unless backed out for Collect Policy #38215
Conversation
@mountiny The PR is ready |
@mountiny Yeah, I will handle here |
src/libs/actions/Policy.ts
Outdated
autoReporting: policy.autoReporting, | ||
harvesting: policy.harvesting, | ||
autoReportingFrequency: policy.autoReportingFrequency, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
autoReporting: policy.autoReporting, | |
harvesting: policy.harvesting, | |
autoReportingFrequency: policy.autoReportingFrequency, | |
autoReporting: policy.autoReporting ?? null, | |
harvesting: {enabled: policy.harvesting?.enabled ?? null}, | |
autoReportingFrequency: policy.autoReportingFrequency ?? null, |
- When merging we need to be sure we are not merging a
undefined
value because it's a NOOP. Merging{autoReporting: undefined}
is same as not merging at all and the value won't get reverted. - For objects we should merge only the values that we did actually change and not the whole object
(Same goes for other fields)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Updating
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.movAndroid: mWeb Chromemweb-chrome.moviOS: Nativeios.moviOS: mWeb Safarimweb-safari.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment we can address in time before next deploy
Co-authored-by: Carlos Martins <luacmartins@gmail.com>
@mountiny @luacmartins Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.53-0 🚀
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.53-2 🚀
|
Details
Fixed Issues
$ #38198
PROPOSAL: NA
Tests
Offline tests
Same above
QA Steps
Same above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-03-13.at.18.40.42.mov
Android: mWeb Chrome
Screen.Recording.2024-03-13.at.18.29.42.mov
iOS: Native
Screen.Recording.2024-03-13.at.18.40.30.mov
iOS: mWeb Safari
Screen.Recording.2024-03-13.at.18.29.08.mov
MacOS: Chrome / Safari
Screen.Recording.2024-03-13.at.18.26.40.mov
MacOS: Desktop
Screen.Recording.2024-03-13.at.18.30.03.mov