Fix area around bottom tab avatar isn't clickable #38380

bernhardoj · 2024-03-15T10:01:53Z

Details

The are around the bottom tab avatar isn't clickable.

Fixed Issues

$ #38369
PROPOSAL: #38369 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

A.

Click/press around the area of the bottom tab avatar
Verify that it opens the settings page

B.

Click/press around the area of the bottom tab FAB
Verify the FAB menu is visible
Click/press again around the area of the bottom tab FAB
Verify the FAB menu closes
Hover over the area of all the 3 bottom tab menus (Chats, FAB, and Profile)
Verify the tooltip shows

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-15.at.17.56.28.mov

Android: mWeb Chrome

Screen.Recording.2024-03-15.at.17.55.19.mov

iOS: Native

Screen.Recording.2024-03-15.at.17.54.53.mov

iOS: mWeb Safari

Screen.Recording.2024-03-15.at.17.54.16.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-15.at.17.49.59.mov

Screen.Recording.2024-03-18.at.15.23.30.mov

MacOS: Desktop

Screen.Recording.2024-03-15.at.17.52.27.mov

Screen.Recording.2024-03-18.at.15.23.50.mov

…able

melvin-bot · 2024-03-15T10:01:58Z

@paultsimura Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

paultsimura · 2024-03-15T10:42:01Z

@mountiny while testing this PR, I've noticed the following bug (the FAB menu flashes when clicking the area around it, as opposed to when clicking on the FAB directly):

Screen.Recording.2024-03-15.at.11.37.44-compressed.mp4

Since these 2 components are somewhat related (and given there is no issue reported) and @bernhardoj would like to come up with a fix for it as well – could we consider bumping to the regular $500 and fixing both issues in one PR?

paultsimura · 2024-03-15T11:09:08Z

src/pages/home/sidebar/ProfileAvatarWithIndicator.tsx

+    );
+}
+
+ProfileAvatarWithIndicator.displayName = 'PressableAvatarWithIndicator';


Suggested change

ProfileAvatarWithIndicator.displayName = 'PressableAvatarWithIndicator';

ProfileAvatarWithIndicator.displayName = 'ProfileAvatarWithIndicator';

paultsimura · 2024-03-15T11:14:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android12.04.mp4

Android: mWeb Chrome

chrome12.05.mp4

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-03-15.at.11.55.5812.05.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-03-15.at.11.55.3812.05.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-03-18.at.09.53.1409.53.mp4

MacOS: Desktop

Screen.Recording.2024-03-15.at.11.34.1912.05.mp4

mountiny · 2024-03-15T11:19:22Z

@bernhardoj yep if you can fix that here too happy with $500

bernhardoj · 2024-03-15T12:09:19Z

Found the issue. When we press the area around FAB, isCreateMenuActive value is false.

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js

Lines 142 to 147 in e9c112a

    
           const toggleCreateMenu = () => { 
        
               if (isCreateMenuActive) { 
        
                   hideCreateMenu(); 
        
               } else { 
        
                   showCreateMenu(); 
        
               }

That is because, in PopoverProvider, we have a click listener that will close a popover, except if the popover anchorRef is the same as the element that we click.

App/src/components/PopoverProvider/index.tsx

Lines 37 to 44 in e9c112a

    
           const listener = (e: Event) => { 
        
               if (elementContains(activePopoverRef.current?.ref, e.target) || elementContains(activePopoverRef.current?.anchorRef, e.target)) { 
        
                   return; 
        
               } 
        
               const ref = activePopoverRef.current?.anchorRef; 
        
               closePopover(ref); 
        
           }; 
        
           document.addEventListener('click', listener, true);

FAB currently has 2 pressable and the anchorRef is set to the inner pressable.

App/src/components/FloatingActionButton.tsx

Lines 106 to 120 in e9c112a

    
           return ( 
        
               <PressableWithoutFeedback 
        
                   style={styles.h100} 
        
                   accessibilityLabel={accessibilityLabel} 
        
                   onPress={toggleFabAction} 
        
               > 
        
                   <View style={styles.bottomTabBarItem}> 
        
                       <Tooltip text={translate('common.create')}> 
        
                           <AnimatedPressable 
        
                               ref={(el) => { 
        
                                   fabPressable.current = el ?? null; 
        
                                   if (buttonRef && 'current' in buttonRef) { 
        
                                       buttonRef.current = el ?? null; 
        
                                   } 
        
                               }}

So, if we press the outer pressable, the PopoverProvider will close the FAB menu then the FAB click (toggleCreateMenu) will be executed which will show the popover again.

We can fix it by only having the outer pressable and replacing the inner one with an animated view, but the problem that comes after that is the tooltip won't hide when the popover is visible.

Screen.Recording.2024-03-15.at.19.55.44.mov

That's because PopoverAnchorTooltip will only hide the tooltip if the children of the tooltip are the popover anchor ref element, which in our case is not because we wrap the tooltip to the inner animated view.

App/src/components/Tooltip/PopoverAnchorTooltip.tsx

Lines 11 to 16 in e9c112a

    
           const isPopoverRelatedToTooltipOpen = useMemo(() => { 
        
               // eslint-disable-next-line @typescript-eslint/dot-notation 
        
               const tooltipNode = tooltipRef.current?.['_childNode'] ?? null; 
        
               if (isOpen && popover?.anchorRef?.current && tooltipNode && (tooltipNode.contains(popover.anchorRef.current) || tooltipNode === popover.anchorRef.current)) { 
        
                   return true; 
        
               }

What if we move the tooltip to the outer pressable, it will look like this:

Screen.Recording.2024-03-15.at.20.07.36.mov

@paultsimura @mountiny

paultsimura · 2024-03-15T12:25:21Z

What if we move the tooltip to the outer pressable, it will look like this

@Expensify/design WDYT? #38380 (comment)

shawnborton · 2024-03-15T12:35:58Z

What if we move the tooltip to the outer pressable, it will look like this:

Personally I would be okay with that, I think it's fine. Curious if @Expensify/design agrees!

dubielzyk-expensify · 2024-03-17T21:34:25Z

Yeah, I'm okay with that as well 👍

paultsimura · 2024-03-17T22:19:18Z

Awesome, seems like we have an agreement. @bernhardoj would you implement the fix, please?

bernhardoj · 2024-03-18T07:28:27Z

@paultsimura Great. Updated the code and test.

bernhardoj · 2024-03-18T07:32:54Z

Oh, we got a TS error because of renaming the PressableAvatarWithIndicator to ProfileAvatarWithIndicator

What should we do here?

paultsimura · 2024-03-18T07:35:39Z

@mountiny can we somehow skip this check? It's not technically a new file - just a rename to match the file nature better.

mountiny · 2024-03-18T11:53:12Z

no problem, continue with the review

paultsimura

LGTM.

I've also retested the second issue and attached the recording – ✔️

mountiny

thank you!

melvin-bot · 2024-03-18T15:40:13Z

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2024-03-18T15:45:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

mountiny · 2024-03-18T15:54:04Z

The JS file was renamed

OSBotify · 2024-03-18T16:31:10Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.54-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-19T23:12:14Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.54-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

restructure the profile avatar so the area around the avatar is click…

5565437

…able

bernhardoj requested a review from a team as a code owner March 15, 2024 10:01

melvin-bot bot requested review from paultsimura and removed request for a team March 15, 2024 10:01

bernhardoj mentioned this pull request Mar 15, 2024

[HOLD for payment 2024-03-26] [$500] [Wave Collect] [Ideal Nav] Area around account avatar icon is not actionable like chat icon #38369

Closed

6 tasks

paultsimura suggested changes Mar 15, 2024

View reviewed changes

mountiny assigned bernhardoj Mar 15, 2024

rename display name

1e611cb

merge main

9b90c79

bernhardoj added 2 commits March 18, 2024 14:58

Merge branch 'main' into fix/38369-avatar-bottom-tab-bar-pressable-area

5d3c528

fix unable to close fab and tooltip area

19a772d

paultsimura approved these changes Mar 18, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny March 18, 2024 11:55

mountiny approved these changes Mar 18, 2024

View reviewed changes

mountiny merged commit 59b3919 into Expensify:main Mar 18, 2024
18 of 19 checks passed

melvin-bot bot added the Emergency label Mar 18, 2024

mountiny removed the Emergency label Mar 18, 2024

github-actions bot mentioned this pull request Mar 18, 2024

Deploy Checklist: New Expensify 2024-03-18 #38489

Closed

65 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix area around bottom tab avatar isn't clickable #38380

Fix area around bottom tab avatar isn't clickable #38380

bernhardoj commented Mar 15, 2024 •

edited

Loading

melvin-bot bot commented Mar 15, 2024

paultsimura commented Mar 15, 2024

paultsimura Mar 15, 2024

bernhardoj Mar 15, 2024

paultsimura commented Mar 15, 2024 •

edited

Loading

mountiny commented Mar 15, 2024

bernhardoj commented Mar 15, 2024

paultsimura commented Mar 15, 2024

shawnborton commented Mar 15, 2024

dubielzyk-expensify commented Mar 17, 2024

paultsimura commented Mar 17, 2024

bernhardoj commented Mar 18, 2024

bernhardoj commented Mar 18, 2024

paultsimura commented Mar 18, 2024

mountiny commented Mar 18, 2024

paultsimura left a comment •

edited

Loading

mountiny left a comment

melvin-bot bot commented Mar 18, 2024

OSBotify commented Mar 18, 2024

mountiny commented Mar 18, 2024

OSBotify commented Mar 18, 2024

OSBotify commented Mar 19, 2024

	ProfileAvatarWithIndicator.displayName = 'PressableAvatarWithIndicator';
	ProfileAvatarWithIndicator.displayName = 'ProfileAvatarWithIndicator';

Fix area around bottom tab avatar isn't clickable #38380

Fix area around bottom tab avatar isn't clickable #38380

Conversation

bernhardoj commented Mar 15, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 15, 2024

paultsimura commented Mar 15, 2024

paultsimura Mar 15, 2024

Choose a reason for hiding this comment

bernhardoj Mar 15, 2024

Choose a reason for hiding this comment

paultsimura commented Mar 15, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

mountiny commented Mar 15, 2024

bernhardoj commented Mar 15, 2024

paultsimura commented Mar 15, 2024

shawnborton commented Mar 15, 2024

dubielzyk-expensify commented Mar 17, 2024

paultsimura commented Mar 17, 2024

bernhardoj commented Mar 18, 2024

bernhardoj commented Mar 18, 2024

paultsimura commented Mar 18, 2024

mountiny commented Mar 18, 2024

paultsimura left a comment • edited Loading

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Mar 18, 2024

OSBotify commented Mar 18, 2024

mountiny commented Mar 18, 2024

OSBotify commented Mar 18, 2024

OSBotify commented Mar 19, 2024

bernhardoj commented Mar 15, 2024 •

edited

Loading

paultsimura commented Mar 15, 2024 •

edited

Loading

paultsimura left a comment •

edited

Loading