Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use left/right arrow keys to move cursor in IOUAmountPage #3850

Merged
merged 9 commits into from
Jul 2, 2021
Merged

Use left/right arrow keys to move cursor in IOUAmountPage #3850

merged 9 commits into from
Jul 2, 2021

Conversation

rushatgabhane
Copy link
Member

@rushatgabhane rushatgabhane commented Jul 1, 2021

cc @roryabraham

Details

Replace onKeyPress prop with onChangeText prop and handle the amount changed.

Also, rename updateAmountIfValidInput() to updateAmountNumberPad(), and Remove check for Backspace.
Because it updates amount only for numpad now.

Fixed Issues

$ #3779

Tests / QA

  1. Request money to any user.
  2. Enter an amount.
  3. Verify that you can use left and right arrow keys to move the cursor and edit the amount.

Tested On

Don't have mac to test desktop app.

  • Web
  • Android
  • Mobile Web
  • Desktop
  • iOS

Screenshots

Web

NEW.Expensify.cash.-.Google.Chrome.2021-06-29.03-11-09.mp4

Android

Mobile Web

Desktop

image

iOS

image

@rushatgabhane rushatgabhane requested a review from a team as a code owner July 1, 2021 04:43
@MelvinBot MelvinBot requested review from roryabraham and removed request for a team July 1, 2021 04:43
@roryabraham
Copy link
Contributor

Don't have mac to test desktop app.

Appreciate you calling this out! I can test on desktop 🙂

@roryabraham
Copy link
Contributor

@rushatgabhane Can you also be sure to test and include screenshots for mobile web and android? I will test on iOS and desktop for you 😄

@rushatgabhane
Copy link
Member Author

@rushatgabhane Can you also be sure to test and include screenshots for mobile web and android? I will test on iOS and desktop for you 😄

Thanks, really appreciate it!
Yup, will add screenshots asap.

src/pages/iou/steps/IOUAmountPage.js Outdated Show resolved Hide resolved
src/pages/iou/steps/IOUAmountPage.js Outdated Show resolved Hide resolved
src/pages/iou/steps/IOUAmountPage.js Outdated Show resolved Hide resolved
rushatgabhane and others added 3 commits July 1, 2021 22:39
Co-authored-by: Rory Abraham <47436092+roryabraham@users.noreply.github.com>
src/pages/iou/steps/IOUAmountPage.js Outdated Show resolved Hide resolved
src/pages/iou/steps/IOUAmountPage.js Outdated Show resolved Hide resolved
rushatgabhane and others added 2 commits July 1, 2021 23:16
Co-authored-by: Rory Abraham <47436092+roryabraham@users.noreply.github.com>
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes! Great work!

@roryabraham roryabraham merged commit cb57342 into Expensify:main Jul 2, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Jul 2, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@roryabraham
Copy link
Contributor

Unfortunately the deploy comments are not working right now. This was deployed to staging yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants