35380 virtual viewport on report screen #38755

suneox · 2024-03-21T17:29:21Z

Details

Fixed Issues

$ #35380
PROPOSAL: #35380 (comment)

Tests

Open any a chat
Open the native keyboard emoji picker
Verify that the emoji picker does not overlap the composer

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open any a chat
Open the native keyboard emoji picker
Verify that the emoji picker does not overlap the composer

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-21.at.23.45.05.mov

Android: mWeb Chrome

Screen.Recording.2024-03-21.at.23.52.13.mov

iOS: Native

Screen.Recording.2024-03-21.at.23.42.42.mov

iOS: mWeb Safari

Screen.Recording.2024-03-21.at.23.41.14.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-21.at.23.55.12.mov

MacOS: Desktop

Screen.Recording.2024-03-22.at.00.01.30.mov

melvin-bot · 2024-03-21T17:29:26Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan · 2024-03-21T17:33:53Z

src/components/EmojiPicker/EmojiPicker.js

@@ -176,7 +176,7 @@ const EmojiPicker = forwardRef((props, ref) => {
            onModalShow={focusEmojiSearchInput}
            onModalHide={onModalHide.current}
            hideModalContentWhileAnimating
-            shouldSetModalVisibility={false}
+            shouldSetModalVisibility={Browser.isMobile()}


This also affects mChrome. Is it safe?
It would be good to add comment on platform specific changes like this.

Yes it must be specific for mSafari, i have update and add comment

situchan · 2024-03-21T17:35:26Z

src/styles/index.ts

@@ -1639,7 +1639,7 @@ const styles = (theme: ThemeColors) =>

        popoverInnerContainer: {
            paddingTop: 0, // adjusting this because the mobile modal adds additional padding that we don't need for our layout
-            maxHeight: '95%',
+            maxHeight: '100%',


Please check past PR where 95% value was added and confirm that this doesn't cause any regression which that PR fixes.

I have reverted this change.

This reverts commit 750d321.

situchan · 2024-03-24T17:43:32Z

src/libs/actions/Modal.ts

- */
-function setModalVisibility(isVisible: boolean) {
-    Onyx.merge(ONYXKEYS.MODAL, {isVisible});
+    setModalVisibility(false);


Please make sure that this change doesn't cause any regressions.
Especially when PopoverWithoutOverlay is opened and closed inside Modal on web platform.

Actually, which bug does this change fix?

I'll check condition only setModalVisibility when current browser isMobileSafari

Hi @situchan i have updated the condition to avoid regression and we don't need to change setModalVisibility, so I have reverted code change related to setModalVisibility

situchan

Add Tests / QA Steps for #35403

situchan · 2024-03-24T17:44:16Z

src/pages/home/ReportScreen.tsx

+    /** Indicates if there is a modal currently visible or not */
+    modal: OnyxEntry<OnyxTypes.Modal>;


Suggested change

/** Indicates if there is a modal currently visible or not */

modal: OnyxEntry<OnyxTypes.Modal>;

/** Indicates if there is a modal currently visible or not */

modal: OnyxEntry<OnyxTypes.Modal>;

i have updated description

situchan · 2024-03-24T17:49:41Z

src/pages/home/ReportScreen.tsx

@@ -131,7 +133,7 @@ function ReportScreen({
    markReadyForHydration,
    policies = {},
    isSidebarLoaded = false,
-    viewportOffsetTop,
+    modal = {isVisible: false},


default value here is redundant

…ort-on-report-screen

src/pages/home/ReportScreen.tsx

Co-authored-by: Situ Chandra Shil <108292595+situchan@users.noreply.github.com>

situchan · 2024-03-26T02:48:42Z

Please retest latest changes on all platforms. And merge main to fix perf tests

suneox · 2024-03-26T03:42:12Z

Please retest latest changes on all platforms. And merge main to fix perf tests

@situchan I have tested after sync the latest main and fix perf tests

iOS: Native

Screen.Recording.2024-03-26.at.10.27.25.mov

iOS: mWeb Safari

Screen.Recording.2024-03-26.at.10.05.56.mov

Android: mWeb Chrome

screen-20240326-103233.mp4

Android: Native

https://github.com/Expensify/App/assets/11959869/4cf82ee7-4c7c-4e87-96d9-8cd17d915c83
https://github.com/Expensify/App/assets/11959869/12eca840-b796-4acb-80d9-0a6fbb74f685

MacOS: Desktop

Screen.Recording.2024-03-26.at.10.37.40.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-26.at.10.08.05.mov

situchan · 2024-03-26T11:07:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

iwiznia · 2024-03-26T16:26:20Z

src/components/EmojiPicker/EmojiPickerMenu/useEmojiPickerMenu.js

@@ -24,7 +24,8 @@ const useEmojiPickerMenu = () => {
    const [preferredSkinTone] = usePreferredEmojiSkinTone();
    const {windowHeight} = useWindowDimensions();
    const StyleUtils = useStyleUtils();
-    const listStyle = StyleUtils.getEmojiPickerListHeight(isListFiltered, windowHeight);
+    // calculate the height of the emoji picker based popoverInnerContainer style has maxHeight is 95%


Can you update the comment to explain why 95%?

I have updated explain the reason for 95%

iwiznia · 2024-03-26T16:29:05Z

src/hooks/useViewportOffsetTop/index.ts

+        return () => {
+            removeViewportResizeListener();
+        };


This function is not needed right?

Suggested change

return () => {

removeViewportResizeListener();

};

return removeViewportResizeListener;

yes I have cleanup this function

melvin-bot · 2024-03-26T20:26:20Z

@iwiznia looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

iwiznia · 2024-03-26T20:32:30Z

What?! The test was passing when I clicked it 😕

OSBotify · 2024-03-26T20:32:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

suneox · 2024-03-27T16:34:12Z

Hi @iwiznia could you please help me deploy an adhoc build?

iwiznia · 2024-03-27T17:06:17Z

Sure but I don't know how or even what an adhoc build is.

suneox · 2024-03-29T14:22:21Z

Sure but I don't know how or even what an adhoc build is.

We don't need to create an ad hoc I can reproduce issue #39061 when showing smart app banner

suneox added 2 commits March 22, 2024 00:24

fix virtual viewport scroll on report screen

b692714

update popover max height

750d321

suneox requested a review from a team as a code owner March 21, 2024 17:29

melvin-bot bot removed the request for review from a team March 21, 2024 17:29

melvin-bot bot requested a review from situchan March 21, 2024 17:29

suneox mentioned this pull request Mar 21, 2024

[HOLD for payment 2024-04-05] [$1000] Chat - The keyboard is overlapping with the composer #35380

Closed

6 tasks

situchan reviewed Mar 21, 2024

View reviewed changes

suneox added 3 commits March 22, 2024 00:37

fix type check

4df3eb8

Revert "update popover max height"

52e6585

This reverts commit 750d321.

update code review and fix eslint

14232fe

situchan reviewed Mar 24, 2024

View reviewed changes

suneox added 2 commits March 26, 2024 08:08

Merge remote-tracking branch 'upstream/main' into 35380-virtual-viewp…

9215e2d

…ort-on-report-screen

update condition avoid regression

967184b

situchan reviewed Mar 26, 2024

View reviewed changes

src/pages/home/ReportScreen.tsx Show resolved Hide resolved

update code review

8114339

Co-authored-by: Situ Chandra Shil <108292595+situchan@users.noreply.github.com>

revert emoji picker using cached height

5f3f51c

situchan approved these changes Mar 26, 2024

View reviewed changes

melvin-bot bot requested a review from iwiznia March 26, 2024 11:08

iwiznia requested changes Mar 26, 2024

View reviewed changes

cleanup function and update comment

1f8265c

iwiznia approved these changes Mar 26, 2024

View reviewed changes

iwiznia merged commit 4eb0705 into Expensify:main Mar 26, 2024
17 checks passed

melvin-bot bot added the Emergency label Mar 26, 2024

iwiznia removed the Emergency label Mar 26, 2024

github-actions bot mentioned this pull request Mar 27, 2024

Deploy Checklist: New Expensify 2024-03-27 #39033

Closed

tgolen mentioned this pull request Mar 27, 2024

[HOLD for payment 2024-04-25] [$500] Chat - Compose Box is shown above empty space and doesn't resize properly #39061

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

35380 virtual viewport on report screen #38755

35380 virtual viewport on report screen #38755

suneox commented Mar 21, 2024 •

edited

Loading

melvin-bot bot commented Mar 21, 2024

situchan Mar 21, 2024

suneox Mar 21, 2024

situchan Mar 21, 2024

suneox Mar 21, 2024

situchan Mar 24, 2024 •

edited

Loading

suneox Mar 25, 2024 •

edited

Loading

suneox Mar 26, 2024

situchan left a comment

situchan Mar 24, 2024

suneox Mar 26, 2024

situchan Mar 24, 2024

situchan commented Mar 26, 2024

suneox commented Mar 26, 2024

situchan commented Mar 26, 2024

iwiznia Mar 26, 2024

suneox Mar 26, 2024

iwiznia Mar 26, 2024

suneox Mar 26, 2024

melvin-bot bot commented Mar 26, 2024

iwiznia commented Mar 26, 2024

OSBotify commented Mar 26, 2024

suneox commented Mar 27, 2024

iwiznia commented Mar 27, 2024

suneox commented Mar 29, 2024

		/** Indicates if there is a modal currently visible or not */
		modal: OnyxEntry<OnyxTypes.Modal>;

35380 virtual viewport on report screen #38755

35380 virtual viewport on report screen #38755

Conversation

suneox commented Mar 21, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 21, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

situchan Mar 24, 2024 • edited Loading

Choose a reason for hiding this comment

suneox Mar 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

situchan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

situchan commented Mar 26, 2024

suneox commented Mar 26, 2024

situchan commented Mar 26, 2024

Reviewer Checklist

Screenshots/Videos

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

melvin-bot bot commented Mar 26, 2024

iwiznia commented Mar 26, 2024

OSBotify commented Mar 26, 2024

suneox commented Mar 27, 2024

iwiznia commented Mar 27, 2024

suneox commented Mar 29, 2024

suneox commented Mar 21, 2024 •

edited

Loading

situchan Mar 24, 2024 •

edited

Loading

suneox Mar 25, 2024 •

edited

Loading