fixes "Skeleton is displayed when navigating to a transaction thread created offline" #38955

ishpaul777 · 2024-03-25T19:18:37Z

Details

Fixed Issues

$ #39029
PROPOSAL:

Tests

Verify that no errors appear in the JS console

sign out of app and sign in again, verify when app is loading after sign in for first time "Not-found" page not appearing.
change reportid in route to a id you dont have access to https://staging.new.expensify.com/r/<randomid> verify not found page appears
change reportid in route to a 0 https://staging.new.expensify.com/r/0 verify not found page appears

Offline tests

QA Steps

Verify that no errors appear in the JS console
same as testing steps

PR Author Checklist

Screenshots/Videos

Android: Native

Record_2024-03-27-23-39-43.mp4

Android: mWeb Chrome

trim.EE4B375F-6BB7-4B6D-9607-B5B0925176B1.MOV

iOS: Native

Screen.Recording.2024-03-27.at.11.28.40.PM-1.mov

iOS: mWeb Safari

Screen.Recording.2024-03-27.at.11.20.12.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-26.at.3.47.33.AM.mov

MacOS: Desktop

Screen.Recording.2024-03-27.at.11.48.51.PM.mov

ishpaul777 · 2024-03-25T22:28:23Z

Root cause for the issue:

For the first render when the report id is 0, (!!reportIDFromRoute && !ReportUtils.isValidReportIDFromPath(reportIDFromRoute))) this condition triggers and not found page appears.

https://github.com/Expensify/App/blob/main/src/pages/home/ReportScreen.tsx#L352

i added condition to show not found only when !firstRenderRef.current && (all other conditionals) so first skelaton appears only then if condition trigger it shows not found

melvin-bot · 2024-03-25T22:32:25Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2024-03-25T22:32:51Z

@roryabraham Can you please review! 🙇‍♂️

ishpaul777 · 2024-03-27T18:21:13Z

@roryabraham Pr is open for your review

roryabraham

sorry for the delay @ishpaul777, LGTM 👍🏼

roryabraham · 2024-03-28T14:39:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

melvin-bot · 2024-03-28T14:42:03Z

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

roryabraham · 2024-03-28T14:42:53Z

tests were passing, I think I just didn't wait long enough after finishing the reviewer checklist for it to turn ✅

OSBotify · 2024-03-28T14:48:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-29T02:27:59Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

bernhardoj · 2024-03-29T10:14:00Z

src/pages/home/ReportScreen.tsx

@@ -102,7 +102,7 @@ type ReportScreenProps = OnyxHOCProps & CurrentReportIDContextValue & ReportScre
 function getReportID(route: ReportScreenNavigationProps['route']): string {
    // The report ID is used in an onyx key. If it's an empty string, onyx will return
    // a collection instead of an individual report.
-    return String(route.params?.reportID || 0);
+    return String(route.params?.reportID || '');


I believe this change has caused this composer issue

Screen.Recording.2024-03-29.at.18.07.10.mov

Open a chat

Go to settings

Go back to chat

It only happens once for each chat, so switch to another chat if you want to try it again

Returning an empty string will fetch the whole collection of onyx data as pointed out in the comment, e.g.,
reportIsComposerFullSize_, report_

this was previously fixed in #31602

Thank for pointing it out @bernhardoj, what do you think the right fix for it, is it this?

const reportIDFromRoute = route?.params?.reportID ?? '';

Yeah, getReportID should return 0 as a fallback and have a separate variable that returns an empty string as a fallback, just like the old code.

Hi guys, this PR introduced this deploy blocker #39361, I will revert while we ensure that returning 0 here is the correct solution

OSBotify · 2024-04-02T11:04:15Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.58-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fixes the issue

9b65be8

ishpaul777 changed the title ~~fixes the issue~~ fixes "Skeleton is displayed when navigating to a transaction thread created offline" Mar 25, 2024

run prettier

634596f

ishpaul777 closed this Mar 25, 2024

ishpaul777 reopened this Mar 25, 2024

ishpaul777 added 2 commits March 26, 2024 03:20

remove usememo

008de2b

fixes infinite loading of 0 report id

4491fef

Merge branch 'main' into fix/show-404-for-invalid-report

148cc48

ishpaul777 marked this pull request as ready for review March 25, 2024 22:32

ishpaul777 requested a review from a team as a code owner March 25, 2024 22:32

melvin-bot bot requested review from alitoshmatov and removed request for a team March 25, 2024 22:32

ishpaul777 and others added 3 commits March 27, 2024 05:27

Merge branch 'Expensify:main' into fix/show-404-for-invalid-report

9cfcbb9

Merge branch 'Expensify:main' into fix/show-404-for-invalid-report

b572a68

fix lint

540c5dd

roryabraham approved these changes Mar 28, 2024

View reviewed changes

roryabraham removed the request for review from alitoshmatov March 28, 2024 14:37

roryabraham merged commit ff7a509 into Expensify:main Mar 28, 2024
21 checks passed

melvin-bot bot added the Emergency label Mar 28, 2024

roryabraham removed the Emergency label Mar 28, 2024

This was referenced Mar 28, 2024

[TEST MONDAY] Chat - When navigation to an IOU link with no access, page keeps loading #39090

Closed

[HOLD for payment 2024-04-05] Sign up - Hmmm its not here page is displayed for a moment on sign up #38826

Closed

github-actions bot mentioned this pull request Mar 29, 2024

Deploy Checklist: New Expensify 2024-03-29 #39222

Closed

bernhardoj reviewed Mar 29, 2024

View reviewed changes

This was referenced Apr 1, 2024

[CP Staging] Revert "fixes "Skeleton is displayed when navigating to a transaction thread created offline"" #39377

Merged

[$500] Web - Chat - Composer with emoji is expanded with an empty line after expanding the composer #39361

Closed

ishpaul777 mentioned this pull request Apr 1, 2024

[CP Staging] Fix-#39361 Composer with emoji is expanded with an empty line after returning from Settings #39378

Closed

50 tasks

melvin-bot bot mentioned this pull request Apr 2, 2024

[HOLD for payment 2024-04-09] [$500] Infinite skeleton loader appears when manually changing URL to an invalid report #39029

Closed

6 tasks

hungvu193 mentioned this pull request Apr 4, 2024

[$500] Share code - Tapping reply in thread share code URL directs to page loading infinitely #39415

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixes "Skeleton is displayed when navigating to a transaction thread created offline" #38955

fixes "Skeleton is displayed when navigating to a transaction thread created offline" #38955

ishpaul777 commented Mar 25, 2024 •

edited

Loading

ishpaul777 commented Mar 25, 2024

melvin-bot bot commented Mar 25, 2024

ishpaul777 commented Mar 25, 2024 •

edited

Loading

ishpaul777 commented Mar 27, 2024

roryabraham left a comment

roryabraham commented Mar 28, 2024 •

edited

Loading

melvin-bot bot commented Mar 28, 2024

roryabraham commented Mar 28, 2024

OSBotify commented Mar 28, 2024

OSBotify commented Mar 29, 2024

bernhardoj Mar 29, 2024

ishpaul777 Mar 29, 2024

bernhardoj Mar 30, 2024

marcochavezf Apr 1, 2024

OSBotify commented Apr 2, 2024

fixes "Skeleton is displayed when navigating to a transaction thread created offline" #38955

fixes "Skeleton is displayed when navigating to a transaction thread created offline" #38955

Conversation

ishpaul777 commented Mar 25, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

ishpaul777 commented Mar 25, 2024

melvin-bot bot commented Mar 25, 2024

ishpaul777 commented Mar 25, 2024 • edited Loading

ishpaul777 commented Mar 27, 2024

roryabraham left a comment

Choose a reason for hiding this comment

roryabraham commented Mar 28, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Mar 28, 2024

roryabraham commented Mar 28, 2024

OSBotify commented Mar 28, 2024

OSBotify commented Mar 29, 2024

bernhardoj Mar 29, 2024

Choose a reason for hiding this comment

ishpaul777 Mar 29, 2024

Choose a reason for hiding this comment

bernhardoj Mar 30, 2024

Choose a reason for hiding this comment

marcochavezf Apr 1, 2024

Choose a reason for hiding this comment

OSBotify commented Apr 2, 2024

ishpaul777 commented Mar 25, 2024 •

edited

Loading

ishpaul777 commented Mar 25, 2024 •

edited

Loading

roryabraham commented Mar 28, 2024 •

edited

Loading