Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix submit and close next steps for optimistically created policy #39563

Merged
merged 14 commits into from
Apr 8, 2024
Merged

Fix submit and close next steps for optimistically created policy #39563

merged 14 commits into from
Apr 8, 2024

Commits on Apr 3, 2024

  1. Add some default policy values

    @mountiny
    mountiny committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    f07344b View commit details
    Browse the repository at this point in the history

  2. Make sure we create the workspace with correct harvesting and approva… 

    …l mode defaults
    @mountiny
    mountiny committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    0860477 View commit details
    Browse the repository at this point in the history

  3. Remove deprecated isPreventSelfApprovalEnabled policy property

    @mountiny
    mountiny committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    3131c5d View commit details
    Browse the repository at this point in the history

  4. Merge main

    @mountiny
    mountiny committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    652b2f3 View commit details
    Browse the repository at this point in the history

  5. Create correct next steps when the report is submitted in the submit … 

    …and close approval flow
    @mountiny
    mountiny committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    ebf0eaa View commit details
    Browse the repository at this point in the history

  6. Add unit test for the submit and close next steps

    @mountiny
    mountiny committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    26e41dc View commit details
    Browse the repository at this point in the history

  7. Make sure the next steps are included in the optimistic data when sub… 

    …mitting
    @mountiny
    mountiny committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    bcb3110 View commit details
    Browse the repository at this point in the history

  8. Include the next steps in failure data when submitting no matter what… 

    … approval mode the policy has
    @mountiny
    mountiny committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    36c91d2 View commit details
    Browse the repository at this point in the history

  9. Update the unit tests

    @mountiny
    mountiny committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    67c18ce View commit details
    Browse the repository at this point in the history

  10. Fix style

    @mountiny
    mountiny committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    fc36c7c View commit details
    Browse the repository at this point in the history

  11. Revert podfile lock changes

    @mountiny
    mountiny committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    356bbd0 View commit details
    Browse the repository at this point in the history

  12. Update IOU tests

    @mountiny
    mountiny committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    eb24a0a View commit details
    Browse the repository at this point in the history

  13. Add comment to explain test

    @mountiny
    mountiny committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    737788b View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Merge branch 'main' into vit-39337

    @mountiny
    mountiny committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    2d9027e View commit details
    Browse the repository at this point in the history