[Fix]: Number of announce room members does not update when remove workspace members due to `pendingAction` #39796

allgandalf · 2024-04-06T20:29:12Z

Details

There was a mismatch in the number of participant count shown on report details page, this was because we used to count members in the pending state as well

Fixed Issues

$ #39446
PROPOSAL: #39446 (comment)

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

Same as QA

QA Steps

Create a new workspace
Navigate to the Invite members page in workspace> Invite few accounts
Select the invited members and remove them
Send some messages in the #Announce room
Click on header of the room to open Details
Take a note of number of room members

Note

The expected result is that the number of participants when we click on participants and the count on the previous screen should match

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2024-04-11.at.5.27.05.AM.mov

MacOS: Desktop

Screen.Recording.2024-04-11.at.5.43.39.AM.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-04-11.at.05.48.37.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-04-11.at.23.09.50.mp4

Android: Native

Screen_recording_20240411_221001.webm

Android: mWeb Chrome

Screen_recording_20240411_221001.webm

melvin-bot · 2024-04-06T20:29:16Z

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/ReportDetailsPage.tsx

rayane-djouah · 2024-04-06T23:51:23Z

Lint and perf-tests checks are failing

rayane-djouah · 2024-04-06T23:52:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Recording.2024-04-12.203347.mp4

Android: mWeb Chrome

Recording.2024-04-12.195605.mp4

iOS: Native

Recording.2024-04-12.194418.mp4

iOS: mWeb Safari

Recording.2024-04-12.194801.mp4

MacOS: Chrome / Safari

Recording.2024-04-12.193942.mp4

MacOS: Desktop

Recording.2024-04-12.194159.mp4

rayane-djouah · 2024-04-06T23:54:06Z

Please complete the Screenshots/Videos section.

allgandalf · 2024-04-08T14:39:42Z

sorry, upgraded my system, will put up the changes and the videos by tomorrow, will setup the system today thanks :)

allgandalf · 2024-04-10T14:24:28Z

Finally was able to setup for all platforms (the recent changes in architecture made android fail), will implement these changes in few hours
thanks

allgandalf · 2024-04-10T23:56:40Z

@rayane-djouah , PR ready for your review, can you tick the checklist please ;) thanks

src/pages/ReportDetailsPage.tsx

rayane-djouah · 2024-04-11T01:20:10Z

Please complete Screenshots/Videos section for all platforms. Thanks!

allgandalf · 2024-04-11T17:59:53Z

Added all video @rayane-djouah , also please check comments

rayane-djouah

LGTM

src/pages/ReportDetailsPage.tsx

Co-authored-by: rayane-djouah <77965000+rayane-djouah@users.noreply.github.com>

rayane-djouah

Not a blocker: optional chaining is not needed here as activeChatMembers can be empty but not null or undefined

Co-authored-by: rayane-djouah <77965000+rayane-djouah@users.noreply.github.com>

rayane-djouah

Please resolve merge conflicts correctly

allgandalf · 2024-04-15T15:32:37Z

ahh, I fixed them locally but somehow it failed to get pushed, lol, my bad

OSBotify · 2024-04-15T19:06:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-18T04:56:47Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.4.63-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-22T14:57:46Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

allroundexperts · 2024-10-20T21:27:55Z

src/pages/ReportDetailsPage.tsx

+        const pendingMember = report?.pendingChatMembers?.findLast((member) => member.accountID === accountID.toString());
+        return !pendingMember || pendingMember.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE ? accountID : [];
+    });


We do not filter out the accountID that is not available in the personalDetails object. This resulted in #46670

Fix incorrect length of participants in report details

cb446af

allgandalf requested a review from a team as a code owner April 6, 2024 20:29

melvin-bot bot removed the request for review from a team April 6, 2024 20:29

melvin-bot bot requested a review from rayane-djouah April 6, 2024 20:29

allgandalf commented Apr 6, 2024

View reviewed changes

src/pages/ReportDetailsPage.tsx Outdated Show resolved Hide resolved

fix null check

535f351

rayane-djouah suggested changes Apr 6, 2024

View reviewed changes

src/pages/ReportDetailsPage.tsx Outdated Show resolved Hide resolved

src/pages/ReportDetailsPage.tsx Outdated Show resolved Hide resolved

src/pages/ReportDetailsPage.tsx Outdated Show resolved Hide resolved

src/pages/ReportDetailsPage.tsx Outdated Show resolved Hide resolved

allgandalf added 2 commits April 11, 2024 05:12

Merge branch 'Expensify:main' into issue39446

1a251cf

use flatmap and change vairable name

06c8711

allgandalf added 2 commits April 11, 2024 05:52

fix lint

350b603

fix lint

0b495ff

rayane-djouah suggested changes Apr 11, 2024

View reviewed changes

src/pages/ReportDetailsPage.tsx Outdated Show resolved Hide resolved

src/pages/ReportDetailsPage.tsx Outdated Show resolved Hide resolved

allgandalf added 3 commits April 11, 2024 18:05

Use particpants instead

3112b76

Fix unintended delete

79d3ba6

Revert back to participantsAccountIDs

7bdeca4

Implement latest suggestions

6e1d4b2

rayane-djouah approved these changes Apr 12, 2024

View reviewed changes

melvin-bot bot requested a review from jasperhuangg April 12, 2024 19:40

rayane-djouah reviewed Apr 12, 2024

View reviewed changes

src/pages/ReportDetailsPage.tsx Outdated Show resolved Hide resolved

rayane-djouah reviewed Apr 12, 2024

View reviewed changes

src/pages/ReportDetailsPage.tsx Outdated Show resolved Hide resolved

Update src/pages/ReportDetailsPage.tsx

76bc400

Co-authored-by: rayane-djouah <77965000+rayane-djouah@users.noreply.github.com>

rayane-djouah reviewed Apr 12, 2024

View reviewed changes

allgandalf and others added 2 commits April 13, 2024 01:16

Update src/pages/ReportDetailsPage.tsx

c106551

Co-authored-by: rayane-djouah <77965000+rayane-djouah@users.noreply.github.com>

Resolve merge conflict

f343ab9

rayane-djouah suggested changes Apr 15, 2024

View reviewed changes

Resolve merge conflict

f742baa

rayane-djouah approved these changes Apr 15, 2024

View reviewed changes

jasperhuangg approved these changes Apr 15, 2024

View reviewed changes

jasperhuangg merged commit 74a6195 into Expensify:main Apr 15, 2024
16 checks passed

github-actions bot mentioned this pull request Apr 18, 2024

Deploy Checklist: New Expensify 2024-04-18 #40392

Closed

nkdengineer mentioned this pull request Jun 6, 2024

Fix removed user in offline is not crossed #42817

Merged

50 tasks

allroundexperts reviewed Oct 20, 2024

View reviewed changes

allroundexperts mentioned this pull request Oct 20, 2024

[HOLD for payment] [$250] Admins room members shows 2 members but members list only has one person #46670

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fix]: Number of announce room members does not update when remove workspace members due to `pendingAction` #39796

[Fix]: Number of announce room members does not update when remove workspace members due to `pendingAction` #39796

allgandalf commented Apr 6, 2024 •

edited

Loading

melvin-bot bot commented Apr 6, 2024

rayane-djouah commented Apr 6, 2024

rayane-djouah commented Apr 6, 2024 •

edited

Loading

rayane-djouah commented Apr 6, 2024

allgandalf commented Apr 8, 2024

allgandalf commented Apr 10, 2024

allgandalf commented Apr 10, 2024

rayane-djouah commented Apr 11, 2024

allgandalf commented Apr 11, 2024

rayane-djouah left a comment

rayane-djouah left a comment •

edited

Loading

rayane-djouah left a comment

allgandalf commented Apr 15, 2024

OSBotify commented Apr 15, 2024

OSBotify commented Apr 18, 2024

OSBotify commented Apr 22, 2024

allroundexperts Oct 20, 2024

[Fix]: Number of announce room members does not update when remove workspace members due to pendingAction #39796

[Fix]: Number of announce room members does not update when remove workspace members due to pendingAction #39796

Conversation

allgandalf commented Apr 6, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 6, 2024

rayane-djouah commented Apr 6, 2024

rayane-djouah commented Apr 6, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

rayane-djouah commented Apr 6, 2024

allgandalf commented Apr 8, 2024

allgandalf commented Apr 10, 2024

allgandalf commented Apr 10, 2024

rayane-djouah commented Apr 11, 2024

allgandalf commented Apr 11, 2024

rayane-djouah left a comment

Choose a reason for hiding this comment

rayane-djouah left a comment • edited Loading

Choose a reason for hiding this comment

rayane-djouah left a comment

Choose a reason for hiding this comment

allgandalf commented Apr 15, 2024

OSBotify commented Apr 15, 2024

OSBotify commented Apr 18, 2024

OSBotify commented Apr 22, 2024

allroundexperts Oct 20, 2024

Choose a reason for hiding this comment

[Fix]: Number of announce room members does not update when remove workspace members due to `pendingAction` #39796

[Fix]: Number of announce room members does not update when remove workspace members due to `pendingAction` #39796

allgandalf commented Apr 6, 2024 •

edited

Loading

rayane-djouah commented Apr 6, 2024 •

edited

Loading

rayane-djouah left a comment •

edited

Loading