Fix copy message menu #3999
Closed
Fix copy message menu #3999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Viacheslav80 I think you are using your old branch instead you should start with the latest commit. Because I see that few changes you have done here was never on main. I hope you got my point. |
|
@parasharrajat Hi! all change already in main branch (.RenderHTML, ReportActionItemFragment.js, pressableWithSecondaryInteraction.js ) . I'm sorry but I didn't know which commit to do PR from |
|
My mistake @Viacheslav80. Sorry for getting confused here, I forgot that the revert PR didn't revert the entirety of #3659, just the problematic parts. Since the blue-screen issue has since been fixed, I think the original issue should be completely resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
fix PR #3659 ( removed listener "touchstart" event )
Fixed Issues
Fixes #2279
Tests
QA Steps
Same as above
Tested On
Screenshots
Web
Mobile Web
#### DesktopiOS
Android