Refactor/36648 wallet enablement flow personal info

[koko57]

Details

Personal Info step for Enable Wallet Refactor
DISCLAIMER: not connected to the 1st step of the flow yet

Fixed Issues

$ #36648
PROPOSAL:

Tests

Prerequisites: in settings/about/troubleshoot you should enable Use Staging Server if testing locally

1. Go to settings/wallet page
2. Web / mWeb: Type in '/enable-payments-refactor' after the URL address
3. Mobile: run npx uri-scheme open new-expensify://settings/wallet/enable-payments-refactor --android or npx uri-scheme open new-expensify://settings/wallet/enable-payments-refactor --ios in the terminal with simulator/emulator opened. For desktop deep links are not working properly for nested routes - not available for testing now.
4. Verify that the screens for each substep are displayed correctly:

• First & last name
• date of birth
• Address
• Phone number
• SSN
• Confirmation

5. Verify that validation works for each step and the error is shown when inputs are empty or value is not valid (i.e. invalid phone number)
6. Verify that you can navigate back to the previous step while clicking header back button. NOTE: when going from the first & last step you'll be navigated to /settings/wallet page.
7. Verify that on the Confirmation step all the data you provided is displayed correctly for each field.
8. Verify that when clicking any field you're navigated to the correct step corresponding to that field.
9. When you're navigated to the step you want to edit, verify that you see the previously entered value and you can edit the field.
10. Verify that after editing the field the new value is displayed correctly on the Confirmation step.
11. For now clicking Confirm on the Confirmation step you'll be navigated to /settings/wallet page.

• Verify that no errors appear in the JS console

Offline tests

QA Steps

1. Go to settings/wallet page
2. Web / mWeb: Type in '/enable-payments-refactor' after the URL address
3. Mobile: run npx uri-scheme open new-expensify://settings/wallet/enable-payments-refactor --android or npx uri-scheme open new-expensify://settings/wallet/enable-payments-refactor --ios in the terminal with simulator/emulator opened. For desktop deep links are not working properly for nested routes - not available for testing now.
4. Verify that the screens for each substep are displayed correctly:

• First & last name
• date of birth
• Address
• Phone number
• SSN
• Confirmation

5. Verify that validation works for each step and the error is shown when inputs are empty or value is not valid (i.e. invalid phone number)
6. Verify that you can navigate back to the previous step while clicking header back button. NOTE: when going from the first & last step you'll be navigated to /settings/wallet page.
7. Verify that on the Confirmation step all the data you provided is displayed correctly for each field.
8. Verify that when clicking any field you're navigated to the correct step corresponding to that field.
9. When you're navigated to the step you want to edit, verify that you see the previously entered value and you can edit the field.
10. Verify that after editing the field the new value is displayed correctly on the Confirmation step.
11. For now clicking Confirm on the Confirmation step you'll be navigated to /settings/wallet page.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-18.at.14.30.00.mp4

Android: mWeb Chrome

Screen.Recording.2024-04-18.at.14.24.33.mp4

iOS: Native

Screen.Recording.2024-04-18.at.14.30.00.mp4

iOS: mWeb Safari

Screen.Recording.2024-04-18.at.14.27.42.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-04-18.at.14.20.15.mp4

MacOS: Desktop

n/a

[rezkiy37]

Do we know an issue URL to mention here?

[koko57]

@rezkiy37 no, it will be done in this issue :) But yes, you're right I can add the link

[rezkiy37]

Left a minor comment, LGTM.

[Pujan92]

@koko57 @shawnborton just wanted to confirm some texts by comparing them with figma. Are they fine or need to be like figma?

1. In address screen title and subtitle are different
2. Link text at the bottom is also different

[shawnborton]

I think the links are fine as they are, I vaguely recall a previous issue where we decided not to touch them.

We might want to update the copy though, let's see what @jamesdeanexpensify thinks

[koko57]

@shawnborton I will update the copy (the screen title). My bad, I missed it

[jamesdeanexpensify]

Looking good to me! Just have one last question out to Anu here. I bumped her in DM just now, too.

[koko57]

@Pujan92 issues fixed, ready for review

[Pujan92]

Thanks @koko57, some minor comments.
LGTM!

[Pujan92]

LGTM @mountiny

[mountiny]

In general, this looks good to me, thanks for keeping the train going on this one. Highlighted one question from @Pujan92

[mountiny]

Thanks!

[OSBotify]

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.67-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

[kavimuru]

@koko57 can you help us with mobile and desktop steps?

Mobile: run npx uri-scheme open new-expensify://settings/wallet/enable-payments-refactor --android or npx uri-scheme open new-expensify://settings/wallet/enable-payments-refactor --ios

[OSBotify]

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.68-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.67-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

[koko57]

@kavimuru for mobile, if you're on a real device try typing new-expensify://settings/wallet/enable-payments-refactor in the chrome/safari searchbar - it should open the installed app. For desktop the same step (typing this in the browser) should also work, but for me it always led to Not there step. @Pujan92 how did it work for you?

[Pujan92]

For desktop the same step (typing this in the browser) should also work, but for me it always led to Not there step. @Pujan92 how did it work for you?

I am changing the window location in the developer console with

window.location = "https://dev.new.expensify.com:8083/settings/wallet/enable-payments-refactor"

For staging I think we need to set https://staging.new.expensify.com/settings/wallet/enable-payments-refactor

Screen.Recording.2024-04-30.at.17.58.33.mov

[OSBotify]

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.68-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅