-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md with more Xcode instructions #40575
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Hey @blimpich, GH suggested you as a reviewer so I figured I'd bring you in. I wanted to make a small improvement that would have helped me a lot to see in the Readme, but apparently the process here is different to get the PR approved. Did I do something wrong or should I do something different for this suggested change? Thanks in advance for your help! |
Nope you didn't do anything wrong. If were just updating the readme this PR is good. The failing checks have to do with our automated checklists that we use for all We're not changing any code here though so we're good to skip those checks 👍 |
@blimpich looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Not an emergency, just a README change |
🚀 Deployed to staging by https://github.com/blimpich in version: 1.4.65-0 🚀
|
@blimpich Perrrfect, thanks for the explanation too! |
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀
|
Details
Updated with instructions for Xcode that would have saved me a lot of time!