Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update about page copy #4069

Merged
merged 2 commits into from
Jul 15, 2021
Merged

Update about page copy #4069

merged 2 commits into from
Jul 15, 2021

Conversation

Beamanator
Copy link
Contributor

@Beamanator Beamanator commented Jul 15, 2021 •
edited
Loading

Holding on Spanish translation confirmation here Approved!

Details

Just updating the about page text 👍

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/170730

Tests

  1. Go to the about page (Settings -> About)
  2. Make sure new text is showing

QA Steps

N/A

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-07-15 at 11 19 10 AM

Mobile Web (iOS)

Screen Shot 2021-07-15 at 11 18 38 AM

Desktop

[having a tough time since it seems there's an unrelated bug preventing me from loading anything :D]

iOS

Screen Shot 2021-07-15 at 11 13 35 AM

Android

Screen Shot 2021-07-15 at 11 03 39 AM

@Beamanator Beamanator requested a review from a team July 15, 2021 09:34
@Beamanator Beamanator self-assigned this Jul 15, 2021
@Beamanator Beamanator marked this pull request as draft July 15, 2021 09:34
@Beamanator Beamanator marked this pull request as ready for review July 15, 2021 09:34
@MelvinBot MelvinBot requested review from deetergp and removed request for a team July 15, 2021 09:34
@Beamanator Beamanator changed the title Update about page copy [HOLD] Update about page copy Jul 15, 2021
@Beamanator Beamanator changed the title [HOLD] Update about page copy Update about page copy Jul 15, 2021
@Beamanator
Copy link
Contributor Author

No longer on hold 👍

deetergp
deetergp requested changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@deetergp deetergp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per this convo, it should be El nuevo Expensify https://expensify.slack.com/archives/C21FRDWCV/p1626353964092900?thread_ts=1626339105.092100&cid=C21FRDWCV

@Beamanator Beamanator requested a review from a team as a code owner July 15, 2021 13:02
@Beamanator Beamanator requested review from deetergp and removed request for a team July 15, 2021 13:02
@MelvinBot MelvinBot requested a review from sketchydroide July 15, 2021 13:02
@Beamanator
Copy link
Contributor Author

Good catch! Fixed 👍

deetergp
deetergp approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@deetergp deetergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Está bien, gracias!

@Beamanator Beamanator removed the request for review from sketchydroide July 15, 2021 13:03
sketchydroide
sketchydroide approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@sketchydroide sketchydroide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sketchydroide sketchydroide merged commit 051b5a5 into main Jul 15, 2021
@sketchydroide sketchydroide deleted the beaman-updateAboutPageWithNewExpensifyText branch July 15, 2021 13:06
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jul 15, 2021
Closed
95 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.78-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.79-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deetergp deetergp deetergp approved these changes

@sketchydroide sketchydroide sketchydroide approved these changes

Assignees

@Beamanator Beamanator

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Beamanator @OSBotify @sketchydroide @deetergp