Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags - Violation for unselected dependent tags displays tag name briefly then changes to "tag" #40741

Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
43e030b
fix(money request): missing tags in violations translations
pac-guerreiro Apr 23, 2024
b9a8d90
Merge branch 'main' into pac-guerreiro/issue/38095-missing-tag-violat…
pac-guerreiro Apr 23, 2024
b9d8b24
refactor: remove unexpected return
pac-guerreiro Apr 23, 2024
fcdc252
Merge branch 'main' into pac-guerreiro/issue/38095-missing-tag-violat…
pac-guerreiro Apr 24, 2024
0a0cac1
chore: apply PR suggestions
pac-guerreiro Apr 24, 2024
7a3db00
Merge branch 'main' into pac-guerreiro/issue/38095-missing-tag-violat…
pac-guerreiro Apr 25, 2024
a174c60
fix: tag name missing in error UI
pac-guerreiro Apr 25, 2024
47bf6f2
Merge branch 'main' into pac-guerreiro/issue/38095-missing-tag-violat…
pac-guerreiro Apr 29, 2024
72f8575
refactor: apply pull request suggestions
pac-guerreiro Apr 29, 2024
5c7e16c
chore(typescript): add missing argument
pac-guerreiro Apr 29, 2024
3d6478f
chore(tests): add violation case for missing dependent tags
pac-guerreiro Apr 29, 2024
0ab716d
Merge branch 'main' into pac-guerreiro/issue/38095-missing-tag-violat…
pac-guerreiro May 3, 2024
e297686
refactor: apply pull request suggestions
pac-guerreiro May 3, 2024
a8ef1c3
chore(typescript): add missing argument
pac-guerreiro May 3, 2024
5e36ed7
Merge branch 'main' into pac-guerreiro/issue/38095-missing-tag-violat…
pac-guerreiro May 6, 2024
94c657c
Merge branch 'main' into pac-guerreiro/issue/38095-missing-tag-violat…
pac-guerreiro May 7, 2024
b873788
Merge branch 'main' into pac-guerreiro/issue/38095-missing-tag-violat…
pac-guerreiro May 13, 2024
2e4f7f8
Merge branch 'main' into pac-guerreiro/issue/38095-missing-tag-violat…
pac-guerreiro May 24, 2024
d958c37
Merge branch 'main' into pac-guerreiro/issue/38095-missing-tag-violat…
pac-guerreiro May 27, 2024
8558f65
Merge branch 'main' into pac-guerreiro/issue/38095-missing-tag-violat…
pac-guerreiro May 29, 2024
5e20695
fix: allTagLevels required violation showing on tags that are already…
pac-guerreiro May 29, 2024
525be58
Merge branch 'main' into pac-guerreiro/issue/38095-missing-tag-violat…
pac-guerreiro Jun 3, 2024
d67febb
feat: calculate all tag required violations locally
pac-guerreiro Jun 3, 2024
30189ca
refactor: apply pull request suggestions
pac-guerreiro Jun 5, 2024
4cd7802
Merge branch 'main' into pac-guerreiro/issue/38095-missing-tag-violat…
pac-guerreiro Jun 7, 2024
492a672
refactor: apply suggestions
pac-guerreiro Jun 7, 2024
df3326a
refactor: remove unused argument
pac-guerreiro Jun 7, 2024
e54d678
Merge branch 'main' into pac-guerreiro/issue/38095-missing-tag-violat…
pac-guerreiro Jun 7, 2024
e7f175f
refactor: apply suggestions
pac-guerreiro Jun 7, 2024
df5e19f
refactor: apply suggestions
pac-guerreiro Jun 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into pac-guerreiro/issue/38095-missing-tag-violat…
…ion-for-multi-level-dependencies

# Conflicts:
#	src/libs/Violations/ViolationsUtils.ts
  • Loading branch information
pac-guerreiro committed Jun 7, 2024
commit 4cd7802c8c14b4ef3d70a9300448a966fecb7165
3 changes: 1 addition & 2 deletions src/libs/Violations/ViolationsUtils.ts
Original file line number Diff line number Diff line change
@@ -119,8 +119,7 @@ function getTagViolationForIndependentTags(policyTagList: PolicyTagList, transac
for (let i = 0; i < policyTagKeys.length; i++) {
const selectedTag = selectedTags[i];
const tags = policyTagList[policyTagKeys[i]].tags;
const isTagInPolicy = Object.values(tags).some((tag) => tag.name === selectedTag && Boolean(tag.enabled));

const isTagInPolicy = Object.values(tags).some((tag) => tag.name === selectedTag && !!tag.enabled);
if (!isTagInPolicy) {
newTransactionViolations.push({
name: CONST.VIOLATIONS.TAG_OUT_OF_POLICY,
You are viewing a condensed version of this merge commit. You can view the full changes here.