-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix add center button and blue dot #40759
Merged
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
be55619
fix add center button and blue dot
nkdengineer 0a4b847
fix use util.getBounds
nkdengineer 6093f69
fix update center button
nkdengineer e7420da
fix native issue
nkdengineer b7b9fbb
fix lint
nkdengineer a5ea387
fix lint
nkdengineer a218054
fix create blueDot color
nkdengineer b7a31bc
fix lint
nkdengineer f29e65b
fix only display center button if user interacted
nkdengineer f975e08
fix merge main
nkdengineer 9754dce
fix using toggleCenterButton and related comment
nkdengineer ee0584b
fix type error
nkdengineer 50208b8
fix blue dot radius
nkdengineer ee76e2e
Merge branch 'main' into fix/40209
nkdengineer 3acd03f
fix hide center button if already centered
nkdengineer 757865a
fix lint
nkdengineer f1de15d
fix fade in and out 300ms
nkdengineer d179015
fix remove inline style and rename function
nkdengineer 1ff830a
fix merge main
nkdengineer eadb32a
fix lint
nkdengineer ee8cef6
fix using onTouchCancel instead of onTouchEnd
nkdengineer ee451b3
fix merge main
nkdengineer 273741e
fix native issues
nkdengineer b253ae1
fix remove redundant logic
nkdengineer b12c374
fix merge main
nkdengineer aa487e7
fix compare two coordinates in web
nkdengineer 6ee0862
fix lint
nkdengineer 6c90e66
fix lint
nkdengineer b38b19f
fix always display center button
nkdengineer 0688a0e
fix lint
nkdengineer e30eb90
fix remove maxZoom prop and change the default zoom value
nkdengineer 76679ed
fix remove currentZoom variable
nkdengineer 55f6535
fix merge main
nkdengineer 0f09d6f
fix merge main
nkdengineer 1732367
Merge branch 'main' into fix/40209
nkdengineer cc42428
fix lint
nkdengineer 2d79bd8
fix lint
nkdengineer 95591d9
fix add explaination about haversineDistance
nkdengineer 3fe0372
fix haversineDistance: add new line
nkdengineer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coming from #43058. We missed adding hover and press effect on this button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong. It was not part of the requirement. Design team approved this PR. So the mentioned issued is a new feature/change. @jjcoffee Could you please update the bug list to remove this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might have missed this but the @Expensify/design explicitly stated several times that we wanted this button behavior to match all of our other default buttons. Don't our default buttons all have a hover and press style?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I see. We were pushed to merge this quickly so it might be missed.