[HOLD Expensify/issues/390731] Fix account menu item visibility + reset account values #41079

narefyev91 · 2024-04-26T10:29:53Z

Details

The Vendor row should only show if the admin enables the Default vendor toggle.
The Account row should only be visible when user selects card type

Fixed Issues

$ #41032
PROPOSAL:

Tests

Connect to QBO
Go to Export > Export company cards as page
Choose Vendor bill for export
Verify that Accounts payable menu item is now shown
Verify that Default vendor toggle row is now shown, but the toggle is disabled
Enable the Default vendor toggle
Verify the Vendor menu item is now shown
Disable the Default vendor toggle
Verify the Vendor menu item is now not shown
Change the export type to Credit card
Verify Accounts payable is not shown
Verify Account is shown
Choose an account in the list
Change the export type to Debit card
Verify the value in the Account field is cleared

Verify that no errors appear in the JS console

Offline tests

Connect to QBO
Go to Export > Export company cards as page
Choose Vendor bill for export
Verify that Accounts payable menu item is now shown
Verify that Default vendor toggle row is now shown, but the toggle is disabled
Enable the Default vendor toggle
Verify the Vendor menu item is now shown
Disable the Default vendor toggle
Verify the Vendor menu item is now not shown
Change the export type to Credit card
Verify Accounts payable is not shown
Verify Account is shown
Choose an account in the list
Change the export type to Debit card
Verify the value in the Account field is cleared

QA Steps

Connect to QBO
Go to Export > Export company cards as page
Choose Vendor bill for export
Verify that Accounts payable menu item is now shown
Verify that Default vendor toggle row is now shown, but the toggle is disabled
Enable the Default vendor toggle
Verify the Vendor menu item is now shown
Disable the Default vendor toggle
Verify the Vendor menu item is now not shown
Change the export type to Credit card
Verify Accounts payable is not shown
Verify Account is shown
Choose an account in the list
Change the export type to Debit card
Verify the value in the Account field is cleared

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web1.mov

Screen.Recording.2024-04-26.at.11.41.43.mov

MacOS: Desktop

melvin-bot · 2024-04-26T10:29:58Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

narefyev91 · 2024-04-26T10:30:27Z

@hayata-suenaga @s77rt @trjExpensify

trjExpensify · 2024-04-26T12:16:44Z

Connect to QBO
Go to Export > Export company cards as
Choose Vendor bill for export
Verify that Vendor bill menu item is shown

For these QA steps aren't they more accurately:

Connect to QBO
Go to Export > Export company cards as
Choose Vendor bill for export
Verify that ~~Vendor bill~~ Accounts payable menu item is shown
Verify that Default vendor toggle row is shown, but disabled
Enable "Default vendor"
Verify the Vendor menu item is shown

narefyev91 · 2024-04-26T12:20:09Z

Connect to QBO
Go to Export > Export company cards as
Choose Vendor bill for export
Verify that Vendor bill menu item is shown

For these QA steps aren't they more accurately:

Connect to QBO
Go to Export > Export company cards as
Choose Vendor bill for export
Verify that ~~Vendor bill~~ Accounts payable menu item is shown
Verify that Default vendor toggle row is shown, but disabled
Enable "Default vendor"
Verify the Vendor menu item is shown

I think that it should not be shown? Github issue is saying "The Vendor row should only show if the admin enables the Default vendor toggle."

trjExpensify · 2024-04-26T12:31:26Z

I think that it should not be shown? Github issue is saying "The Vendor row should only show if the admin enables the Default vendor toggle."

Correct, yeah! Happy to make the steps clearer and more expansive:

Connect to QBO
Go to Export > Export company cards as page
Choose Vendor bill for export
Verify that Accounts payable menu item is now shown
Verify that Default vendor toggle row is now shown, but the toggle is disabled
Enable the Default vendor toggle
Verify the Vendor menu item is now shown
Disable the Default vendor toggle
Verify the Vendor menu item is now not shown
Change the export type to Credit card
Verify Accounts payable is not shown
Verify Account is shown
Choose an account in the list
Change the export type to Debit card
Verify the value in the Account field is cleared

trjExpensify · 2024-04-26T12:41:42Z

Okay, results from testing this PR:

2024-04-26_13-32-54.mp4

Account is shown despite no export type being selected (i.e Credit card || Debit card
Vendor menu item is shown despite the Default vendor toggle being disabled
Still no values available for Accounts payable in the list (we need to figure that out somewhere)
We're hitting a bunch of errors when the fields are left blank, but I think that might be because of the lack of defaults I created an issue for here.

Example response from the Network tab:

{
    "jsonCode": 0,
    "message": "PolicyAPI::updatePolicyConnectionConfiguration(): Argument #5 ($settingValue) must be of type string, null given, called in \/git\/releases\/expensify.com\/55c9fbc\/api.php on line 2159",
    "requestID": "87a6a4ec88454164-LHR",
    "onyxData": []
}

Log line as well:

[OOPS!] API threw TypeError - 4ea25fa7eede973d2ab4f5cb3bc3aac9 ~~ exceptionMessage: 'PolicyAPI::updatePolicyConnectionConfiguration(): Argument #5 ($settingValue) must be of type string, null given, called in /git/releases/expensify.com/55c9fbc/api.php on line 2159' exceptionFile: '/git/releases/expensify.com/55c9fbc/lib/PolicyAPI.php' exceptionLine: '6776' exceptionCode: '0'

narefyev91 · 2024-04-26T13:12:12Z

@trjExpensify hmmm... just to clarify. Are you sure that during your testing all changes were applied?
That's what i see on my branch:

Screen.Recording.2024-04-26.at.16.09.25.mov

trjExpensify · 2024-04-26T13:28:57Z

let me retest..

trjExpensify · 2024-04-26T13:36:16Z

Okay yeah, better.. but now it looks like I can't select any accounts (they disappear after selected). Also, it looks like on the out of pocket export settings the values of the previously selected account choice remain.

2024-04-26_14-29-51.mp4

It's really littered with errors, which makes this hard. I created an issue here about the lack of default settings on connecting to QBO that includes selecting the first value from the account list where applicable. By way of a couple of examples:

If Vendor bill is chosen for export, the first value in the Accounts payable list should be selected.
If Credit card is chosen for export, the first value in the Account list should be selected.
... and so on.

As the OP of that issue highlights in points 2, 3 4 of the expected results section it should also happen when:

Turning on a setting which has account(s) that need to be selected

Example: If you enable Default vendor, the first value in the Vendor list should be selected.

Updating the export type from one export method to another

Example:

Select Credit card for export
Account menu item is shown
The first value in the Account list should be selected i.e ("Amex Card Account")
Change to Vendor bill export
Account menu item is replaced with Accounts payable and the previous Account value is cleared
The first value in the Accounts payable list is selected (i.e "Accounts Payable A/P")

I don't think those changes need backend work, and if not, I wonder if we just take care of them here to clean-up a bunch of these errors because they're not being selected? That would make this a lot easier to decipher what remains outstanding to be worked on.

narefyev91 · 2024-04-26T13:49:04Z

Okay yeah, better.. but now it looks like I can't select any accounts (they disappear after selected). Also, it looks like on the out of pocket export settings the values of the previously selected account choice remain.

2024-04-26_14-29-51.mp4
It's really littered with errors, which makes this hard. I created an issue here about the lack of default settings on connecting to QBO that includes selecting the first value from the account list where applicable. By way of a couple of examples:

If Vendor bill is chosen for export, the first value in the Accounts payable list should be selected.

If Credit card is chosen for export, the first value in the Account list should be selected.
... and so on.

As the OP of that issue highlights in points 2, 3 4 of the expected results section it should also happen when:

Turning on a setting which has account(s) that need to be selected

Example: If you enable Default vendor, the first value in the Vendor list should be selected.

Updating the export type from one export method to another

Example:

Select Credit card for export

Account menu item is shown

The first value in the Account list should be selected i.e ("Amex Card Account")

Change to Vendor bill export

Account menu item is replaced with Accounts payable and the previous Account value is cleared

The first value in the Accounts payable list is selected (i.e "Accounts Payable A/P")

I don't think those changes need backend work, and if not, I wonder if we just take care of them here to clean-up a bunch of these errors because they're not being selected? That would make this a lot easier to decipher what remains outstanding to be worked on.

yeah - checking - probably i missed some peace of code. And also will add default for all items

narefyev91 · 2024-04-26T14:37:13Z

@trjExpensify how about this one (let me push fixes and you can play around again):

Screen.Recording.2024-04-26.at.17.35.38.mov

narefyev91 · 2024-04-26T15:05:21Z

@trjExpensify pushed updates - let me know - when you will be able to re-check again

trjExpensify · 2024-04-26T15:19:01Z

Just seen this.. looking.

trjExpensify · 2024-04-26T15:19:18Z

Do I need a fresh build?

trjExpensify · 2024-04-26T15:29:09Z

(I have one running, hang fire).

s77rt · 2024-04-26T15:49:41Z

Verify that Default vendor toggle row is now shown, but the toggle is disabled

This could be confusing. The toggle is switched off not disabled

s77rt · 2024-04-26T15:50:22Z

Can't clear vendor switch error

Screen.Recording.2024-04-26.at.4.49.53.PM.mov

trjExpensify · 2024-04-26T15:55:33Z

Verify that Default vendor toggle row is now shown, but the toggle is disabled
This could be confusing. The toggle is switched off not disabled

Haha, that's what I mean. 😅 Switched off == disabled. Switched on == enabled.

github-actions · 2024-04-26T15:56:16Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/41079/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/41079/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/41079/NewExpensify.dmg	https://41079.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

trjExpensify · 2024-04-26T16:04:11Z

The adhoc build isn't reflecting the changes you've made recently here.

s77rt · 2024-04-26T15:57:32Z

src/pages/workspace/accounting/qbo/export/QuickbooksOutOfPocketExpenseEntitySelectPage.tsx

                Connections.updatePolicyConnectionConfig(policyID, CONST.POLICY.CONNECTIONS.NAME.QBO, CONST.QUICK_BOOKS_CONFIG.EXPORT_ENTITY, row.value);
+                Connections.updatePolicyConnectionConfig(policyID, CONST.POLICY.CONNECTIONS.NAME.QBO, CONST.QUICK_BOOKS_CONFIG.EXPORT_ACCOUNT, accountName);


Two API calls. Should we add this to https://github.com/Expensify/Expensify/issues/390731 @hayata-suenaga

s77rt · 2024-04-26T16:06:11Z

src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountSelectCardPage.tsx

                Connections.updatePolicyConnectionConfig(policyID, CONST.POLICY.CONNECTIONS.NAME.QBO, CONST.QUICK_BOOKS_CONFIG.EXPORT_COMPANY_CARD, row.value);
-                Connections.updatePolicyConnectionConfig(policyID, CONST.POLICY.CONNECTIONS.NAME.QBO, CONST.QUICK_BOOKS_CONFIG.EXPORT_COMPANY_CARD_ACCOUNT);
+                if (row.value === CONST.QUICKBOOKS_EXPORT_COMPANY_CARD.VENDOR_BILL) {
+                    Connections.updatePolicyConnectionConfig(policyID, CONST.POLICY.CONNECTIONS.NAME.QBO, CONST.QUICK_BOOKS_CONFIG.EXPORT_COMPANY_CARD_ACCOUNT);
+                    Connections.updatePolicyConnectionConfig(policyID, CONST.POLICY.CONNECTIONS.NAME.QBO, CONST.QUICK_BOOKS_CONFIG.EXPORT_ACCOUNT_PAYABLE, accountPayable?.[0]?.name);
+                    Connections.updatePolicyConnectionConfig(policyID, CONST.POLICY.CONNECTIONS.NAME.QBO, CONST.QUICK_BOOKS_CONFIG.AUTO_CREATE_VENDOR);


New record! 4 API calls 😅 cc @hayata-suenaga same question ^

@s77rt is correct. This breaks the 1:1:1 API design and shouldn't be allowed.

@narefyev91

also, can you remind me why we added this field to the config object? 😄

also this one

were these values there before your PR? 🤔

The changes in the backend will be done in this GH issue to update several fields of the connections configuration object, but the issue description might need to be updated. cc: @aldo-expensify

There are fields I don't recognized, so I'd wait for @narefyev91's confirmation

yes these values were added in the PR.

I think these fields don't exist on the backend 🤔

We shouldn't be adding config fields that don't already exist. This is a sample working QBO config:

{ "realmId": "2222", "credentials": {}, "companyName": "Expensify", "autoSync": { "jobID": "11111111111", "enabled": true }, "syncPeople": true, "syncItems": true, "markChecksToBePrinted": false, "reimbursableExpensesExportDestination": "bill", "nonReimbursableExpensesExportDestination": "credit_card", "reimbursableExpensesAccount": { "glCode": "", "name": "Accounts Payable", "currency": "USD", "id": "54" }, "nonReimbursableExpensesAccount": { "glCode": "", "name": "Expensify Card Liability Account", "currency": "USD", "id": "135" }, "autoCreateVendor": true, "hasChosenAutoSyncOption": true, "syncClasses": "REPORT_FIELD", "syncCustomers": "REPORT_FIELD", "syncLocations": "REPORT_FIELD", "exportDate": "LAST_EXPENSE", "lastConfigurationTime": 1714507864961, "syncTax": false, "enableNewCategories": true, "export": { "exporter": "aldo+testqbo56242@expensifail.com" }, "nonReimbursableBillDefaultVendor": "NONE", "receivableAccount": { "glCode": "", "name": "Accounts Receivable", "currency": "USD", "id": "53" }, "reimbursementAccountID": "93", "collectionAccountID": "93" }

s77rt · 2024-04-26T16:09:31Z

src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountSelectCardPage.tsx

+                    const accountName = row.value === CONST.QUICKBOOKS_EXPORT_COMPANY_CARD.CREDIT_CARD ? creditCards?.[0]?.name : bankAccounts?.[0]?.name;
+                    Connections.updatePolicyConnectionConfig(policyID, CONST.POLICY.CONNECTIONS.NAME.QBO, CONST.QUICK_BOOKS_CONFIG.EXPORT_COMPANY_CARD_ACCOUNT, accountName);


NAB. Shouldn't we clear EXPORT_ACCOUNT_PAYABLE too?

i think it's not really needed - when user will switch to debit/credit card - EXPORT_ACCOUNT_PAYABLE will not be used anywhere

src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPage.tsx

s77rt · 2024-04-29T15:12:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

s77rt · 2024-04-29T15:13:21Z

@narefyev91 Can you please fix the lint issue

narefyev91 · 2024-04-29T15:14:36Z

@narefyev91 Can you please fix the lint issue

yeah just sent fix for that

melvin-bot · 2024-04-29T15:24:38Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #41032 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

tgolen · 2024-04-29T15:33:35Z

Could you fix the conflicts please before I review this?

# Conflicts: # src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPage.tsx # src/pages/workspace/accounting/qbo/export/QuickbooksOutOfPocketExpenseConfigurationPage.tsx

narefyev91 · 2024-04-29T15:55:21Z

Could you fix the conflicts please before I review this?

Done!

src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPage.tsx

tgolen · 2024-04-29T17:26:19Z

src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPage.tsx

+                                            vendors?.[0]?.name,
+                                        );
+                                    }
+                                    Connections.updatePolicyConnectionConfig(policyID, CONST.POLICY.CONNECTIONS.NAME.QBO, CONST.QUICK_BOOKS_CONFIG.AUTO_CREATE_VENDOR, isOn);


This breaks the 1:1:1 API design rule (only one API request per user action).

@hayata-suenaga @aldo-expensify can you guys confirm this is being worked on in this issue?

yes, this is one of the bullet points in the linked PR 😄

When the admin changes the type of QBO account to export company card (non-reimbursable) expenses to, don't call two updatePolicyConnectionConfig twice to update exportCompanyCard and exportCompanyCardAccount fields. Instead, create a single Web Expensify command to update the both fields at once.

tgolen · 2024-04-29T17:26:53Z

src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountSelectCardPage.tsx

                Connections.updatePolicyConnectionConfig(policyID, CONST.POLICY.CONNECTIONS.NAME.QBO, CONST.QUICK_BOOKS_CONFIG.EXPORT_COMPANY_CARD, row.value);
-                Connections.updatePolicyConnectionConfig(policyID, CONST.POLICY.CONNECTIONS.NAME.QBO, CONST.QUICK_BOOKS_CONFIG.EXPORT_COMPANY_CARD_ACCOUNT);
+                if (row.value === CONST.QUICKBOOKS_EXPORT_COMPANY_CARD.VENDOR_BILL) {
+                    Connections.updatePolicyConnectionConfig(policyID, CONST.POLICY.CONNECTIONS.NAME.QBO, CONST.QUICK_BOOKS_CONFIG.EXPORT_COMPANY_CARD_ACCOUNT);
+                    Connections.updatePolicyConnectionConfig(policyID, CONST.POLICY.CONNECTIONS.NAME.QBO, CONST.QUICK_BOOKS_CONFIG.EXPORT_ACCOUNT_PAYABLE, accountPayable?.[0]?.name);
+                    Connections.updatePolicyConnectionConfig(policyID, CONST.POLICY.CONNECTIONS.NAME.QBO, CONST.QUICK_BOOKS_CONFIG.AUTO_CREATE_VENDOR);


@s77rt is correct. This breaks the 1:1:1 API design and shouldn't be allowed.

src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPage.tsx

tgolen · 2024-05-02T15:18:53Z

I'm putting a HOLD on this until https://github.com/Expensify/Expensify/issues/390731 so this doesn't mistakingly get merged before then.

hayata-suenaga · 2024-05-05T15:02:47Z

@narefyev91, could you merge the main branch? There were several changes currently made. I tried to test your branch, but there are several errors that were now resolved on the main branch (ex. navigating to the Export page crushes the app).

hayata-suenaga · 2024-05-06T14:00:03Z

...ges/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPayableSelectPage.tsx

@@ -22,19 +22,19 @@ type CardListItem = ListItem & {
 function QuickbooksCompanyCardExpenseAccountPayableSelectPage({policy}: WithPolicyConnectionsProps) {
    const {translate} = useLocalize();
    const styles = useThemeStyles();
-    const {accountsPayable} = policy?.connections?.quickbooksOnline?.data ?? {};
+    const {accountPayable} = policy?.connections?.quickbooksOnline?.data ?? {};


Just a memo for myself. Checked this field name is correct

hayata-suenaga · 2024-05-06T14:02:02Z

src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountSelectCardPage.tsx

@@ -30,6 +30,7 @@ function QuickbooksCompanyCardExpenseAccountSelectCardPage({policy}: WithPolicyC
    const policyID = policy?.id ?? '';
    const {exportCompanyCard, syncLocations} = policy?.connections?.quickbooksOnline?.config ?? {};
    const isLocationEnabled = Boolean(syncLocations && syncLocations !== CONST.INTEGRATION_ENTITY_MAP_TYPES.NONE);
+    const {creditCards, bankAccounts, accountPayable} = policy?.connections?.quickbooksOnline?.data ?? {};


memo: checked that these field names are correct

hayata-suenaga · 2024-05-06T15:04:10Z

Closing the PR per this comment.

The work will be done in this PR by Aldo, which makes sure that the 1:1:1 pattern is honored.

Fix account menu item visibility + reset account values

2c1cdf5

narefyev91 requested a review from a team as a code owner April 26, 2024 10:29

melvin-bot bot requested review from s77rt and removed request for a team April 26, 2024 10:29

trjExpensify added the Ready To Build label Apr 26, 2024

This comment has been minimized.

Sign in to view

correct naming for accountPayable

27e1fac

mountiny assigned narefyev91 Apr 26, 2024

reset values to defaults

3378491

s77rt suggested changes Apr 26, 2024

View reviewed changes

update lint

d23b303

s77rt approved these changes Apr 29, 2024

View reviewed changes

melvin-bot bot requested a review from tgolen April 29, 2024 15:24

narefyev91 added 2 commits April 29, 2024 18:46

Merge branch 'refs/heads/main' into fix-account-visibility

2e22a9e

# Conflicts: # src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPage.tsx # src/pages/workspace/accounting/qbo/export/QuickbooksOutOfPocketExpenseConfigurationPage.tsx

conflicts

0b029a3

tgolen requested changes Apr 29, 2024

View reviewed changes

update after review

c32473b

narefyev91 requested a review from tgolen April 30, 2024 06:59

tgolen requested changes Apr 30, 2024

View reviewed changes

src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPage.tsx Outdated Show resolved Hide resolved

src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPage.tsx Outdated Show resolved Hide resolved

update callbacks

7b073df

narefyev91 requested a review from tgolen April 30, 2024 14:46

hayata-suenaga mentioned this pull request May 1, 2024

Fix account type name constants #41155

Merged

48 tasks

tgolen changed the title ~~Fix account menu item visibility + reset account values~~ [HOLD] Fix account menu item visibility + reset account values May 2, 2024

tgolen changed the title ~~[HOLD] Fix account menu item visibility + reset account values~~ [HOLD https://github.com/Expensify/Expensify/issues/390731] Fix account menu item visibility + reset account values May 2, 2024

tgolen changed the title ~~[HOLD https://github.com/Expensify/Expensify/issues/390731] Fix account menu item visibility + reset account values~~ [HOLD Expensify/issues/390731] Fix account menu item visibility + reset account values May 2, 2024

tgolen mentioned this pull request May 3, 2024

[Wave Collect][QBO] The Vendor push row appears before enabling Default vendor #41032

Closed

6 tasks

hayata-suenaga mentioned this pull request May 5, 2024

Use new multi config edit command #41627

Merged

50 tasks

hayata-suenaga reviewed May 6, 2024

View reviewed changes

hayata-suenaga closed this May 6, 2024

		Connections.updatePolicyConnectionConfig(policyID, CONST.POLICY.CONNECTIONS.NAME.QBO, CONST.QUICK_BOOKS_CONFIG.EXPORT_ENTITY, row.value);
		Connections.updatePolicyConnectionConfig(policyID, CONST.POLICY.CONNECTIONS.NAME.QBO, CONST.QUICK_BOOKS_CONFIG.EXPORT_ACCOUNT, accountName);

		const accountName = row.value === CONST.QUICKBOOKS_EXPORT_COMPANY_CARD.CREDIT_CARD ? creditCards?.[0]?.name : bankAccounts?.[0]?.name;
		Connections.updatePolicyConnectionConfig(policyID, CONST.POLICY.CONNECTIONS.NAME.QBO, CONST.QUICK_BOOKS_CONFIG.EXPORT_COMPANY_CARD_ACCOUNT, accountName);

[HOLD Expensify/issues/390731] Fix account menu item visibility + reset account values #41079

[HOLD Expensify/issues/390731] Fix account menu item visibility + reset account values #41079

Conversation

narefyev91 commented Apr 26, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 26, 2024

narefyev91 commented Apr 26, 2024

This comment has been minimized.

trjExpensify commented Apr 26, 2024

narefyev91 commented Apr 26, 2024

trjExpensify commented Apr 26, 2024

trjExpensify commented Apr 26, 2024

narefyev91 commented Apr 26, 2024

trjExpensify commented Apr 26, 2024

trjExpensify commented Apr 26, 2024

narefyev91 commented Apr 26, 2024

narefyev91 commented Apr 26, 2024 • edited Loading

narefyev91 commented Apr 26, 2024

trjExpensify commented Apr 26, 2024

trjExpensify commented Apr 26, 2024

trjExpensify commented Apr 26, 2024

s77rt commented Apr 26, 2024

s77rt commented Apr 26, 2024

trjExpensify commented Apr 26, 2024

github-actions bot commented Apr 26, 2024

trjExpensify commented Apr 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hayata-suenaga Apr 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hayata-suenaga Apr 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

s77rt commented Apr 29, 2024

Reviewer Checklist

Screenshots/Videos

s77rt commented Apr 29, 2024

narefyev91 commented Apr 29, 2024

melvin-bot bot commented Apr 29, 2024

tgolen commented Apr 29, 2024

narefyev91 commented Apr 29, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hayata-suenaga Apr 29, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tgolen commented May 2, 2024

hayata-suenaga commented May 5, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hayata-suenaga commented May 6, 2024

narefyev91 commented Apr 26, 2024 •

edited

Loading

narefyev91 commented Apr 26, 2024 •

edited

Loading

hayata-suenaga Apr 30, 2024 •

edited

Loading

hayata-suenaga Apr 30, 2024 •

edited

Loading

hayata-suenaga Apr 29, 2024 •

edited

Loading