Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Update staging from main #4113

Merged
merged 471 commits into from
Jul 16, 2021
Merged

[No QA] Update staging from main #4113

merged 471 commits into from
Jul 16, 2021

Conversation

roryabraham
Copy link
Contributor

cc @tgolen

Details

Come from this comment

Fixed Issues

$ #4060

Tests

  1. Merge this PR. I don't expect a staging deploy to occur.
  2. Unlock and relock the StagingDeployCash.
  3. A staging deploy should occur.
  4. Hopefully nothing breaks, because this is something outside the normal flow. 🙃

QA Steps

No QA.

Tested On

n/a – GitHub only.

OSBotify added 30 commits May 20, 2021 16:51
@roryabraham roryabraham self-assigned this Jul 16, 2021
@roryabraham roryabraham requested a review from a team as a code owner July 16, 2021 15:09
@MelvinBot MelvinBot requested review from tgolen and removed request for a team July 16, 2021 15:09
Copy link
Contributor

@tgolen tgolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's do it.

@roryabraham roryabraham merged commit bb02d77 into main Jul 16, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@roryabraham
Copy link
Contributor Author

As expected, no staging deploy occurred. The above comment is not 100% accurate, but we don't need to worry about that right now.

@roryabraham
Copy link
Contributor Author

Oof, I think this was backwards 🤦

@roryabraham
Copy link
Contributor Author

We merged staging into main, not the other way around. That was not what I meant to do... 😓

@roryabraham
Copy link
Contributor Author

Sorry for the inconvenience @tgolen, but I think now the best thing to do is to create a normal PR to fix the issue on main and then CP it to staging.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.79-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.80-2🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.