[TS migration] Migrate MoneyTemporaryForRefactorRequestParticipantsSe… #41216

pasyukevich · 2024-04-29T14:53:19Z

…lector.js to MoneyRequestParticipantsSelector.tsx

Details

Fixed Issues

$ #29107 - MoneyTemporaryForRefactorRequestParticipantsSelector.js to MoneyRequestParticipantsSelector.tsx migration part
PROPOSAL:

Tests

Tap on the green plus button (FAB)
Select Request Money/Manual
Select any currency and amount
Press "Next" button
Search for a needed participant
Select it
Verify that selector worked as expected

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android-native-converted.webm

Android: mWeb Chrome

android-web-converted.webm

iOS: Native

ios-native-converted.mp4

iOS: mWeb Safari

ios-web-converted.mp4

MacOS: Chrome / Safari

desktop-web-converted.mov

MacOS: Desktop

desktop-native-converted.mov

…lector.js to MoneyRequestParticipantsSelector.tsx

src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

DylanDylann · 2024-05-06T02:29:29Z

@pasyukevich Please speed up this one, this is the last issue of this epic that is over the deadline (1 May)

…equestParticipantsSelector

kubabutkiewicz · 2024-05-06T11:28:26Z

src/pages/iou/request/MoneyRequestParticipantsSelector.tsx


 const isIOUSplit = iouType === CONST.IOU.TYPE.SPLIT;
- const isCategorizeOrShareAction = [CONST.IOU.ACTION.CATEGORIZE, CONST.IOU.ACTION.SHARE].includes(action);
+ const isCategorizeOrShareAction = ([CONST.IOU.ACTION.CATEGORIZE, CONST.IOU.ACTION.SHARE] as string[]).includes(action);


nab: you can use some instead of includes to avoid assertion

src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

kubabutkiewicz · 2024-05-06T11:29:37Z

src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

@@ -131,7 +124,7 @@ function MoneyTemporaryForRefactorRequestParticipantsSelector({participants, onF
 isCategorizeOrShareAction ? 0 : undefined,
 );

- const formatResults = OptionsListUtils.formatSectionsFromSearchTerm(debouncedSearchTerm, participants, chatOptions.recentReports, chatOptions.personalDetails, personalDetails, true);
+ const formatResults = OptionsListUtils.formatSectionsFromSearchTerm(debouncedSearchTerm, participants.map((participant) => ({...participant, reportID: participant.reportID ?? ''})), chatOptions.recentReports, chatOptions.personalDetails, personalDetails, true);


why this map is added ?

Because of type diff - Participant[] vs ReportUtils.OptionData[]

ReportUtils.OptionData[] requires reportID with value

src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

melvin-bot · 2024-05-06T18:41:31Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

blazejkustra

Minor comments, other than that LGTM!

src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

DylanDylann · 2024-05-07T07:46:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-07.at.18.12.21.mov

Android: mWeb Chrome

Screen.Recording.2024-05-07.at.18.09.07.mov

iOS: Native

Screen.Recording.2024-05-07.at.18.11.47.mov

iOS: mWeb Safari

Screen.Recording.2024-05-07.at.18.07.31.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-07.at.18.05.46.mov

MacOS: Desktop

Screen.Recording.2024-05-07.at.18.09.44.mov

DylanDylann · 2024-05-07T08:24:49Z

src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

- (canUseP2PDistanceRequests || iouRequestType !== CONST.IOU.REQUEST_TYPE.DISTANCE) &&
- ![CONST.IOU.TYPE.PAY, CONST.IOU.TYPE.TRACK, CONST.IOU.TYPE.INVOICE].includes(iouType) &&
- ![CONST.IOU.ACTION.SHARE, CONST.IOU.ACTION.SUBMIT, CONST.IOU.ACTION.CATEGORIZE].includes(action);
+ (canUseP2PDistanceRequests ?? iouRequestType !== CONST.IOU.REQUEST_TYPE.DISTANCE) &&


Using ?? will change the behavior, could you help to explain about this change?

It caused this bug: Can't make multiple selection

Screen.Recording.2024-05-07.at.15.30.00.mov

reverted

There is no need for this change, missed logic during the migration

DylanDylann

LGTM 💯

chiragsalian

Code LGTM but we're on a merge freeze this week so I'm holding off merging at this time.

tgolen · 2024-05-10T14:47:58Z

I've removed the HOLD on this and will go ahead and merge it.

OSBotify · 2024-05-10T14:55:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

DylanDylann · 2024-05-10T15:07:43Z

@tgolen Could you help create an issue handling the payment for PR reviewing?

tgolen · 2024-05-10T17:00:19Z

Sure, can you please comment on https://github.com/Expensify/Expensify/issues/395017 and I'll assign it to you.

DylanDylann · 2024-05-10T17:02:06Z

@tgolen This is an internal repo. I can't access to it

tgolen · 2024-05-10T17:03:12Z

Arg, wrong repo. Sorry!

OSBotify · 2024-05-13T08:42:15Z

🚀 Deployed to staging by https://github.com/tgolen in version: 1.4.73-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-15T09:50:25Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.73-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

pasyukevich force-pushed the feature/migration-MoneyTemporaryForRefactorRequestParticipantsSelector branch from 31c2be1 to 2cdb8ec Compare April 29, 2024 15:09

[TS migration] Migrate MoneyTemporaryForRefactorRequestParticipantsSe…

6ba7034

…lector.js to MoneyRequestParticipantsSelector.tsx

pasyukevich force-pushed the feature/migration-MoneyTemporaryForRefactorRequestParticipantsSelector branch from 2cdb8ec to 6ba7034 Compare April 29, 2024 15:21

pac-guerreiro reviewed Apr 30, 2024

View reviewed changes

src/pages/iou/request/MoneyRequestParticipantsSelector.tsx Show resolved Hide resolved

Merge branch 'main' into feature/migration-MoneyTemporaryForRefactorR…

43c3420

…equestParticipantsSelector

kubabutkiewicz reviewed May 6, 2024

View reviewed changes

pasyukevich added 2 commits May 6, 2024 13:57

address comments

0f1e698

fix lint

43cb010

kubabutkiewicz approved these changes May 6, 2024

View reviewed changes

pasyukevich marked this pull request as ready for review May 6, 2024 18:41

pasyukevich requested a review from a team as a code owner May 6, 2024 18:41

melvin-bot bot requested review from DylanDylann and removed request for a team May 6, 2024 18:41

blazejkustra approved these changes May 7, 2024

View reviewed changes

src/pages/iou/request/MoneyRequestParticipantsSelector.tsx Outdated Show resolved Hide resolved

src/pages/iou/request/MoneyRequestParticipantsSelector.tsx Outdated Show resolved Hide resolved

DylanDylann reviewed May 7, 2024

View reviewed changes

DylanDylann mentioned this pull request May 7, 2024

[HOLD for payment 2024-05-22] [LOW] Distance: PHASE 2 CLEANUP - Refactor navigation among screens related to money request features #29107

Closed

25 tasks

pasyukevich added 2 commits May 7, 2024 11:13

fix regression, type update

c5c3c45

update property to required

a407e7d

DylanDylann approved these changes May 7, 2024

View reviewed changes

melvin-bot bot requested a review from chiragsalian May 7, 2024 11:14

chiragsalian approved these changes May 9, 2024

View reviewed changes

chiragsalian changed the title ~~[TS migration] Migrate MoneyTemporaryForRefactorRequestParticipantsSe…~~ [HOLD merge freeze earnings call][TS migration] Migrate MoneyTemporaryForRefactorRequestParticipantsSe… May 9, 2024

tgolen changed the title ~~[HOLD merge freeze earnings call][TS migration] Migrate MoneyTemporaryForRefactorRequestParticipantsSe…~~ [TS migration] Migrate MoneyTemporaryForRefactorRequestParticipantsSe… May 10, 2024

tgolen merged commit 82c7e9d into Expensify:main May 10, 2024
18 of 20 checks passed

tgolen mentioned this pull request May 10, 2024

[Payment issue] [TS migration] Migrate MoneyTemporaryForRefactorRequestParticipantsSe #41989

Closed

github-actions bot mentioned this pull request May 13, 2024

Deploy Checklist: New Expensify 2024-05-13 #42040

Closed

74 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate MoneyTemporaryForRefactorRequestParticipantsSe… #41216

[TS migration] Migrate MoneyTemporaryForRefactorRequestParticipantsSe… #41216

pasyukevich commented Apr 29, 2024 •

edited

Loading

DylanDylann commented May 6, 2024

kubabutkiewicz May 6, 2024

pasyukevich May 6, 2024

kubabutkiewicz May 6, 2024

pasyukevich May 6, 2024

melvin-bot bot commented May 6, 2024

blazejkustra left a comment

DylanDylann commented May 7, 2024 •

edited

Loading

DylanDylann May 7, 2024

DylanDylann May 7, 2024

pasyukevich May 7, 2024

DylanDylann left a comment

chiragsalian left a comment

tgolen commented May 10, 2024

OSBotify commented May 10, 2024

DylanDylann commented May 10, 2024

tgolen commented May 10, 2024

DylanDylann commented May 10, 2024

tgolen commented May 10, 2024

OSBotify commented May 13, 2024

OSBotify commented May 15, 2024

[TS migration] Migrate MoneyTemporaryForRefactorRequestParticipantsSe… #41216

[TS migration] Migrate MoneyTemporaryForRefactorRequestParticipantsSe… #41216

Conversation

pasyukevich commented Apr 29, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

DylanDylann commented May 6, 2024

kubabutkiewicz May 6, 2024

Choose a reason for hiding this comment

pasyukevich May 6, 2024

Choose a reason for hiding this comment

kubabutkiewicz May 6, 2024

Choose a reason for hiding this comment

pasyukevich May 6, 2024

Choose a reason for hiding this comment

melvin-bot bot commented May 6, 2024

blazejkustra left a comment

Choose a reason for hiding this comment

DylanDylann commented May 7, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

DylanDylann May 7, 2024

Choose a reason for hiding this comment

DylanDylann May 7, 2024

Choose a reason for hiding this comment

pasyukevich May 7, 2024

Choose a reason for hiding this comment

DylanDylann left a comment

Choose a reason for hiding this comment

chiragsalian left a comment

Choose a reason for hiding this comment

tgolen commented May 10, 2024

OSBotify commented May 10, 2024

DylanDylann commented May 10, 2024

tgolen commented May 10, 2024

DylanDylann commented May 10, 2024

tgolen commented May 10, 2024

OSBotify commented May 13, 2024

OSBotify commented May 15, 2024

pasyukevich commented Apr 29, 2024 •

edited

Loading

DylanDylann commented May 7, 2024 •

edited

Loading