-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing multi tag view #41337
Add missing multi tag view #41337
Conversation
@trjExpensify first path for adding multi tag flow. Currently screens are communicated correctly, just needs to make changes for bulk actions. I think Eto can keep this up Screen.Recording.2024-04-30.at.16.07.17.mov |
Yep, exactly. Only when more than one level is imported. This example you shared only has one level of tag in view though, but I take it that's just dev antics? 😅 |
Will continue on this here #41351 |
Closing this per #41279 (comment) |
Details
[QBO] Implement support for importing more than one of Classes, Customers/Projects or Locations on the tags page
Fixed Issues
$ #41279
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop