Refactor withLocalize + fix displayName

[marcaaron]

Details

• The previous implementation caused any wrapped components to recreate the methods passed on render.
• This binds the methods so they are not created on re-renders.
• The displayName feature of withLocalize was also not working correctly when wrapped withOnyx so that is also fixed now
• Adds missing displayName to some components

Fixed Issues

$ #4109

Tests

QA Steps

There are no particular tests as the behavior of the app should largely remain the same after these changes.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[iwiznia]

I understand this is faster, but really curious on if it makes any difference in the real world.

[marcaaron]

Let's merge it and find out. Worst case scenario we are enforcing a better practice like the one suggested here -> https://reactnative.dev/docs/optimizing-flatlist-configuration#avoid-anonymous-function-on-renderitem

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging in version: 1.0.80-3🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production in version: 1.0.81-4🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅