Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix circle mobile icons for default room in focus mode #4153

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Fix circle mobile icons for default room in focus mode #4153

merged 1 commit into from
Jul 20, 2021

Conversation

TomatoToaster
Copy link
Contributor

@TomatoToaster TomatoToaster commented Jul 20, 2021 •
edited
Loading

@yuwenmemon, please review

Details

My B, when reviewing/testing this one I thought I had tested avatarSmall on iOS/android but forgot that those are focus icons. This one also needs to get rid of the backgroundColor rule since it'll make focus icons square:
Bad:
image

Good:
image

Fixed Issues

Follow up for: #4144

Tests

QA done locally

QA Steps

This is for defaultRooms, should require an internal test.

  1. Go to Preferences and set Priority Mode to #focus
  2. Verify the icons for default rooms are circular like in the screenshot above.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

iOS

image

Android

image

@TomatoToaster TomatoToaster requested a review from yuwenmemon July 20, 2021 18:15
@TomatoToaster TomatoToaster self-assigned this Jul 20, 2021
@TomatoToaster TomatoToaster requested a review from a team as a code owner July 20, 2021 18:15
@TomatoToaster TomatoToaster removed the request for review from a team July 20, 2021 18:15
@MelvinBot MelvinBot requested a review from sketchydroide July 20, 2021 18:15
yuwenmemon
yuwenmemon approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@yuwenmemon yuwenmemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice catch 👍

@TomatoToaster TomatoToaster merged commit 98a2ea9 into main Jul 20, 2021
@TomatoToaster TomatoToaster deleted the amal-def-room-avatar-focus branch July 20, 2021 21:08
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jul 23, 2021
Closed
60 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.79-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@isagoico
Copy link

@TomatoToaster Looks like another internal QA. Can you take care of this and check it off the list? 🙇

@TomatoToaster
Copy link
Contributor Author

Thanks for the ping!

This is a pass 🎉 image

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.80-2🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuwenmemon yuwenmemon yuwenmemon approved these changes

@sketchydroide sketchydroide Awaiting requested review from sketchydroide

Assignees

@TomatoToaster TomatoToaster

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TomatoToaster @OSBotify @isagoico @yuwenmemon