Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix keyboard shortcut #4159

Merged
merged 5 commits into from
Jul 27, 2021
Merged

Fix keyboard shortcut #4159

merged 5 commits into from
Jul 27, 2021

Conversation

rushatgabhane
Copy link
Member

@rushatgabhane rushatgabhane commented Jul 21, 2021 •
edited
Loading

cc @tgolen

Details

Comment

Fixed Issues

$ #4028

Tests

Test 1

  1. Open Search with Cmd + K
  2. Open New Group with Cmd + Shift + K
  3. Click outside New Group popup to close it.
  4. Verify that pressing Escape key closes Search.

Test 2

  1. Open Search with Cmd + K
  2. Open New Group with Cmd + Shift + K
  3. Verify that pressing Escape closes New Group.
  4. Verify that pressing Escape closes Search.

QA

Make sure that keyboard shortcuts work, and Escape closes modals on Web and Desktop.

Tested On

  • Web
  • Desktop
  • Not Applicable. Just verify that there are no errors.
    • Mobile Web
    • iOS
    • Android

Screenshots

Web

solution.demo.mp4

Desktop

@rushatgabhane rushatgabhane requested a review from a team as a code owner July 21, 2021 07:15
@MelvinBot MelvinBot requested review from madmax330 and removed request for a team July 21, 2021 07:16
madmax330
madmax330 approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@madmax330 madmax330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @tgolen will let you have the last pass

@madmax330 madmax330 requested a review from tgolen July 22, 2021 09:59
@tgolen tgolen merged commit cd663c7 into Expensify:main Jul 27, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jul 28, 2021
Closed
71 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.80-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.81-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madmax330 madmax330 madmax330 approved these changes

@tgolen tgolen tgolen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rushatgabhane @OSBotify @tgolen @madmax330