Prevent invalid configuration between location and JE selection

[hayata-suenaga]

Details

Fixed Issues

$ #41621
PROPOSAL: N/A

Tests / QA Steps

1. Create a new workspace
2. Go to the More Feature page and enable the accounting feature
3. Connect to QBO
4. Go to the Export page. Check that Vendor Bill is selected for Export out-of-pocket expenses as by default
5. Go to the Import page. Check the Location configuration. Check that the Switch is toggled off and locked. There should be a hint text under the Switch button. Use the screenshot below as a reference.

6. Go to the Export page. Select Journal Entry for Export out-of-pocket expenses as
7. Go to the Import page. Check Location. Confirm that now you can toggle the switch on or off (i.e. not locked)
8. Enable the Location import (i.e. toggle it on)
9. Export -> Export out-of-pocket expenses as
10. Confirm that Journal Entry is the only option displayed.
11. Check that there is a hint text as shown below

13. Go back and click the company card export menu
14. Confirm that the only two options displayed is Credit card or debit card
15. Check that there is a hint text displayed and that it looks like the one below

Offline tests

N/A

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
  I tested the flow on the desktop Chrome
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-05-10.at.5.50.56.PM.mov

MacOS: Desktop

[melvin-bot]

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[hayata-suenaga]

@rojiphil bump on this one, please 🙇

[rojiphil]

I have left some comments for your consideration. Thanks

[hayata-suenaga]

I decided to go with the original UI copy here

[trjExpensify]

I decided to go with the original UI copy here

Do you mean this one we settled on?

Note: QuickBooks Online does not support adding a location to vendor bills or checks. Update your export preference to journal entry if you'd like to import locations as tags.

[hayata-suenaga]

I also cannot reproduce the issue No. 1 on my local environment 🤔

[trjExpensify]

Oh! I notice two issues:

1. We are unable to set the Journal Entry option now. And the BE sends this error.
   
2. Along with the Journey Entry not getting set, the configuration page displays that locations are enabled when it is not set.
   

Here is a test video to demonstrate this.

41638-je-notset.mp4

Looking at this video. @rojiphil doesn't seem to have any changes synced for an hour. Also, even with vendor bill selected he was missing a value for Accounts payable.

Roji, what is the state of that account? Did you connect afresh to QBO, or is it perhaps stale?

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/41638/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/41638/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/41638/NewExpensify.dmg	https://41638.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[hayata-suenaga]

I also cannot reproduce the issue No. 2

[hayata-suenaga]

Testing with the ad hoc, but I still cannot reproduce the two issues

[trjExpensify]

Same..

2024-05-31_20-24-51.mp4

[trjExpensify]

@s77rt as you're online.. if you can't reproduce this either, I think we move on and if Roji confirms it's not an account issue we can always follow-up in a separate PR.

[hayata-suenaga]

maybe the issue @rojiphil experienced is a temporary issue.

I'll ask @aldo-expensify if he is available for the internal review 😄

[rojiphil]

Roji, what is the state of that account? Did you connect afresh to QBO, or is it perhaps stale?

That's a good question. Let me check this.

[s77rt]

@rojiphil Can you check the Payload tab, what are you sending to the server

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/41638/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/41638/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/41638/NewExpensify.dmg	https://41638.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[s77rt]

@rojiphil Also can you test on staging or on main? Your issue does not look related to this PR so we probably shouldn't block on this

[aldo-expensify]

Code looks good to me, going to test now...

[rojiphil]

Roji, what is the state of that account? Did you connect afresh to QBO, or is it perhaps stale?

That's a good question. Let me check this.

1. Ha Ha. You were right. It was a stale account. But I think we need to handle such scenarios gracefully.

2. Anyway, going further, I just tested with a new account and notice another issue i.e. locations cannot be toggled when no export options are set yet. This is a regression.

3. Also, NAB but I notice an empty row below Export as.

Here is a test video to demonstrate this.

41638-locations-disabled.mp4

[aldo-expensify]

Anyway, going further, I just tested with a new account and notice another issue i.e. locations cannot be toggled when no export options are set yet. This is a regression.

Why there wouldn't be any export option? @trjExpensify is this expected in a real case? Does this happen when the QBO account doesn't have accounts setup on the QBO side?

[trjExpensify]

There should always be an export option. Looking at that screenshot, Roji ran into the pusher issue, see how nothing is set:

[aldo-expensify]

Tested well for me

Screen.Recording.2024-05-31.at.12.55.21.PM.mov

We should confirm #41638 (comment) before merging though.

[aldo-expensify]

There should always be an export option. Looking at that screenshot, Roji ran into the pusher issue, see how nothing is set:

Nice, thanks for confirming, then I think it is fine to :donothing and merge as it is.

[trjExpensify]

Sounds good to me!

[OSBotify]

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.79-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅