Prevent infinite loading in validateBankAccount

[luacmartins]

cc @chiragsalian

Details

Removes return statement that kept API calls in an infinite loading state.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/171371

Tests

1. Create a new Workspace
2. Follow these steps to add a PENDING account.
3. When prompted for the 3 codes, follow these steps.
4. Verify that the button text reappears.

QA Steps

Internal QA.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

web.mov

Mobile Web

Desktop

iOS

Android

[marcaaron]

Nice catch!

But I think the intention to early return here is correct as the non 200 case would be error handling logic.

So we just need to set loading to false and error to empty string maybe ''?

    Navigation.dismissModal();
    Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {loading: false, error: ''});
    return;
}

[luacmartins]

Updated!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging in version: 1.0.79-5🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[MitchExpensify]

Prevent.infinite.loading.in.validateBankAccount.mov

It was weird to see "Get Started" as the button in Expensify Card when it should read "Finish Setup". That screen did not auto update after entering the validation amounts. I would have expected to see "Manage Cards" at that point. Also "Get Started" brought me to a blank modal before the hard refresh

[luacmartins]

Thanks for the input @Mitch! I put up this PR to update the button text.

[isagoico]

@luacmartins @MitchExpensify Should this issue #4165 (comment) be treated as a deploy blocker or can we check off this PR from the list?

[luacmartins]

I think it's fine to check it off the list since it solves the issue at hand and the remaining steps are only copy that needs to be updated. I put up another PR to update the button text.

[OSBotify]

🚀 Deployed to production in version: 1.0.80-2🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[kevinksullivan]

@luacmartins I ran into the same experience after the Company Information step, where now I am stuck on a loading spinner.

So I haven't been able to get to the ValidateBankAccount step, but it looks like we may have similar problems at each step of the process... Should I open a separate GH? And would you want to pick it up since you just knocked this one out?

[kevinksullivan]

Is there a reason this didn't closed if the PR is deployed to production?

[luacmartins]

Not sure, for some reason I can't manually close it either...

[MitchExpensify]

Weird, neither can I.